From patchwork Sat Jun 21 19:37:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Chia-Yu Chang \(Nokia\)" X-Patchwork-Id: 898914 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012036.outbound.protection.outlook.com [52.101.66.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1A626FDAC; Sat, 21 Jun 2025 19:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.36 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750534692; cv=fail; b=KQmHkXc4xd9ahdJumi+woYmC4xyrIvVIW/rzbrAyO/tSpVDat5/Bj3L5BQI2jNIwgIXyxr+x2qqyZLZrTjlyMGiiLlQlCAkA3X7IfFH0r5m09u6ALhiUIJ6Qu4eCu7ie9f8HsgetxKIlY2z/gFKyUbT5qcMzMh8waBpj51QhYWw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750534692; c=relaxed/simple; bh=tAoIQmS+jzId2GDiEkPWpoWH4tUBog3+H+DlpW6QKLY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=JO28vW/H63nOyb7V2EgRUzbpicCDwOgCj91FTm5+qoJHxeCyCKgKQ4XCSob/+weeg26z4d9Ti7TagQqd4oeM8CuLme8pmvVVzZuuCZ/9s+NYOptFS/H0ahaN5AQZ/YfjWYomA7NICd1R2nSWwzIhF+C1HsIhLUfPscgTMRh1d0I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia-bell-labs.com; spf=fail smtp.mailfrom=nokia-bell-labs.com; dkim=pass (2048-bit key) header.d=nokia-bell-labs.com header.i=@nokia-bell-labs.com header.b=sGIRZEvo; arc=fail smtp.client-ip=52.101.66.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nokia-bell-labs.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nokia-bell-labs.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nokia-bell-labs.com header.i=@nokia-bell-labs.com header.b="sGIRZEvo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CzyAes8GSKaNX9TPS4q/MGJ1VyV8WKNQmoINft8UKKCkdsmGjYLVOxwxDydesAoXafL8zwZ0I8ZVMU9pIWLS14YfYSEQywGpyygx+DRMp7MLMOUsVsyqTPeP63297kPgySjB8iXP4lQunDwhVs0THgopS+kpohIBduRN+q1jPNiRreFOEZLngRHb+Xau47H4CR9lk0PF4DVsC+x7pj87Sud9EVqenB+BhEmFoKArU0bJ6W42f2CmcR9SQM8mKSf5xRMkBibdCMly3z976/0Cics82F/QbxYRFc1Tk048FatFJk3xZEwaRfjLnnzgz0zzbwPDloaacMQLAWDd8qMo3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sJB27rbc11VycrzEBQ9Uk33DwopAtQ88geMSqc5nTC8=; b=dVqW1ldGUt7GpJCwSpywvJzhZ/CB1N8dI6xWDWSrR+CwU+gTm6HZXQz2MQetd34RqVf+q5772GSPBTYmJyFYR+DNWVxXG/ARVmpZdprsDPhmWJvO6nXjetlwI96eXgbPgUBk3IduukuO2PA/HgGb9E6mmLwBmZREaU0ucnAjjoq1xS3fyHjVWmqcIQNxO8o1oBESda1c+dIFuaeq9OGEslLqcPRdGN5Tczhporz1AEzmosjU7QYAcNqKAeZBrVUtftDRmq2wP5nmZG5Ljv9N1K2cw+5N8kYnIRZ8VNBZ4WyPiRcviZnEbP3AqEv5sqSgK3VPA5AdR0xYXz8YP1WNSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 131.228.6.101) smtp.rcpttodomain=amazon.com smtp.mailfrom=nokia-bell-labs.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nokia-bell-labs.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia-bell-labs.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJB27rbc11VycrzEBQ9Uk33DwopAtQ88geMSqc5nTC8=; b=sGIRZEvoF6pPaVe7xiph3Xnnt6KsiGs0nGUxzLNtkd+UXsf+zJjXg/YTm1Nz6GwOdqGRdcEfVaaRRRWowqgSiRQRGifQ2Dhf2WFzr5k9evUHE/d9WXJRCRxJ4cFquvenOO3pmTVwuVyxtvUQYnjpeeErUDM14lmMQenK3WRBleQvniRRagHgWs8Txux2KFHlns3vr+I75vz8Ca7sJ5V6fW7Xu6aIY7TRTpDBUSCtfghgisl7TC+aV6GtG4O1Lbew2Q8Z8BPFfq2pyxsg0UkKDS6u8GtOMSmFdQKSMooEzJRaZZHVb8KpexWqa8/rjbJGGvItkFD4P/qvCXjcBcKwGw== Received: from DB8P191CA0016.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::26) by DBAPR07MB6520.eurprd07.prod.outlook.com (2603:10a6:10:178::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.26; Sat, 21 Jun 2025 19:38:08 +0000 Received: from DB5PEPF00014B98.eurprd02.prod.outlook.com (2603:10a6:10:130:cafe::a5) by DB8P191CA0016.outlook.office365.com (2603:10a6:10:130::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.27 via Frontend Transport; Sat, 21 Jun 2025 19:38:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 131.228.6.101) smtp.mailfrom=nokia-bell-labs.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nokia-bell-labs.com; Received-SPF: Pass (protection.outlook.com: domain of nokia-bell-labs.com designates 131.228.6.101 as permitted sender) receiver=protection.outlook.com; client-ip=131.228.6.101; helo=fr712usmtp1.zeu.alcatel-lucent.com; pr=C Received: from fr712usmtp1.zeu.alcatel-lucent.com (131.228.6.101) by DB5PEPF00014B98.mail.protection.outlook.com (10.167.8.165) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8880.14 via Frontend Transport; Sat, 21 Jun 2025 19:38:07 +0000 Received: from sarah.nbl.nsn-rdnet.net (sarah.nbl.nsn-rdnet.net [10.0.73.150]) by fr712usmtp1.zeu.alcatel-lucent.com (Postfix) with ESMTP id 5857B1C0031; Sat, 21 Jun 2025 22:38:06 +0300 (EEST) From: chia-yu.chang@nokia-bell-labs.com To: pabeni@redhat.com, edumazet@google.com, linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com Cc: Chia-Yu Chang Subject: [PATCH v9 net-next 13/15] tcp: accecn: AccECN ACE field multi-wrap heuristic Date: Sat, 21 Jun 2025 21:37:35 +0200 Message-Id: <20250621193737.16593-14-chia-yu.chang@nokia-bell-labs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250621193737.16593-1-chia-yu.chang@nokia-bell-labs.com> References: <20250621193737.16593-1-chia-yu.chang@nokia-bell-labs.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B98:EE_|DBAPR07MB6520:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c86b271-251d-4404-f161-08ddb0fb2629 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|36860700013|1800799024|376014|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?BRhAb9O41UZSjqFdzj6iCJKswzNEAYq?= =?utf-8?q?J+VLQSNLBKmtxoT9/+XkCLFHmZmkqK1+TQQ9X1Vg+3d8Q+Cwl/g3lSl9o6ddzD+zW?= =?utf-8?q?ND+3SWWsFwl7NUfsuussXU5fWqD5PKbYkJXU5Yy3JDXG0V7RH30fTB8NyX3Vr91Jj?= =?utf-8?q?LdI3XNwJcj/e7eMMHS+p4uLQnZpSaYSyv1Vhnul1hQua28KnGZby6m350ykvHczgL?= =?utf-8?q?pm1TtBkGkS7NN0hwq6lPAbFaUgwRwwpI3s45VPt3U85DNDdT71sBfF7F+sUYJgZgQ?= =?utf-8?q?CqzkojXkRIObzH6Cx7RRzdwUzQdkleWdMTPph519kVqb4N14PHorh1SLEsQeVcxVJ?= =?utf-8?q?dxwMsXj7fL5+nNNCNuSuVlbkRHkjbn2H1jFYz8Hf+tSlPy1a00U/xAhpXyuQnMmJ1?= =?utf-8?q?BLJO7mTNYOb8LeaXwWkal7IL41ML+/v4XQIPqP57Kni+F7BDPIAgNf8NvJy0ByKwf?= =?utf-8?q?k4O/LtpIajIPay4uXMdGQ2e9j1fJRn+6UZuj92CH11fp73RVIc/rnGN/cn5VxDQ2u?= =?utf-8?q?j6S1VhDBEADXPzm3T71iLU781ysY17vKEoEh3EUApxn4aLLfvQCqAkJ8diqTOUE4B?= =?utf-8?q?BxKWJHW/arKqZ+kF4ZwYhkcbdblRqPaOZ3c8+DJZHYvN5yD0UWFPPTIYTUICAPrW3?= =?utf-8?q?5AXHXKwGwRm1ac/z29NasgBbywWPWeGKMaC9F2lzP0uxNWl9FgwvV75kgDzNLu3xV?= =?utf-8?q?Tp0K8F338W0ReEk8vWKTobJHwaux7bhHhPAfojxongz5/2kjPGFwhJg9tsjQzgwkX?= =?utf-8?q?WyvPFehDkxpryzpYW7VoMNR9jLZH3KiEbXUrhxCUEghmuWOUW4Vg8yQiWi+PRJB69?= =?utf-8?q?jmF/3YXi1ZzC2Flsr6Su4Q0Xd5NaMGkfR1+qVQmx3A1PJXjtYMeYfVw66PqJW3AG4?= =?utf-8?q?CjuB8oX44Mv2ORFFiYzNbSCC9TicYjSzhZ+fJ/6xJfxq8ChobbJGG3JKger9WRR6H?= =?utf-8?q?MNTs6EG+8gW6Uqt9tRiEKC5cKeqqLHwLVLlQUV05i3OCxcoy7ICcGNJ2+rwWcdsB9?= =?utf-8?q?d450LmJ4cK4k8cndeV8JMxHv6OBXQzsxf56/GAmkf25j4IYtH3gXj/oMTTngk/z+5?= =?utf-8?q?WcSIVWRTdIcaLzm9fta/VW5TzANJxgkFLNJlxunK21rlCV3+SJQRlj/2fpomIWa8w?= =?utf-8?q?xz9H2RWmCdao3CxBHO9zSh7ga5GZpB5zjC6vW3a6Gyjeijirk3o3DR0FuFc0W0jU2?= =?utf-8?q?tHd32vMsc3IqkKFeCJqsXh7TwU0O5UDFZbBtCEzgjWpdRDqsy9FOX/Ci9lkUMht3S?= =?utf-8?q?xYJyc+BFmBXjglB/CeOwhoowUOa3sTnNXQ0/59EYu+ftgwvTWaCUccXnXchHzhLjY?= =?utf-8?q?BxHmH+H9BMv/O1KJTuJYOj8CYVvUcYWjvskhqjWZhBzM3S547FGG09xgd86fdlVY5?= =?utf-8?q?ZvA3Z/FwlYn36YFxailV9++GkEywYviTYIsYm6n/kVBMUh7g1aIN7VN97rLcm91Lp?= =?utf-8?q?FQBQfx0EynsKunKRXT6wIh/JeyFECaUA=3D=3D?= X-Forefront-Antispam-Report: CIP:131.228.6.101; CTRY:FI; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:fr712usmtp1.zeu.alcatel-lucent.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(7416014)(36860700013)(1800799024)(376014)(82310400026)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: nokia-bell-labs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2025 19:38:07.9244 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c86b271-251d-4404-f161-08ddb0fb2629 X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0; Ip=[131.228.6.101]; Helo=[fr712usmtp1.zeu.alcatel-lucent.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B98.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR07MB6520 From: Ilpo Järvinen Armed with ceb delta from option, delivered bytes, and delivered packets it is possible to estimate how many times ACE field wrapped. This calculation is necessary only if more than one wrap is possible. Without SACK, delivered bytes and packets are not always trustworthy in which case TCP falls back to the simpler no-or-all wraps ceb algorithm. Signed-off-by: Ilpo Järvinen Signed-off-by: Chia-Yu Chang --- net/ipv4/tcp_input.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 3f8cac22efda..97b5fe52d8fd 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -758,6 +758,24 @@ static u32 __tcp_accecn_process(struct sock *sk, const struct sk_buff *skb, d_ceb = tp->delivered_ecn_bytes[INET_ECN_CE - 1] - old_ceb; if (!d_ceb) return delta; + + if ((delivered_pkts >= (TCP_ACCECN_CEP_ACE_MASK + 1) * 2) && + (tcp_is_sack(tp) || + ((1 << inet_csk(sk)->icsk_ca_state) & + (TCPF_CA_Open | TCPF_CA_CWR)))) { + u32 est_d_cep; + + if (delivered_bytes <= d_ceb) + return safe_delta; + + est_d_cep = DIV_ROUND_UP_ULL((u64)d_ceb * + delivered_pkts, + delivered_bytes); + return min(safe_delta, + delta + + (est_d_cep & ~TCP_ACCECN_CEP_ACE_MASK)); + } + if (d_ceb > delta * tp->mss_cache) return safe_delta; if (d_ceb <