| Message ID | 1600865452-19649-1-git-send-email-gene.chen.richtek@gmail.com |
|---|---|
| Headers | show |
| Series | leds: mt6360: Add LED driver for MT6360 | expand |
On Wed, Sep 23, 2020 at 08:50:51PM +0800, Gene Chen wrote: > From: Gene Chen <gene_chen@richtek.com> > > Add bindings document for LED support on MT6360 PMIC > > Signed-off-by: Gene Chen <gene_chen@richtek.com> > --- > .../devicetree/bindings/leds/leds-mt6360.yaml | 107 +++++++++++++++++++++ > 1 file changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > new file mode 100644 > index 0000000..a356a1f > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LED driver for MT6360 PMIC from MediaTek Integrated. Where's the PMIC schema? This file needs to be referenced from it and that means it all needs to be one series. > + > +maintainers: > + - Gene Chen <gene_chen@richtek.com> > + > +description: | > + This module is part of the MT6360 MFD device. > + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, > + and 4-channel RGB LED support Register/Flash/Breath Mode > + > +properties: > + compatible: > + const: mediatek,mt6360-led > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^led@[0-5]$": > + type: object > + $ref: common.yaml# > + description: > + Properties for a single LED. > + > + properties: > + reg: > + description: Index of the LED. > + enum: > + - 0 # LED output INDICATOR1 > + - 1 # LED output INDICATOR2 > + - 2 # LED output INDICATOR3 > + - 3 # LED output INDICATOR4 > + - 4 # LED output FLED1 > + - 5 # LED output FLED2 > + > +unevaluatedProperties: false > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/leds/common.h> > + led-controller { > + compatible = "mediatek,mt6360-led"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + function = LED_FUNCTION_INDICATOR; > + color = <LED_COLOR_ID_RED>; > + default-state = "off"; > + }; > + led@1 { > + reg = <1>; > + function = LED_FUNCTION_INDICATOR; > + color = <LED_COLOR_ID_GREEN>; > + default-state = "off"; > + }; > + led@2 { > + reg = <2>; > + function = LED_FUNCTION_INDICATOR; > + color = <LED_COLOR_ID_BLUE>; > + default-state = "off"; > + }; > + led@3 { > + reg = <3>; > + function = LED_FUNCTION_INDICATOR; > + color = <LED_COLOR_ID_AMBER>; > + default-state = "off"; > + }; > + led@4 { > + reg = <4>; > + function = LED_FUNCTION_FLASH; > + color = <LED_COLOR_ID_WHITE>; > + function-enumerator = <1>; > + default-state = "off"; > + led-max-microamp = <200000>; > + flash-max-microamp = <500000>; > + flash-max-timeout-us = <1024000>; > + }; > + led@5 { > + reg = <5>; > + function = LED_FUNCTION_FLASH; > + color = <LED_COLOR_ID_WHITE>; > + function-enumerator = <2>; > + default-state = "off"; > + led-max-microamp = <200000>; > + flash-max-microamp = <500000>; > + flash-max-timeout-us = <1024000>; > + }; > + }; > +... > -- > 2.7.4 >
Rob Herring <robh@kernel.org> 於 2020年9月29日 週二 上午2:44寫道： > > On Wed, Sep 23, 2020 at 08:50:51PM +0800, Gene Chen wrote: > > From: Gene Chen <gene_chen@richtek.com> > > > > Add bindings document for LED support on MT6360 PMIC > > > > Signed-off-by: Gene Chen <gene_chen@richtek.com> > > --- > > .../devicetree/bindings/leds/leds-mt6360.yaml | 107 +++++++++++++++++++++ > > 1 file changed, 107 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > new file mode 100644 > > index 0000000..a356a1f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > @@ -0,0 +1,107 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LED driver for MT6360 PMIC from MediaTek Integrated. > > Where's the PMIC schema? This file needs to be referenced from it and > that means it all needs to be one series. > Do you means as regulator/max77650-regulator.yaml? description: | This module is part of the MAX77650 MFD device. For more details "see Documentation/devicetree/bindings/mfd/max77650.yaml" > > + > > +maintainers: > > + - Gene Chen <gene_chen@richtek.com> > > + > > +description: | > > + This module is part of the MT6360 MFD device. > > + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, > > + and 4-channel RGB LED support Register/Flash/Breath Mode > > + > > +properties: > > + compatible: > > + const: mediatek,mt6360-led > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > +patternProperties: > > + "^led@[0-5]$": > > + type: object > > + $ref: common.yaml# > > + description: > > + Properties for a single LED. > > + > > + properties: > > + reg: > > + description: Index of the LED. > > + enum: > > + - 0 # LED output INDICATOR1 > > + - 1 # LED output INDICATOR2 > > + - 2 # LED output INDICATOR3 > > + - 3 # LED output INDICATOR4 > > + - 4 # LED output FLED1 > > + - 5 # LED output FLED2 > > + > > +unevaluatedProperties: false > > + > > +required: > > + - compatible > > + - "#address-cells" > > + - "#size-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/leds/common.h> > > + led-controller { > > + compatible = "mediatek,mt6360-led"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + led@0 { > > + reg = <0>; > > + function = LED_FUNCTION_INDICATOR; > > + color = <LED_COLOR_ID_RED>; > > + default-state = "off"; > > + }; > > + led@1 { > > + reg = <1>; > > + function = LED_FUNCTION_INDICATOR; > > + color = <LED_COLOR_ID_GREEN>; > > + default-state = "off"; > > + }; > > + led@2 { > > + reg = <2>; > > + function = LED_FUNCTION_INDICATOR; > > + color = <LED_COLOR_ID_BLUE>; > > + default-state = "off"; > > + }; > > + led@3 { > > + reg = <3>; > > + function = LED_FUNCTION_INDICATOR; > > + color = <LED_COLOR_ID_AMBER>; > > + default-state = "off"; > > + }; > > + led@4 { > > + reg = <4>; > > + function = LED_FUNCTION_FLASH; > > + color = <LED_COLOR_ID_WHITE>; > > + function-enumerator = <1>; > > + default-state = "off"; > > + led-max-microamp = <200000>; > > + flash-max-microamp = <500000>; > > + flash-max-timeout-us = <1024000>; > > + }; > > + led@5 { > > + reg = <5>; > > + function = LED_FUNCTION_FLASH; > > + color = <LED_COLOR_ID_WHITE>; > > + function-enumerator = <2>; > > + default-state = "off"; > > + led-max-microamp = <200000>; > > + flash-max-microamp = <500000>; > > + flash-max-timeout-us = <1024000>; > > + }; > > + }; > > +... > > -- > > 2.7.4 > >
Gene Chen <gene.chen.richtek@gmail.com> 於 2020年9月30日 週三 下午11:17寫道： > > Rob Herring <robh@kernel.org> 於 2020年9月29日 週二 上午2:44寫道： > > > > On Wed, Sep 23, 2020 at 08:50:51PM +0800, Gene Chen wrote: > > > From: Gene Chen <gene_chen@richtek.com> > > > > > > Add bindings document for LED support on MT6360 PMIC > > > > > > Signed-off-by: Gene Chen <gene_chen@richtek.com> > > > --- > > > .../devicetree/bindings/leds/leds-mt6360.yaml | 107 +++++++++++++++++++++ > > > 1 file changed, 107 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > > new file mode 100644 > > > index 0000000..a356a1f > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml > > > @@ -0,0 +1,107 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: LED driver for MT6360 PMIC from MediaTek Integrated. > > > > Where's the PMIC schema? This file needs to be referenced from it and > > that means it all needs to be one series. > > > > Do you means as regulator/max77650-regulator.yaml? > > description: | > This module is part of the MAX77650 MFD device. For more details > "see Documentation/devicetree/bindings/mfd/max77650.yaml" > According to jacek suggestion, I merge fled0~2 to one RGB multicolor device as below, led@0 { reg = <0>; function = LED_FUNCTION_INDICATOR; color = <LED_COLOR_ID_RGB>; led-max-microamp = <24000>; }; But I see make dt_binding_check error, /media/gene_chen/WD/upstream/linux/Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml: led-controller: led@0:color:0:0: 9 is greater than the maximum of 8 Maybe the maximum color need set from 8 to 9, which define LED_COLOR_ID_RGB in include/dt-bindings/leds/common.h color: description: Color of the LED. Use one of the LED_COLOR_ID_* prefixed definitions from the header include/dt-bindings/leds/common.h. If there is no matching LED_COLOR_ID available, add a new one. $ref: /schemas/types.yaml#definitions/uint32 minimum: 0 maximum: 9 > > > + > > > +maintainers: > > > + - Gene Chen <gene_chen@richtek.com> > > > + > > > +description: | > > > + This module is part of the MT6360 MFD device. > > > + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, > > > + and 4-channel RGB LED support Register/Flash/Breath Mode > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,mt6360-led > > > + > > > + "#address-cells": > > > + const: 1 > > > + > > > + "#size-cells": > > > + const: 0 > > > + > > > +patternProperties: > > > + "^led@[0-5]$": > > > + type: object > > > + $ref: common.yaml# > > > + description: > > > + Properties for a single LED. > > > + > > > + properties: > > > + reg: > > > + description: Index of the LED. > > > + enum: > > > + - 0 # LED output INDICATOR1 > > > + - 1 # LED output INDICATOR2 > > > + - 2 # LED output INDICATOR3 > > > + - 3 # LED output INDICATOR4 > > > + - 4 # LED output FLED1 > > > + - 5 # LED output FLED2 > > > + > > > +unevaluatedProperties: false > > > + > > > +required: > > > + - compatible > > > + - "#address-cells" > > > + - "#size-cells" > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + #include <dt-bindings/leds/common.h> > > > + led-controller { > > > + compatible = "mediatek,mt6360-led"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + led@0 { > > > + reg = <0>; > > > + function = LED_FUNCTION_INDICATOR; > > > + color = <LED_COLOR_ID_RED>; > > > + default-state = "off"; > > > + }; > > > + led@1 { > > > + reg = <1>; > > > + function = LED_FUNCTION_INDICATOR; > > > + color = <LED_COLOR_ID_GREEN>; > > > + default-state = "off"; > > > + }; > > > + led@2 { > > > + reg = <2>; > > > + function = LED_FUNCTION_INDICATOR; > > > + color = <LED_COLOR_ID_BLUE>; > > > + default-state = "off"; > > > + }; > > > + led@3 { > > > + reg = <3>; > > > + function = LED_FUNCTION_INDICATOR; > > > + color = <LED_COLOR_ID_AMBER>; > > > + default-state = "off"; > > > + }; > > > + led@4 { > > > + reg = <4>; > > > + function = LED_FUNCTION_FLASH; > > > + color = <LED_COLOR_ID_WHITE>; > > > + function-enumerator = <1>; > > > + default-state = "off"; > > > + led-max-microamp = <200000>; > > > + flash-max-microamp = <500000>; > > > + flash-max-timeout-us = <1024000>; > > > + }; > > > + led@5 { > > > + reg = <5>; > > > + function = LED_FUNCTION_FLASH; > > > + color = <LED_COLOR_ID_WHITE>; > > > + function-enumerator = <2>; > > > + default-state = "off"; > > > + led-max-microamp = <200000>; > > > + flash-max-microamp = <500000>; > > > + flash-max-timeout-us = <1024000>; > > > + }; > > > + }; > > > +... > > > -- > > > 2.7.4 > > >