mbox series

[0/2] Add Turris Omnia LEDs driver

Message ID 20200421171732.8277-1-marek.behun@nic.cz
Headers show
Series Add Turris Omnia LEDs driver | expand

Message

Marek Behún April 21, 2020, 5:17 p.m. UTC 
Hi,

this adds support for the Turris Omnia front panel RGB LEDs.
The patches should apply on Pavel's for-next branch.

Changes since RFC:
- added device-tree bindings documentation
- the reg property is abandoned, as discussed previously on mailing
  list, since it can be deduced from led-sources
- setting devicename is dropped

After a call with Pavel I decided that it would be good to first merge
this driver in this state, and then work on improving it, eg:
- adding support for changing global brightness via sysfs file as
  discussed previously
- adding support for proper device name (the first part of the sysfs
  name for the LED classdev). The best way to connect a LED to a device
  (for example a network interface) is via a phandle in device tree
  (utilizing trigger-sources, for example). This could be implemented
  as a LED subsystem library function and then used by drivers

Marek

Marek Behún (2):
  dt-bindings: leds: add cznic,turris-omnia-leds binding
  leds: initial support for Turris Omnia LEDs

 .../leds/cznic,turris-omnia-leds.yaml         | 113 +++++++
 MAINTAINERS                                   |   6 +-
 drivers/leds/Kconfig                          |  11 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/leds-turris-omnia.c              | 285 ++++++++++++++++++
 5 files changed, 414 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
 create mode 100644 drivers/leds/leds-turris-omnia.c