| Message ID | 20231101142445.8753-1-ddrokosov@salutedevices.com |
|---|---|
| Headers | show |
| Series | leds: aw200xx: several driver updates | expand |
On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote: > AW200XX controllers have the capability to declare more than 0xf LEDs, > therefore, it is necessary to accept LED names using an appropriate > regex pattern. > > The register offsets can be adjusted within the specified range, with > the maximum value corresponding to the highest number of LEDs that can > be connected to the controller. > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++-- > 1 file changed, 58 insertions(+), 6 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected) from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected) from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected) from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231101142445.8753-12-ddrokosov@salutedevices.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Nov 01, 2023 at 11:04:16AM -0500, Rob Herring wrote: > > On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote: > > AW200XX controllers have the capability to declare more than 0xf LEDs, > > therefore, it is necessary to accept LED names using an appropriate > > regex pattern. > > > > The register offsets can be adjusted within the specified range, with > > the maximum value corresponding to the highest number of LEDs that can > > be connected to the controller. > > > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > --- > > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++-- > > 1 file changed, 58 insertions(+), 6 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected) > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected) > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected) > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# Looks like you need to drop the second part of this hunk from the patch. @@ -45,17 +45,12 @@ properties: maxItems: 1 patternProperties: - "^led@[0-9a-f]$": + "^led@[0-9a-f]+$": type: object $ref: common.yaml# unevaluatedProperties: false properties: - reg: - description: - LED number - maxItems: 1 - led-max-microamp: default: 9780 description: | Each LED still only has one reg entry, right? Cheers, Conor.
Hello Conor, On Wed, Nov 01, 2023 at 04:17:14PM +0000, Conor Dooley wrote: > On Wed, Nov 01, 2023 at 11:04:16AM -0500, Rob Herring wrote: > > > > On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote: > > > AW200XX controllers have the capability to declare more than 0xf LEDs, > > > therefore, it is necessary to accept LED names using an appropriate > > > regex pattern. > > > > > > The register offsets can be adjusted within the specified range, with > > > the maximum value corresponding to the highest number of LEDs that can > > > be connected to the controller. > > > > > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > --- > > > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++-- > > > 1 file changed, 58 insertions(+), 6 deletions(-) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected) > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected) > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected) > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > Looks like you need to drop the second part of this hunk from the patch. > @@ -45,17 +45,12 @@ properties: > maxItems: 1 > > patternProperties: > - "^led@[0-9a-f]$": > + "^led@[0-9a-f]+$": > type: object > $ref: common.yaml# > unevaluatedProperties: false > > properties: > - reg: > - description: > - LED number > - maxItems: 1 > - > led-max-microamp: > default: 9780 > description: | > > Each LED still only has one reg entry, right? You're right... the maxItems for 'reg' is still needed. I'll back it in the next version. But I don't understand, why my dt_binding_check run doesn't show me this problem... I don't specify DT_CHECKER_FLAGS, maybe this is a root cause.
On Wed, Nov 01, 2023 at 08:44:22PM +0300, Dmitry Rokosov wrote: > Hello Conor, > > On Wed, Nov 01, 2023 at 04:17:14PM +0000, Conor Dooley wrote: > > On Wed, Nov 01, 2023 at 11:04:16AM -0500, Rob Herring wrote: > > > > > > On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote: > > > > AW200XX controllers have the capability to declare more than 0xf LEDs, > > > > therefore, it is necessary to accept LED names using an appropriate > > > > regex pattern. > > > > > > > > The register offsets can be adjusted within the specified range, with > > > > the maximum value corresponding to the highest number of LEDs that can > > > > be connected to the controller. > > > > > > > > Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx") > > > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > > --- > > > > .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++-- > > > > 1 file changed, 58 insertions(+), 6 deletions(-) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected) > > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected) > > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected) > > > from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml# > > > > Looks like you need to drop the second part of this hunk from the patch. > > @@ -45,17 +45,12 @@ properties: > > maxItems: 1 > > > > patternProperties: > > - "^led@[0-9a-f]$": > > + "^led@[0-9a-f]+$": > > type: object > > $ref: common.yaml# > > unevaluatedProperties: false > > > > properties: > > - reg: > > - description: > > - LED number > > - maxItems: 1 > > - > > led-max-microamp: > > default: 9780 > > description: | > > > > Each LED still only has one reg entry, right? > > You're right... the maxItems for 'reg' is still needed. I'll back it in > the next version. > But I don't understand, why my dt_binding_check run doesn't show me this > problem... I don't specify DT_CHECKER_FLAGS, maybe this is a root cause. I dunno! I do `make dt_binding_check W=1 DT_SCHEMA_FILES="$filename"` to test stuff. Also, you can keep the tag.
On Wed, Nov 1, 2023 at 4:24 PM Dmitry Rokosov <ddrokosov@salutedevices.com> wrote: > > The following patch series includes several updates for the AW200XX LED > driver: > - some small fixes and optimizations to the driver implementation: > delays, autodimming calculation, disable_locking regmap flag, > display_rows calculation in runtime; > - fix LED device tree node pattern to accept LED names counting not > only from 0 to f; > - add missing reg constraints; > - support HWEN hardware control, which allows enabling or disabling > AW200XX RTL logic from the main SoC using a GPIO pin; > - introduce the new AW20108 LED controller, the datasheet for this > controller can be found at [1]. For non device tree binding patches Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> One nit I commented on the individual patch.
The following patch series includes several updates for the AW200XX LED driver: - some small fixes and optimizations to the driver implementation: delays, autodimming calculation, disable_locking regmap flag, display_rows calculation in runtime; - fix LED device tree node pattern to accept LED names counting not only from 0 to f; - add missing reg constraints; - support HWEN hardware control, which allows enabling or disabling AW200XX RTL logic from the main SoC using a GPIO pin; - introduce the new AW20108 LED controller, the datasheet for this controller can be found at [1]. Changes v3 since v2 at [3]: - handle all cases during hwen gpio get routine execution - rename 'hwen-gpios' to standard 'enable-gpios' - properly handle aw200xx_probe_get_display_rows() ret values - fix timestamp format in the comments and commit messages - expand LEDS_AW200XX config and dt-bindings description - describe reg constraints for all compatible variants - add Conor's Acked-by tag Changes v2 since v1 at [2]: - rebase on the latest aw200xx changes from lee/leds git repo - some commit messages rewording - replace legacy gpio_* API with gpiod_* and devm_gpiod_* API - rename dt property awinic,hwen-gpio to hwen-gpios according to gpiod API - use fsleep() instead of usleep_range() per Andy's suggestion - add max_brightness parameter to led cdev to restrict set_brightness() overflow - provide reg constraints as Rob suggested - move hwen-gpios to proper dt node in the bindings example Links: [1] https://doc.awinic.com/doc/20230609wm/8a9a9ac8-1d8f-4e75-bf7a-67a04465c153.pdf [2] https://lore.kernel.org/all/20231006160437.15627-1-ddrokosov@salutedevices.com/ [3] https://lore.kernel.org/all/20231018182943.18700-1-ddrokosov@salutedevices.com/ Dmitry Rokosov (3): leds: aw200xx: support HWEN hardware control dt-bindings: leds: aw200xx: introduce optional enable-gpios property dt-bindings: leds: aw200xx: fix led pattern and add reg constraints George Stark (7): leds: aw200xx: calculate dts property display_rows in the driver dt-bindings: leds: aw200xx: remove property "awinic,display-rows" leds: aw200xx: add delay after software reset leds: aw200xx: enable disable_locking flag in regmap config leds: aw200xx: improve autodim calculation method leds: aw200xx: add support for aw20108 device dt-bindings: leds: awinic,aw200xx: add AW20108 device Martin Kurbanov (1): leds: aw200xx: fix write to DIM parameter .../bindings/leds/awinic,aw200xx.yaml | 100 +++++++++++++----- drivers/leds/Kconfig | 14 ++- drivers/leds/leds-aw200xx.c | 96 ++++++++++++++--- 3 files changed, 159 insertions(+), 51 deletions(-)