| Message ID | 20240505164549.65644-1-linux@fw-web.de |
|---|---|
| Headers | show |
| Series | Add Bananapi R3 Mini | expand |
On 05/05/2024 18:45, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add missing properties already used in mt7986a.dtsi. Missing for what? Or why? Provide context, IOW, explain why they are missing. Best regards, Krzysztof
On 05/05/2024 18:45, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add missing binding for property used in mt7986a.dtsi. > Again, no, it is not missing, if the device is not reset controller. Provide explanation why this is suitable in the binding. IOW, why DTS is right, but binding is wrong. Best regards, Krzysztof
Il 05/05/24 18:45, Frank Wunderlich ha scritto: > From: Frank Wunderlich <frank-w@public-files.de> > > Add missing properties already used in mt7986a.dtsi. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Fixes tag? :-) Cheers, Angelo
Am 6. Mai 2024 14:48:58 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>: >Il 05/05/24 18:45, Frank Wunderlich ha scritto: >> From: Frank Wunderlich <frank-w@public-files.de> >> >> Add missing properties already used in mt7986a.dtsi. >> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > >Fixes tag? :-) > >Cheers, >Angelo Should i use fixes tag of binding commit or where dts (-part) was added? regards Frank
> Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > On 05/05/2024 18:45, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > Add missing properties already used in mt7986a.dtsi. > > Missing for what? Or why? Provide context, IOW, explain why they are > missing. ethernet-node in mt7986a.dtsi hast reset-cells-property https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L559 and address-cells and size-cells are used here: https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L495 i saw the warnings while checking my r3mini dts... arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: syscon@15000000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/clock/mediatek,ethsys.yaml# arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: ethernet@15100000: Unevaluated properties are not allowed ('#reset-cells' was unexpected) from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml# so i thought it is a good idea to fix this now ;) but basicly not related to my dts as these are inherited, so i can drop binding-changes... regards Frank > Best regards, > Krzysztof
On Sun, 05 May 2024 18:45:44 +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add mt7986 based BananaPi R3 Mini SBC and fix some related binding errors. > > Frank Wunderlich (5): > dt-bindings: leds: add led trigger netdev > dt-bindings: clock: mediatek: add address-cells and size-cells to > ethsys > dt-bindings: net: mediatek,net: add reset-cells > dt-bindings: arm64: dts: mediatek: add BananaPi R3 Mini > arm64: dts: mediatek: Add mt7986 based Bananapi R3 Mini > > .../devicetree/bindings/arm/mediatek.yaml | 1 + > .../bindings/clock/mediatek,ethsys.yaml | 6 + > .../devicetree/bindings/leds/common.yaml | 2 + > .../devicetree/bindings/net/mediatek,net.yaml | 3 + > arch/arm64/boot/dts/mediatek/Makefile | 1 + > .../mediatek/mt7986a-bananapi-bpi-r3-mini.dts | 486 ++++++++++++++++++ > 6 files changed, 499 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dts > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt7986a-bananapi-bpi-r3-mini.dtb' for 20240505164549.65644-1-linux@fw-web.de: arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: crypto@10320000: interrupts: [[0, 116, 4], [0, 117, 4], [0, 118, 4], [0, 119, 4]] is too short from schema $id: http://devicetree.org/schemas/crypto/inside-secure,safexcel.yaml# arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: crypto@10320000: interrupt-names: ['ring0', 'ring1', 'ring2', 'ring3'] is too short from schema $id: http://devicetree.org/schemas/crypto/inside-secure,safexcel.yaml#
Il 06/05/24 18:01, Frank Wunderlich ha scritto: > Am 6. Mai 2024 14:48:58 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>: >> Il 05/05/24 18:45, Frank Wunderlich ha scritto: >>> From: Frank Wunderlich <frank-w@public-files.de> >>> >>> Add missing properties already used in mt7986a.dtsi. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >> >> Fixes tag? :-) >> >> Cheers, >> Angelo > > Should i use fixes tag of binding commit or where dts (-part) was added? > regards Frank You're fixing the binding, so, the binding one :-) Cheers, Angelo
On Mon, May 06, 2024 at 06:51:43PM +0200, Frank Wunderlich wrote: > > Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr > > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > > On 05/05/2024 18:45, Frank Wunderlich wrote: > > > From: Frank Wunderlich <frank-w@public-files.de> > > > > > > Add missing properties already used in mt7986a.dtsi. > > > > Missing for what? Or why? Provide context, IOW, explain why they are > > missing. > > ethernet-node in mt7986a.dtsi hast reset-cells-property > > https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L559 > > and > > address-cells and size-cells are used here: > > https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L495 > > i saw the warnings while checking my r3mini dts... > > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: syscon@15000000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/clock/mediatek,ethsys.yaml# > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: ethernet@15100000: Unevaluated properties are not allowed ('#reset-cells' was unexpected) > from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml# > > so i thought it is a good idea to fix this now ;) The dts is already fixed dropping these properties in linux-next. If you don't have child nodes with reg/ranges, then you never need #address-cells or #size-cells. Rob
On Sun, May 05, 2024 at 06:45:47PM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add missing binding for property used in mt7986a.dtsi. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > Documentation/devicetree/bindings/net/mediatek,net.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml > index e74502a0afe8..5214927c0fe8 100644 > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml > @@ -101,6 +101,9 @@ properties: > "#address-cells": > const: 1 > > + "#reset-cells": > + const: 1 Also fixed already. Rob
Hi > Gesendet: Dienstag, 07. Mai 2024 um 21:35 Uhr > Von: "Rob Herring" <robh@kernel.org> > The dts is already fixed dropping these properties in linux-next. > > If you don't have child nodes with reg/ranges, then you never need > #address-cells or #size-cells. thx for pointing to this, so i only need part 4+5 when 6.10-rc1 is out (as i drop netdev trigger from dts in v2). any comments for these? regards Frank
From: Frank Wunderlich <frank-w@public-files.de> Add mt7986 based BananaPi R3 Mini SBC and fix some related binding errors. Frank Wunderlich (5): dt-bindings: leds: add led trigger netdev dt-bindings: clock: mediatek: add address-cells and size-cells to ethsys dt-bindings: net: mediatek,net: add reset-cells dt-bindings: arm64: dts: mediatek: add BananaPi R3 Mini arm64: dts: mediatek: Add mt7986 based Bananapi R3 Mini .../devicetree/bindings/arm/mediatek.yaml | 1 + .../bindings/clock/mediatek,ethsys.yaml | 6 + .../devicetree/bindings/leds/common.yaml | 2 + .../devicetree/bindings/net/mediatek,net.yaml | 3 + arch/arm64/boot/dts/mediatek/Makefile | 1 + .../mediatek/mt7986a-bananapi-bpi-r3-mini.dts | 486 ++++++++++++++++++ 6 files changed, 499 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dts