mbox series

[v4,0/2] leds: leds-pca995x: Add support for NXP PCA9956B

Message ID 20240711-pca995x-v4-0-702a67148065@gmail.com
Headers show
Series leds: leds-pca995x: Add support for NXP PCA9956B | expand

Message

Pieterjan Camerlynck via B4 Relay July 11, 2024, 12:49 p.m. UTC
This series adds support for NXP PCA9956B to the pca995x driver. This
chip is similar to the others but has 24 instead of 16 outputs and a
slightly different register layout. Datasheet available at [1].

[1]: https://www.nxp.com/docs/en/data-sheet/PCA9956B.pdf

Signed-off-by: Pieterjan Camerlynck <pieterjanca@gmail.com>
---
Changes in v4:
- replace btype with chipdef in-place
- Link to v3: https://lore.kernel.org/r/20240711-pca995x-v3-0-a1bf1f3c3f5a@gmail.com

Changes in v3:
- restore PCA995X_MAX_OUTPUTS and increase to 24
- restore secondary for loop in pca995x_probe()
- remove parenthesis around (chipdef->pwm_base)
- Link to v2: https://lore.kernel.org/r/20240710-pca995x-v2-0-8fafb6e4b7d5@gmail.com

Thank you for the review Marek Vasut.

Changes in v2:
- define seperate const struct pca995x_chipdef for each chip
- remove chip enum
- Link to v1: https://lore.kernel.org/r/20240710-pca995x-v1-0-545015603000@gmail.com

---
Pieterjan Camerlynck (2):
      dt-bindings: leds: pca995x: Add new nxp,pca9956b compatible
      leds: leds-pca995x: Add support for NXP PCA9956B

 .../devicetree/bindings/leds/nxp,pca995x.yaml      |  6 ++-
 drivers/leds/leds-pca995x.c                        | 59 ++++++++++++++--------
 2 files changed, 43 insertions(+), 22 deletions(-)
---
base-commit: 82d01fe6ee52086035b201cfa1410a3b04384257
change-id: 20240709-pca995x-d7c5f97f6ebc

Best regards,

Comments

Lee Jones July 25, 2024, 10:04 a.m. UTC | #1
On Thu, 11 Jul 2024 14:49:49 +0200, Pieterjan Camerlynck wrote:
> This series adds support for NXP PCA9956B to the pca995x driver. This
> chip is similar to the others but has 24 instead of 16 outputs and a
> slightly different register layout. Datasheet available at [1].
> 
> [1]: https://www.nxp.com/docs/en/data-sheet/PCA9956B.pdf
> 
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: leds: pca995x: Add new nxp,pca9956b compatible
      commit: 249eef903047c9861823072a918fce7d2b8a94b6
[2/2] leds: leds-pca995x: Add support for NXP PCA9956B
      commit: 3981b88ec586125d323cacd6734211071ca43f36

--
Lee Jones [李琼斯]