| Message ID | 20241101154844.1175860-1-gnstark@salutedevices.com |
|---|---|
| Headers | show |
| Series | leds: pwm: Add default-brightness property | expand |
On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote: > Optional default-brightness property specifies brightness value to be > used if default LED state is on. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > --- > Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
Hello Krzysztof, Rob Thanks for noticing it, missed the tag not by purpose, sorry about it. Sure I'll add the tag to v3 if v3 happens. On 11/2/24 16:06, Krzysztof Kozlowski wrote: > On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote: >> Optional default-brightness property specifies brightness value to be >> used if default LED state is on. >> >> Signed-off-by: George Stark <gnstark@salutedevices.com> >> --- >> Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: Please add > Acked-by/Reviewed-by/Tested-by tags when posting new versions, under > or above your Signed-off-by tag. Tag is "received", when provided > in a message replied to you on the mailing list. Tools like b4 can help > here. However, there's no need to repost patches *only* to add the tags. > The upstream maintainer will do that for tags received on the version > they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof >
On Sun, 03 Nov 2024, George Stark wrote: > Hello Krzysztof, Rob > > Thanks for noticing it, missed the tag not by purpose, sorry about it. > Sure I'll add the tag to v3 if v3 happens. Please reply directly under the text you're referring to. Top-posting is not allowed. Please submit a v2 [RESEND] complete with the missing tags. > On 11/2/24 16:06, Krzysztof Kozlowski wrote: > > On Fri, Nov 01, 2024 at 06:48:43PM +0300, George Stark wrote: > > > Optional default-brightness property specifies brightness value to be > > > used if default LED state is on. > > > > > > Signed-off-by: George Stark <gnstark@salutedevices.com> > > > --- > > > Documentation/devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > > <form letter> > > This is a friendly reminder during the review process. > > > > It looks like you received a tag and forgot to add it. > > > > If you do not know the process, here is a short explanation: Please add > > Acked-by/Reviewed-by/Tested-by tags when posting new versions, under > > or above your Signed-off-by tag. Tag is "received", when provided > > in a message replied to you on the mailing list. Tools like b4 can help > > here. However, there's no need to repost patches *only* to add the tags. > > The upstream maintainer will do that for tags received on the version > > they apply. > > > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > > > If a tag was not added on purpose, please state why and what changed. > > </form letter> > > > > Best regards, > > Krzysztof > > > > -- > Best regards > George
led-pwm driver supports default-state DT property and if that state is on then the driver during initialization turns on the LED setting maximum brightness. Sometimes it's desirable to use lower initial brightness. This patch series adds support for DT property default-brightness. Things to discuss: If such a property is acceptable it could be moved to leds/common.yaml due to several drivers support multiple brightness levels and could support the property too. Changes in v2: leds: pwm: Add optional DT property default-brightness - refactor patch to make it more accurate link to v1: [1] [1] https://lore.kernel.org/lkml/20241015151410.2158102-3-gnstark@salutedevices.com/T/ George Stark (2): dt-bindings: leds: pwm: Add default-brightness property leds: pwm: Add optional DT property default-brightness .../devicetree/bindings/leds/leds-pwm.yaml | 6 ++++++ drivers/leds/leds-pwm.c | 17 ++++++++++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) -- 2.25.1