From patchwork Tue Oct 1 14:56:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 174883 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp8664251ill; Tue, 1 Oct 2019 07:56:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwks7eds1sv6kMoFDzSE+XXqqAsFwmT1ZgCDF5L4zS1K3yYLPXOq22D+6+XmmDaNpFS600q X-Received: by 2002:aa7:c5c2:: with SMTP id h2mr26470723eds.260.1569941805501; Tue, 01 Oct 2019 07:56:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569941805; cv=none; d=google.com; s=arc-20160816; b=tWHzqSloQblxO3EPDMpCLlryRdCpgmHpmct+0ULN+deTMFBai2VkYww91pZcv2kBxj 7tCPabXZOYOfcC2EpR142P6JLnXN9NnfZpDqjre2xTVFuB8qShlCqsVzqfpn0dXj1h9Q 3bWapeMewMVtokvRl2pQpSjdWthEOgVL5hwX9hNt7/SE/K7iGtRaOi1Lid8Og4RkGQnF KOPGQt8+ymChGXVfzcPvdKhJd0/fgt5ZsnWzJa7LAOgSbSB1ZY/GaAJOR4IfRN99ygLz h0rvHoI/Ekj5e/IWsy0sQIdu5sl7OmDPP/pwPeag4w8wtK1gNHlEPHyu1O3IsWfbSBzt 3ooQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oK4HRSNfmRH4Eic+dLGHWWE/yj5s+hx6sK8hLWYxbNg=; b=HX5dyATslEOs3AhuiCIIq5Wu+rHVznrvTPG2UDDrS60zJ8fvG8biiSL+/Dx3rnSbBp c673pPvaE2nXiznTJ98Tq/v3+BHGWcjNMQlaW8e1X+SBGjpTTiTPs3GcppHrmsDSQbU+ 7KHZNCyb055wjiwf/6lQrX/HI/saFuAM6J9nxQtDYKWp/KVMDpef9SjHzhEn1e0J/Y3f 6LQYRKpGHwr+KYNJ6RLwIfZR6j6DSh+qQDdrw2kphMZ+d7H9z6pfFgUnWkYEEW0B5fnz LRAoigM8EWFb0O48KGGVMSV3auSsDzfh2Ddrdw6QvKpXc1i6w0lLXhGmPFKTOyUhNJjS 7n9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=WoNQGnZ6; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h48si9456711ede.31.2019.10.01.07.56.45; Tue, 01 Oct 2019 07:56:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=WoNQGnZ6; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389364AbfJAO4o (ORCPT + 1 other); Tue, 1 Oct 2019 10:56:44 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44974 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389361AbfJAO4K (ORCPT ); Tue, 1 Oct 2019 10:56:10 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x91Eu8Fs123841; Tue, 1 Oct 2019 09:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569941768; bh=oK4HRSNfmRH4Eic+dLGHWWE/yj5s+hx6sK8hLWYxbNg=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=WoNQGnZ62aYs179fjqqXXhhp2TRm3iTNq6zbgCW3kWRVps0IXENk4kDDzcwK9bZlM jiywlAl+0YOFTLmPnEUhDEyWZeDxbRgDf6s6TMKgV4b8ttLFpdL1pbzTPKaPAVasdG P56A3akOTeiZ182C4MzJs3xAyqx2HWgacFEW6IUU= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x91Eu7C0041392 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Oct 2019 09:56:08 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 1 Oct 2019 09:56:07 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Oct 2019 09:56:07 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x91Eu7dt044750; Tue, 1 Oct 2019 09:56:07 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v10 15/16] leds: lp55xx: Fix checkpatch file permissions issues Date: Tue, 1 Oct 2019 09:56:19 -0500 Message-ID: <20191001145620.11123-16-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191001145620.11123-1-dmurphy@ti.com> References: <20191001145620.11123-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Fix the checkpatch warnings for the use of the file permission macros. In converting the file permissions to the DEVICE_ATTR_XX macros the call back function names needed to be updated within the code. This means that the lp55xx_ needed to be dropped in the name to keep in harmony with the ABI documentation. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c index 5de4f1789a44..87bf25795c87 100644 --- a/drivers/leds/leds-lp55xx-common.c +++ b/drivers/leds/leds-lp55xx-common.c @@ -78,7 +78,7 @@ static int lp55xx_post_init_device(struct lp55xx_chip *chip) return cfg->post_init_device(chip); } -static ssize_t lp55xx_show_current(struct device *dev, +static ssize_t led_current_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -87,7 +87,7 @@ static ssize_t lp55xx_show_current(struct device *dev, return scnprintf(buf, PAGE_SIZE, "%d\n", led->led_current); } -static ssize_t lp55xx_store_current(struct device *dev, +static ssize_t led_current_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -111,7 +111,7 @@ static ssize_t lp55xx_store_current(struct device *dev, return len; } -static ssize_t lp55xx_show_max_current(struct device *dev, +static ssize_t max_current_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -120,9 +120,8 @@ static ssize_t lp55xx_show_max_current(struct device *dev, return scnprintf(buf, PAGE_SIZE, "%d\n", led->max_current); } -static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current, - lp55xx_store_current); -static DEVICE_ATTR(max_current, S_IRUGO , lp55xx_show_max_current, NULL); +static DEVICE_ATTR_RW(led_current); +static DEVICE_ATTR_RO(max_current); static struct attribute *lp55xx_led_attrs[] = { &dev_attr_led_current.attr, @@ -281,7 +280,7 @@ static int lp55xx_request_firmware(struct lp55xx_chip *chip) GFP_KERNEL, chip, lp55xx_firmware_loaded); } -static ssize_t lp55xx_show_engine_select(struct device *dev, +static ssize_t select_engine_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -291,7 +290,7 @@ static ssize_t lp55xx_show_engine_select(struct device *dev, return sprintf(buf, "%d\n", chip->engine_idx); } -static ssize_t lp55xx_store_engine_select(struct device *dev, +static ssize_t select_engine_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -333,7 +332,7 @@ static inline void lp55xx_run_engine(struct lp55xx_chip *chip, bool start) chip->cfg->run_engine(chip, start); } -static ssize_t lp55xx_store_engine_run(struct device *dev, +static ssize_t run_engine_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t len) { @@ -358,9 +357,8 @@ static ssize_t lp55xx_store_engine_run(struct device *dev, return len; } -static DEVICE_ATTR(select_engine, S_IRUGO | S_IWUSR, - lp55xx_show_engine_select, lp55xx_store_engine_select); -static DEVICE_ATTR(run_engine, S_IWUSR, NULL, lp55xx_store_engine_run); +static DEVICE_ATTR_RW(select_engine); +static DEVICE_ATTR_WO(run_engine); static struct attribute *lp55xx_engine_attributes[] = { &dev_attr_select_engine.attr,