From patchwork Mon Oct 28 18:36:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 177965 Delivered-To: patch@linaro.org Received: by 2002:ac9:3c86:0:0:0:0:0 with SMTP id w6csp3418592ocf; Mon, 28 Oct 2019 11:38:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8MKdyUOxKzogaq9j5uFW3lncebVBteMgpb5UJfVHmnDqRG+e6/pnXzx+sTZE70pDi5T9u X-Received: by 2002:a50:9269:: with SMTP id j38mr20942677eda.5.1572287937662; Mon, 28 Oct 2019 11:38:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572287937; cv=none; d=google.com; s=arc-20160816; b=krB1Ks/aVSup4NJQUtmgD7hipZE5E9h8uAVAIyqVXQhXQh7QgsdkVH0pdpUuJcivGS 2jazFjxJ/h2tXJbUyA6trVHqrVpjIsQzjSDjE6qipi715JBgESJKJU/Q702jrYkjXPE4 AiKZPIOpDRtPMiNsz+oYyHGKS1IBW7iL75n9IwSq0Amus1WhzdIz/aUywPhmksJGH4iG qQKz4DcyEf5rVe/j6Mn5s3wu44P3j8PTyJBNH6i+s592qFVGgo7pvbBKtn18MsIYcqFU LVggjbTkjz5rLLuz1frLCodCLU5LUYSwtUwOkXA0fjn/ydyRpNMbc8S41PtfgN2RJbbS 79Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NQIDcyaqyTtBOLVrg500yyWcRWTyZF2LrgrP3Wcd470=; b=AobjF/Ig4pnAmhObTheguCfQsEH8QIzvyhre8nJI4NraG0yUpD44tRpuEkSIiaMY0m 1JDFhuB5JWfp5XRRG/rIKNdFqo9LHaFs49qo5v/N+gcV7x8GgglRc9FBTr3cyzx1f6ec 8uGibCQUkDB7zl0PHOquTzoCebCtysT2R7dilFWhYkJbNv3212VXPvFhZe8YYxg8FOeo z+eRHGudDZf+VlOqSpZVeqVnjuOYEFxvc/f3zYRX4Ec4PPruvjxdLQmxkscY6o09j3dx RAd7frHU1TBCeAd3Mh9NADXrtnrA0P4dU8oT9gxYspq+strFJ8xu/zlJTb0QHYTCkMAT wG4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="jm/MYWSo"; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cc4si9004790edb.237.2019.10.28.11.38.57; Mon, 28 Oct 2019 11:38:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="jm/MYWSo"; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728096AbfJ1Si5 (ORCPT + 1 other); Mon, 28 Oct 2019 14:38:57 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:57468 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbfJ1Si4 (ORCPT ); Mon, 28 Oct 2019 14:38:56 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9SIcs2i035107; Mon, 28 Oct 2019 13:38:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572287934; bh=NQIDcyaqyTtBOLVrg500yyWcRWTyZF2LrgrP3Wcd470=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=jm/MYWSoAe/dq6XUEpobGSEzbhwD2pCr+YK8H5vsa0aRSxZ0iFGneKYxvLVA9EWQP WzQ1iqu9Se9NZ4OHHyLZGDiA37FHZDjOYMtKrvuXp1EVF2aDL+4+ditmAmZ9YbgBz9 Jx5L2MZEx0RpH352rwpuPmQNJnUElDQ9ybugVcyk= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9SIcrDO104912 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 28 Oct 2019 13:38:53 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 28 Oct 2019 13:38:53 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Oct 2019 13:38:53 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9SIcrFj058023; Mon, 28 Oct 2019 13:38:53 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v15 17/19] leds: lp5523: Fix checkpatch issues in the code Date: Mon, 28 Oct 2019 13:36:27 -0500 Message-ID: <20191028183629.11779-18-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191028183629.11779-1-dmurphy@ti.com> References: <20191028183629.11779-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Fix checkpatch errors and warnings for the LP5523.c device driver. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 609288077917..cb402b5b4495 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -23,13 +23,13 @@ #define LP5523_PROGRAM_LENGTH 32 /* bytes */ /* Memory is used like this: - 0x00 engine 1 program - 0x10 engine 2 program - 0x20 engine 3 program - 0x30 engine 1 muxing info - 0x40 engine 2 muxing info - 0x50 engine 3 muxing info -*/ + * 0x00 engine 1 program + * 0x10 engine 2 program + * 0x20 engine 3 program + * 0x30 engine 1 muxing info + * 0x40 engine 2 muxing info + * 0x50 engine 3 muxing info + */ #define LP5523_MAX_LEDS 9 /* Registers */ @@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip, const u8 *data, size_t size) { u8 pattern[LP5523_PROGRAM_LENGTH] = {0}; - unsigned cmd; + unsigned int cmd; char c[3]; int nrchars; int ret; @@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len) static void lp5523_mux_to_array(u16 led_mux, char *array) { int i, pos = 0; + for (i = 0; i < LP5523_MAX_LEDS; i++) pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i)); @@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr) if (ret) return ret; - ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8)); + ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8)); if (ret) return ret;