| Message ID | 20250306172126.24667-2-trannamatk@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/3] dt-bindings: leds: Add LP5812 LED driver | expand |
On Fri, Mar 07, 2025 at 12:21:24AM +0700, Nam Tran wrote: > This documentation ensures proper integration of the LP5812 > in Device Tree-based systems. No changelog, no improvements in commit msg. You got comment at v1 to which you did not respond. Then you send v2 and I asked the same. Please respond to the comment at v1 so acknowledge that you udnerstood it. Your commit msg is totally redundant - you just said what Devicetree binding is. I asked to change it: describe the hardware instead. > > Signed-off-by: Nam Tran <trannamatk@gmail.com> > --- > .../devicetree/bindings/leds/ti,lp5812.yaml | 50 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/ti,lp5812.yaml > > diff --git a/Documentation/devicetree/bindings/leds/ti,lp5812.yaml b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml > new file mode 100644 > index 000000000000..9a203da4f272 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +$ref: /schemas/leds/common.yaml# > + > +title: Linux driver for LP5812 LED from Texas Instruments Nothing improved. > + > +maintainers: > + - Nam Tran <trannamatk@gmail.com> > + > +description: | > + The LP5812 is an I2C LED Driver that can support LED matrix 4x3. > + For more product information please see the link below: > + https://www.ti.com/product/LP5812#tech-docs > + > +properties: > + compatible: > + const: ti,lp5812 > + > + reg: > + maxItems: 1 This improved... but: > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 What are these? > + > +required: > + - compatible > + - reg > + Nothing improved here. You keep ignoring comments, not responding to them. This is not how you are supposed to work with reviewers. > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led-controller@1b { > + compatible = "ti,lp5812"; > + reg = <0x1b>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 8e0736dc2ee0..2bd9f5132cab 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23506,6 +23506,12 @@ S: Maintained > F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml > F: drivers/leds/leds-lp8864.c > > +TEXAS INSTRUMENTS' LP5812 LED DRIVER Nothing improved. NAK Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/leds/ti,lp5812.yaml b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml new file mode 100644 index 000000000000..9a203da4f272 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/ti,lp5812.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/ti,lp5812.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +$ref: /schemas/leds/common.yaml# + +title: Linux driver for LP5812 LED from Texas Instruments + +maintainers: + - Nam Tran <trannamatk@gmail.com> + +description: | + The LP5812 is an I2C LED Driver that can support LED matrix 4x3. + For more product information please see the link below: + https://www.ti.com/product/LP5812#tech-docs + +properties: + compatible: + const: ti,lp5812 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + led-controller@1b { + compatible = "ti,lp5812"; + reg = <0x1b>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 8e0736dc2ee0..2bd9f5132cab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23506,6 +23506,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/ti,lp8864.yaml F: drivers/leds/leds-lp8864.c +TEXAS INSTRUMENTS' LP5812 LED DRIVER +M: Nam Tran <trannamatk@gmail.com> +L: linux-leds@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/leds/ti,lp5812.yaml + TEXAS INSTRUMENTS' SYSTEM CONTROL INTERFACE (TISCI) PROTOCOL DRIVER M: Nishanth Menon <nm@ti.com> M: Tero Kristo <kristo@kernel.org>
This documentation ensures proper integration of the LP5812 in Device Tree-based systems. Signed-off-by: Nam Tran <trannamatk@gmail.com> --- .../devicetree/bindings/leds/ti,lp5812.yaml | 50 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/ti,lp5812.yaml base-commit: 48a5eed9ad584315c30ed35204510536235ce402