mbox series

[00/29,Set,15] Finally rid W=1 warnings from GPU!

Message ID 20210115181601.3432599-1-lee.jones@linaro.org
Headers show
Series Finally rid W=1 warnings from GPU! | expand

Message

Lee Jones Jan. 15, 2021, 6:15 p.m. UTC
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Lee Jones (29):
  drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural
  drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation
    problems
  drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member
  drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and
    remove others
  drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'
  drm/gma500/mmu: Actually return an error if one occurs
  drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff'
    param
  drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function
    param descriptions
  drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another
  drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member
    'manager'
  drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses
  drm/gma500/psb_irq: Demote kernel-doc abuse
  drm/drm_dp_helper: Fix spelling issue and add missing description for
    'enable_frl_ready_hpd'
  drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in
    'cdv_intel_crt_detect_hotplug()'s header
  drm/gma500/cdv_intel_display: Demote kernel-doc abuse in
    'cdv_intel_panel_fitter_pipe()'s header
  drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks
    and fix another
  drm/gma500/cdv_intel_dp: Demote one unworthy header fix another
  drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp'
  drm/gma500/oaktrail_lvds: Demote one documentation header fix another
  drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers
  drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting
    abuses
  drm/gma500/mdfld_intel_display: Demote three kernel-doc formatting
    abuses
  drm/drm_agpsupport: Strip out obviously wrong descriptions and demote
    to standard headers
  drm/i915/gvt/handlers: Remove kernel-doc formatting from
    non-kernel-doc header
  drm/nouveau/nouveau_ioc32: File headers are not good candidates for
    kernel-doc
  drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void
    function
  drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from
    'nouveau_bios_init()'
  drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment
    block
  drm/vmwgfx/ttm_object: Reorder header to immediately precede its
    struct

 drivers/gpu/drm/drm_agpsupport.c             | 46 +++++---------------
 drivers/gpu/drm/drm_dp_helper.c              |  3 +-
 drivers/gpu/drm/gma500/cdv_intel_crt.c       |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_display.c   |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_dp.c        |  4 +-
 drivers/gpu/drm/gma500/cdv_intel_lvds.c      |  7 +--
 drivers/gpu/drm/gma500/mdfld_dsi_output.c    |  4 +-
 drivers/gpu/drm/gma500/mdfld_intel_display.c |  6 +--
 drivers/gpu/drm/gma500/mmu.c                 |  2 +-
 drivers/gpu/drm/gma500/oaktrail_crtc.c       |  6 +--
 drivers/gpu/drm/gma500/oaktrail_lvds.c       |  3 +-
 drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c   |  8 ++--
 drivers/gpu/drm/gma500/psb_intel_sdvo.c      |  6 +--
 drivers/gpu/drm/gma500/psb_irq.c             |  3 +-
 drivers/gpu/drm/i915/gvt/handlers.c          |  2 +-
 drivers/gpu/drm/nouveau/nouveau_bios.c       |  2 -
 drivers/gpu/drm/nouveau/nouveau_ioc32.c      |  4 +-
 drivers/gpu/drm/nouveau/nouveau_svm.c        |  5 +--
 drivers/gpu/drm/vmwgfx/ttm_object.c          | 25 ++++++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c      |  9 ++--
 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c         |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c       |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c      |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c          |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_so.c           |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_thp.c          |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c   |  5 ++-
 27 files changed, 74 insertions(+), 90 deletions(-)

Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: Eddie Dong <eddie.dong@intel.com>
Cc: Eric Anholt <eric@anholt.net>
Cc: Faith <faith@valinux.com>
Cc: Gareth Hughes <gareth@valinux.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Cc: Jackie Li <yaodong.li@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jan Safrata <jan.nikitenko@gmail.com>
Cc: Jesse Barnes <jesse.barnes@intel.com>
Cc: jim liu <jim.liu@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Keith Packard <keithp@keithp.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-media@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Min He <min.he@intel.com>
Cc: Niu Bing <bing.niu@intel.com>
Cc: nouveau@lists.freedesktop.org
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Pei Zhang <pei.zhang@intel.com>
Cc: Ping Gao <ping.a.gao@intel.com>
Cc: Rob Clark <rob.clark@linaro.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Tina Zhang <tina.zhang@intel.com>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Zack Rusin <zackr@vmware.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Zhiyuan Lv <zhiyuan.lv@intel.com>

Comments

Zack Rusin Jan. 15, 2021, 6:27 p.m. UTC | #1
> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> 
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Thanks! For all the vmwgfx bits:
Reviewed-by: Zack Rusin <zackr@vmware.com>

z
Lee Jones Jan. 18, 2021, 3:09 p.m. UTC | #2
On Mon, 18 Jan 2021, Daniel Vetter wrote:

> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > 
> > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > 
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > > 
> > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > 
> > Thanks! For all the vmwgfx bits:
> > Reviewed-by: Zack Rusin <zackr@vmware.com>
> 
> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> (those generally go through other trees, pls holler if they're stuck).

Thanks Daniel, you're a superstar!

So Zack will take the vmwgfx parts?  Despite providing a R-b?

> Note that we have some build issue on some of the configs sfr uses, so drm
> trees are still stuck on old versions in linux-next. Hopefully should get
> resolved soon, the bugfix is in some subtree I've heard.

No worries.  Thanks for letting me know.
Daniel Vetter Jan. 18, 2021, 5:21 p.m. UTC | #3
On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> 
> > On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > > 
> > > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > > 
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > > 
> > > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > > 
> > > Thanks! For all the vmwgfx bits:
> > > Reviewed-by: Zack Rusin <zackr@vmware.com>
> > 
> > Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> > (those generally go through other trees, pls holler if they're stuck).
> 
> Thanks Daniel, you're a superstar!
> 
> So Zack will take the vmwgfx parts?  Despite providing a R-b?

I only merge stuff that's defacto abandoned already. Everything else I try
to offload to whomever actually cares :-)
-Daniel

> 
> > Note that we have some build issue on some of the configs sfr uses, so drm
> > trees are still stuck on old versions in linux-next. Hopefully should get
> > resolved soon, the bugfix is in some subtree I've heard.
> 
> No worries.  Thanks for letting me know.
> 
> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lee Jones Jan. 19, 2021, 8:29 a.m. UTC | #4
On Mon, 18 Jan 2021, Daniel Vetter wrote:

> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> > On Mon, 18 Jan 2021, Daniel Vetter wrote:
> > 
> > > On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> > > > 
> > > > > On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> > > > > 
> > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > niggly little warnings.
> > > > > 
> > > > > Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> > > > 
> > > > Thanks! For all the vmwgfx bits:
> > > > Reviewed-by: Zack Rusin <zackr@vmware.com>
> > > 
> > > Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> > > (those generally go through other trees, pls holler if they're stuck).
> > 
> > Thanks Daniel, you're a superstar!
> > 
> > So Zack will take the vmwgfx parts?  Despite providing a R-b?
> 
> I only merge stuff that's defacto abandoned already. Everything else I try
> to offload to whomever actually cares :-)

Understood.  Thanks for the explanation.

Hopefully Zack actually cares. :D
Lee Jones Jan. 20, 2021, 8:05 a.m. UTC | #5
On Tue, 19 Jan 2021, Zack Rusin wrote:

> 
> 
> > On Jan 19, 2021, at 03:29, Lee Jones <lee.jones@linaro.org> wrote:
> > 
> > On Mon, 18 Jan 2021, Daniel Vetter wrote:
> > 
> >> On Mon, Jan 18, 2021 at 03:09:45PM +0000, Lee Jones wrote:
> >>> On Mon, 18 Jan 2021, Daniel Vetter wrote:
> >>> 
> >>>> On Fri, Jan 15, 2021 at 06:27:15PM +0000, Zack Rusin wrote:
> >>>>> 
> >>>>>> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones@linaro.org> wrote:
> >>>>>> 
> >>>>>> This set is part of a larger effort attempting to clean-up W=1
> >>>>>> kernel builds, which are currently overwhelmingly riddled with
> >>>>>> niggly little warnings.
> >>>>>> 
> >>>>>> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
> >>>>> 
> >>>>> Thanks! For all the vmwgfx bits:
> >>>>> Reviewed-by: Zack Rusin <zackr@vmware.com>
> >>>> 
> >>>> Ok I merged everything except vmwgfx (that's for Zack) and i915/nouveau
> >>>> (those generally go through other trees, pls holler if they're stuck).
> >>> 
> >>> Thanks Daniel, you're a superstar!
> >>> 
> >>> So Zack will take the vmwgfx parts?  Despite providing a R-b?
> >> 
> >> I only merge stuff that's defacto abandoned already. Everything else I try
> >> to offload to whomever actually cares :-)
> > 
> > Understood.  Thanks for the explanation.
> > 
> > Hopefully Zack actually cares. :D
> 
> hah, I do. I just pushed all of the changes to drm-misc-next. Let me
> know if I missed anything. Thanks!

Perfect.  Thank you Zack.