mbox series

[v2,0/2] gmsl: Use unsigned constants and BIT where appropriate

Message ID 20210120154614.2750268-1-kieran.bingham+renesas@ideasonboard.com
Headers show
Series gmsl: Use unsigned constants and BIT where appropriate | expand

Message

Kieran Bingham Jan. 20, 2021, 3:46 p.m. UTC 
During pre-integration reviews of the GMSL (MAX9286/MAX9271) patches,
one comment was to mark the constants used in bitfield shifts as
explicitly unsigned. This ensures that any use of a register write that
updates bit 31 is operated correctly.

Whilst none of these register shifts affect bit 31 in any of the
registers, update the values to follow best practices and ensure
consistency if further additions are made.

Please note, this does not remove or clean up the 'Prefer BIT' check
patch warnings, as the use of the BIT macro is still not applicable to
all of these entries. Entries where it is applicable and only a single
bit is modified have been converted accordingly.

Kieran Bingham (2):
  media: i2c: max9286: Use unsigned constants and BIT()
  media: i2c: max9271: Use unsigned constants

 drivers/media/i2c/max9271.h | 60 +++++++++++------------
 drivers/media/i2c/max9286.c | 96 ++++++++++++++++++-------------------
 2 files changed, 78 insertions(+), 78 deletions(-)