From patchwork Tue Jul 26 02:14:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 593676 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BECBC433EF for ; Tue, 26 Jul 2022 02:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231517AbiGZCPA (ORCPT ); Mon, 25 Jul 2022 22:15:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231526AbiGZCO7 (ORCPT ); Mon, 25 Jul 2022 22:14:59 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D4FB28E2E for ; Mon, 25 Jul 2022 19:14:58 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id d8so18193606wrp.6 for ; Mon, 25 Jul 2022 19:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RhszBCa65sY3B/JEP4mgxAurV3P0RyQjhKzWzBEXlD0=; b=QH79a5AB3nRvrSJmSxcHH49VYHb3Icop88lSzU+L8Jzd/qIoxDQWIOm2uuzh1BN1K/ CbFRcI92RC4NeQTc7zAqBQqBYK03z/gnpOdLaTQLT7h0pXZ8EVNc2PqqyFRQDSU72hE9 iSRIlxsENzjZ65TtdYfKVNDpjI7Tt3sa0ZmxufFzydw+FkyCXrDWxsuS2Ot/fyGphNOv i8iYaRe8GisLfjkNQW5FDyo8vfVk6XQYtM85fFRWrEvH/zzBf3STGiQj2NPIRO6QqUmG Ku6VECO3PFvofXZXZfMzHgI72kFU59SYH6NthZFPCKnr9DoH8WN2sSdxkpv68D9yrjx6 QGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RhszBCa65sY3B/JEP4mgxAurV3P0RyQjhKzWzBEXlD0=; b=2ti5BV6gHSfPNRT4KrL9r1MM+b0qK5qOvZfLsUAJHsiXohcJ44mudh+OzPd75orl0n csjKK70lG4Ml65sBprrAgdcxSmxlWoNpXd+wf1LaQujiD6T0A97FErwp6Jlt/YTT1P+s gJKEZr4bTBHvS5HJf/G3CEm8JyUyOsNbqyUcRrDDCKMQTUSrll6aSzT3ey/kIMLXVZ2T sVWprGYzGwavuG7/Jsy2noTMb9LUQQG9ZkPTlt/6TmcQjr5Q4ETQ6OJ5VcaHH/lrLFUY nVy0DHrJ69bHQSAZD2ilp1D/fZONeXeDIuvyeChypiJ7V6jAbobjmX3oQylK9Q0kG+PA QDLw== X-Gm-Message-State: AJIora/8blvgvwMYYVIBMNcOXRtUTa1gtxfwuuYGwsxprNqiA96skySJ zbOsgvWVnLxo1b6cRRCoKuzhLQ== X-Google-Smtp-Source: AGRyM1sWuQscPIsL6LyIA+VZIh4QqtkwQHxPi6WBNwhf9q5hwOMgJF5eck9sBbuTCoCR6s6jC6BS2w== X-Received: by 2002:adf:d084:0:b0:21e:5570:2b05 with SMTP id y4-20020adfd084000000b0021e55702b05mr9124524wrh.554.1658801697069; Mon, 25 Jul 2022 19:14:57 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id r67-20020a1c2b46000000b003a308e9a192sm20005984wmr.30.2022.07.25.19.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jul 2022 19:14:56 -0700 (PDT) From: Bryan O'Donoghue To: stanimir.varbanov@linaro.org, agross@kernel.org, bjorn.andersson@linaro.org, konrad.dybcio@somainline.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, bryan.odonoghue@linaro.org Subject: [PATCH 0/2] media: venus: Fix up buffer handling for HFI_VERSION_1XX Date: Tue, 26 Jul 2022 03:14:53 +0100 Message-Id: <20220726021455.1814096-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This series fixes two buffer handling bugs. The first bug is trivial and ~impossible to hit without the second bug but with fixing anyway. Its a simple NULL pointer handling issue. The second bug relates to HFI_VERSION_1XX output buffers. Unfortunately these have been broken since Commit: 9593126dae3e ("media: venus: Add a handling of QC08C compressed format") A bit of bisecting the commits in venus found it handily enough. Once the fix is applied we have I have decode working again on db410c. Bryan O'Donoghue (2): media: venus: dec: Handle the case where find_format fails media: venus: Fix NV12 decoder buffer discovery on HFI_VERSION_1XX drivers/media/platform/qcom/venus/helpers.c | 13 +++++++------ drivers/media/platform/qcom/venus/vdec.c | 2 ++ 2 files changed, 9 insertions(+), 6 deletions(-) Acked-by: Stanimir Varbanov