mbox series

[v3,0/3] Fix error handling for MDP3

Message ID 20221020071800.20487-1-moudy.ho@mediatek.com
Headers show
Series Fix error handling for MDP3 | expand

Message

Moudy Ho Oct. 20, 2022, 7:17 a.m. UTC 
Changes since v2:
- Rebase on v6.1-rc1.
- Merge with the following series:
  [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=683526

Changes since v1:
- Rename goto label in mdp_comp_clock_on() from "err_unwind"
  to "err_revert" to make more readable.

Hi,
This series fixes some error handling in MDP3 in response to the bug report
submitted by Dan Carpenter (Message ID = YxB1E00e8D6P4W2e@kili)

Moudy Ho (3):
  media: platform: mtk-mdp3: fix error handling in mdp_cmdq_send()
  media: platform: mtk-mdp3: fix error handling about components
    clock_on
  media: platform: mtk-mdp3: fix error handling in mdp_probe()

 .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c    | 51 ++++++++++---------
 .../platform/mediatek/mdp3/mtk-mdp3-comp.c    | 24 ++++++---
 .../platform/mediatek/mdp3/mtk-mdp3-core.c    | 15 +++---
 3 files changed, 53 insertions(+), 37 deletions(-)

Comments

AngeloGioacchino Del Regno Oct. 21, 2022, 8:47 a.m. UTC | #1 
Il 20/10/22 09:18, Moudy Ho ha scritto:
> Adjust label "err_return" order to avoid double freeing, and
> add two labels for easy traceability.
> 
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>