From patchwork Tue Dec 13 14:35:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 633820 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BCD3C4167B for ; Tue, 13 Dec 2022 14:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235873AbiLMOgJ (ORCPT ); Tue, 13 Dec 2022 09:36:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235481AbiLMOgI (ORCPT ); Tue, 13 Dec 2022 09:36:08 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A752B7D1 for ; Tue, 13 Dec 2022 06:36:03 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id tz12so14308153ejc.9 for ; Tue, 13 Dec 2022 06:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:from:to:cc:subject:date:message-id:reply-to; bh=3KSo9ppIdG6X2IRIV3Is6pnJ2EnoDBDtdV9Y5rl06s4=; b=Y/9tXyeq5qgBjgpkb1GkdhHeISWU7Xv9O8zF73Tj2sQ8bYqGdkXOiIIMxx+m4d4Ja1 16wdaza8wUVWtxuM3pcV+zwa7hqvmJeDrfQCYuI26NK6U7tbj60k+UREYSrOou8QsNO0 Vs0b910kHmMPjKRwUbOqUv3H6s6lNWp9UMveA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3KSo9ppIdG6X2IRIV3Is6pnJ2EnoDBDtdV9Y5rl06s4=; b=d3QeEuJPCGXBKA54SsQa9NqMJ0hyAXLot73Eb1nxVaiRd9eCpVBiDZjsVNusPXwwwn ZMd8yhb5qm1iG3Pu+QIGs/OpJWEDE4mH8UgST3Sa2cMKxChzWIDoDw3D0T6J8O+kp6zP el79zcLA/Qvl3HdDmcLEhpi7D+cg6Z89GdbpJb4fDh18T9mgu9CgiLFwgSTWamLbEd9d RGfw9+0VLDPFU3STtun+DLUQbmKvhm5V16xEQPec3+he46eWyOWK0iM/I0hmsdGRR1tj /FJDIXV4FupxYiuDokCtOGYtGAuqOdHnx0WMTPEUPY4fe4Vtu5CvTv2SKNnyuhkgm+r/ vP4Q== X-Gm-Message-State: ANoB5pnzt3aR/7XyEgie21HemygPDci6nCaWuF9oJO6W3AI/wgN97q32 d/DzxR+VwjPfvkmYiIbj3xBIad2xAVxe0HfQ19o= X-Google-Smtp-Source: AA0mqf7L4q7Q0AJq1ykGpUHG03QcWOsXVm0QhgmrgWarGnIBpfHiHuhZG3wfzDV501QiKR2PwgJPjg== X-Received: by 2002:a17:907:d408:b0:7c1:d4c:f08c with SMTP id vi8-20020a170907d40800b007c10d4cf08cmr16735972ejc.4.1670942161961; Tue, 13 Dec 2022 06:36:01 -0800 (PST) Received: from alco.roam.corp.google.com ([100.104.168.209]) by smtp.gmail.com with ESMTPSA id kv17-20020a17090778d100b00781dbdb292asm4613960ejc.155.2022.12.13.06.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 06:36:01 -0800 (PST) Subject: [PATCH v2 0/2] uvc: Fix race condition on uvc MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIALGNmGMC/22MwQrCMBBEf6Xs2ZUmxbZ68j/EQ7pdm0CbwMYGpO TfXTzLHIY3zMwBmSVwhltzgHAJOaSoYE8NkHdxYQyzMtjWWqPCvRCKI8b2aoeeXT9OrxG0PrnMOI mL5HUQ93XV0If8TvL53Rej9vjzVAy2SBfLZhg76sx8Jy9pC/t2TrLAs9b6BazsgwqoAAAA From: Ricardo Ribalda Date: Tue, 13 Dec 2022 15:35:29 +0100 Message-Id: <20221212-uvc-race-v2-0-54496cc3b8ab@chromium.org> To: Max Staudt , Sergey Senozhatsky , Yunke Cao , Laurent Pinchart , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.11.0-dev-696ae X-Developer-Signature: v=1; a=openpgp-sha256; l=1169; i=ribalda@chromium.org; h=from:subject:message-id; bh=2Bhn1vCFMeNrxtBx4BsUuNf1hQMq9VedOxEASLCByKY=; b=owEBbQKS/ZANAwAKAdE30T7POsSIAcsmYgBjmI3DX7TUa1eGQvH/LR3y+nk6vN2kPSoNUfGSuDhI EGpQlFOJAjMEAAEKAB0WIQREDzjr+/4oCDLSsx7RN9E+zzrEiAUCY5iNwwAKCRDRN9E+zzrEiO8pD/ 46Uhh+cZQgbrVOWB+pBrJsfshUnnO6L5MTkdUHsNaGsAZ6wB5x/H38ja7XhCpj5rr1Dew+YM7NJhz5 IU4UPRLzMKIFe09H8LUO62FJ/e5FQ2UYOyiSJz5tmPZ6pOV96iCMwJavzv1pD5kUt8wg/SHBHoGmhG S2rY193NwrwKSZ2NF8H2OOc//5CTtAd/HfzvGhPUwXv1M8AiGRmSaKFrOKHVCTgPakc0U/R55iWb+1 zh8igTHykHL4372J0R/gbFbLx5QWytkWBmRw21NAPckfQSwLcJY9RctnhZm0Wky7Ltww9qBfrx9iNu GHkBM/pBj3OQTVJQtlCga+hmeRU40cux2QXHGQlpW9BTS77Cs9PBrK09AbmuVw33sLDAm7W0/1iDfY 0kkZ0IRjIRdCxQeNuztDkwd7JdI0fu9Hb9B/pDxDcyS74ODE25YOrI0AmnC1ZW/KLG7grx8iIx9uUZ whJquYIl4odBjqW8sUNN+//4GW6pDaDBtAWugSRWy78dy+4BKQ67sgQcWu0cKckQY8y+GPZafz93NA mzfO3N0vcC7+QNGa0GNYSjy4tTJX0yHu5sfOTbVs+RqgifpplC/pQf+7es8RC7UlY1nn9JD/4N6q/s GuLmsaeQYWQRg88NHmI+dZZbGXXdAdQxBisDa4QTok/UdQeS/GdL0kJCbwew== X-Developer-Key: i=ribalda@chromium.org; a=openpgp; fpr=9EC3BB66E2FC129A6F90B39556A0D81F9F782DA9 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Make sure that all the async work is finished when we stop the status urb. To: Yunke Cao To: Sergey Senozhatsky To: Max Staudt To: Laurent Pinchart To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ricardo Ribalda --- Changes in v2: - Add a patch for not kalloc dev->status - Redo the logic mechanism, so it also works with suspend (Thanks Yunke!) - Link to v1: https://lore.kernel.org/r/20221212-uvc-race-v1-0-c52e1783c31d@chromium.org --- Ricardo Ribalda (2): media: uvcvideo: Fix race condition with usb_kill_urb media: uvcvideo: Do not alloc dev->status drivers/media/usb/uvc/uvc_ctrl.c | 3 +++ drivers/media/usb/uvc/uvc_status.c | 15 +++++++-------- drivers/media/usb/uvc/uvcvideo.h | 3 ++- 3 files changed, 12 insertions(+), 9 deletions(-) --- base-commit: 0ec5a38bf8499f403f81cb81a0e3a60887d1993c change-id: 20221212-uvc-race-09276ea68bf8 Best regards,