mbox series

[v2,0/2] IVSC support for IPU bridge

Message ID 20230630134506.109269-1-sakari.ailus@linux.intel.com
Headers show
Series IVSC support for IPU bridge | expand

Message

Sakari Ailus June 30, 2023, 1:45 p.m. UTC 
Hi,

I rebased the IVSC support patch on Hans de Goede's IPU bridge fixes and
cleanups. I've tested it on MS Surface Go 2. I also added a patch to move
the pre-existing exported symbol to the same namespace than the rest.

Sakari Ailus (1):
  media: ipu-bridge: Make exported IPU bridge symbol GPL-only in a NS

Wentong Wu (1):
  media: ipu-bridge: add IVSC support

 drivers/media/pci/intel/ipu-bridge.c | 197 ++++++++++++++++++++++++++-
 include/media/ipu-bridge.h           |  19 ++-
 2 files changed, 208 insertions(+), 8 deletions(-)

Comments

Andy Shevchenko June 30, 2023, 5:45 p.m. UTC | #1 
On Fri, Jun 30, 2023 at 04:45:05PM +0300, Sakari Ailus wrote:
> From: Wentong Wu <wentong.wu@intel.com>
> 
> Previously on ACPI platforms, sensors that are intended to be connected
> to a IPU device for use with the ipu3-cio2 driver lacking the necessary
> connection information in firmware. IPU bridge driver is to connect
> sensors to IPU device via software nodes.
> 
> Currently IVSC located between IPU device and sensors is available in
> existing commercial platforms from multiple OEMs. But the connection
> information between them in firmware is also not enough to build V4L2
> connection graph. This patch parses the connection properties from the
> SSDB buffer in DSDT and build the connection using software nodes.
> 
> IVSC driver is based on MEI framework (previously known as HECI), it
> has two MEI clients, MEI CSI and MEI ACE. Both clients are used to
> communicate messages with IVSC firmware. Linux abstracts MEI client
> as a device, whose bus type is MEI. And the device is addressed by a
> GUID/UUID which is part of the device name of MEI client. After figured
> out MEI CSI via the UUID composed device name, this patch setup the
> connection between MEI CSI and IPU, and the connection between MEI CSI
> and sensor via software nodes.
> 
> Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> [Sakari Ailus: rebase on Hans de Goede's cleanups and fixes]

I believe we use past tense in these comment lines...

> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>