| Message ID | 20230803-ub9xx-uninit-vars-v2-0-512570ecb798@ideasonboard.com |
|---|---|
| Headers | show |
| Series | media: i2c: ds90ubxxx: Fix uninitialized variable uses | expand |
On Thu, Aug 03, 2023 at 03:15:47PM +0300, Tomi Valkeinen wrote: > smatch reports: > > drivers/media/i2c/ds90ub960.c:1788 ub960_init_tx_ports() error: uninitialized symbol 'pll_div'. > > This is caused by 'pll_div' not being set for 1200 MHz CSI rate. Set the > 'pll_div' correctly. > > Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver") > Reported-by: Hans Verkuil <hverkuil@xs4all.nl> > Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> My Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> from v1, send before I noticed v2 was on the list, still applies. > --- > drivers/media/i2c/ds90ub960.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c > index 4833b39b9178..4ab45e326d80 100644 > --- a/drivers/media/i2c/ds90ub960.c > +++ b/drivers/media/i2c/ds90ub960.c > @@ -1763,6 +1763,7 @@ static int ub960_init_tx_ports(struct ub960_data *priv) > break; > case MHZ(1200): > speed_select = 1; > + pll_div = 0x18; > break; > case MHZ(800): > speed_select = 2; >
Fix uses of uninitialized variables, reported by smatch. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- Changes in v2: - Split the ds90ub9x3 patch into two - Link to v1: https://lore.kernel.org/r/20230803-ub9xx-uninit-vars-v1-0-284a5455260f@ideasonboard.com --- Tomi Valkeinen (3): media: i2c: ds90ub913: Fix use of uninitialized variables media: i2c: ds90ub953: Fix use of uninitialized variables media: i2c: ds90ub960: Fix PLL config for 1200 MHz CSI rate drivers/media/i2c/ds90ub913.c | 2 +- drivers/media/i2c/ds90ub953.c | 6 +++--- drivers/media/i2c/ds90ub960.c | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) --- base-commit: a0e657a03ffbd26332f316f13c3e5dbc98cb1fca change-id: 20230803-ub9xx-uninit-vars-733337ba1051 Best regards,