From patchwork Thu Apr 24 08:38:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Eric Pelloux-Prayer X-Patchwork-Id: 884125 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2063.outbound.protection.outlook.com [40.107.92.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E02E213240; Thu, 24 Apr 2025 08:39:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483988; cv=fail; b=TQ6Hlg8L7f8xPRlK3hPcKxqRb4bJei5OnufpEWbQsX3/rHrjP1yPHs13SMEsLwqO6960W9al+64UHBDvOSSiH3zNct7YTglGu1Y5aqhlzdk+2bQdTe3d7l5kQlWy3ODIfAQof/n9MTjIPv/oopZvEAFfivMHHiYkqxHZ0X7Uv24= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745483988; c=relaxed/simple; bh=6izECVWFKxS11cO8VX7ZCnHuchO00vsaewrBNGkgH34=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ayvex/y8mnCtTy8DNX0R81xAiJDffpmNPQGKJvN7I1u8r9JepZM4HppGYtbAzzODoAbrsJFpaKHlvAKRnz6uRBO3oNOOokKQCD/hzebjrZ8AM6Im3fBuRRNQgR9C4pcYIpqoR8aUXKbn30PwqKrCEVcrRZNnGp8Xy3kL3qmql8g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=k/CrjkOu; arc=fail smtp.client-ip=40.107.92.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="k/CrjkOu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LGJs90zMc1bACi2eGEiV0VbNAckeQz6pjDU5JLIBu+ZgTY7FWz0Xcz9sX3F53AyZq9uAgSwIpE+fYYXN3CMsS8nUj9CIKgcfprPoVO1jmXLyRmvZuRhBS7ilqK4sdj8nsNYz/xPak+j55Ea0D3vZhhuRrNA8NuzQCMc0hpdNsaLHR8bj/ub/pzxMiAv+F5UroL91d/cHFRyORnsg/qIA+DYdas9/e+ejB5HoM55Sc7BGSfrffA9NgWSwEplkQjgA2LwFFrkR5+5qFGJVLkqSfpWWkyKH5IZthFdgcaZSwDOVXldRMdZCSIQ0WH79HJpLf3oKMJmWcLDzKAzcfII1+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0tSD/J5biPvWWJwRdEfa6+ZRmIYWhZ7uE7oXnoFb3No=; b=UEVYpA8rThNMzqotdfDWnsfV3sMXAZ+H3aTjsa5VB2ZimgOedKi+aI+feErDrCJR1Mb5DuB3YkjWl7F0DJICYEijC08HKHHJiFmjHZ2Ow1H+Qxq472yRmHXBUeOGhyyrHWDDl5s+QQJAAJjC2FCQUXevhdPy0lKS1TT6xfOZkuzphWGdNBkVb6AFoaCcrq/JRSaUykKdyIj97x2bpnXaUhakT9StBNV1U+nJlzZ9C+NGEy0vSTZ47kF68LN8yW/X4YgnwBdvD/KZ20sg7jpzudE1VIamvZsAJaGsIwztRTxRcU97Z1u3O7267Aai1hQCjmHLM7MyWZhYPaEAAP+UYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=igalia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0tSD/J5biPvWWJwRdEfa6+ZRmIYWhZ7uE7oXnoFb3No=; b=k/CrjkOu73xtGphmNM2f/nyjLinzWsGsQR/aSCLuJ7R8gsWUYWGqJCQTaFD/LQ82pZF5y4rhBOE5v/Ee5h2um8sxm0Epn1O4euLhS19lKWVE8kSTt1mzZ3UFC+qzdlCA8aPFOW/5QCYNoR+JsvzXAjIXKWZRaMZ887y9L8vd2UI= Received: from DS7PR03CA0360.namprd03.prod.outlook.com (2603:10b6:8:55::33) by DM3PR12MB9288.namprd12.prod.outlook.com (2603:10b6:0:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.26; Thu, 24 Apr 2025 08:39:40 +0000 Received: from CH3PEPF00000018.namprd21.prod.outlook.com (2603:10b6:8:55:cafe::91) by DS7PR03CA0360.outlook.office365.com (2603:10b6:8:55::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.36 via Frontend Transport; Thu, 24 Apr 2025 08:39:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CH3PEPF00000018.mail.protection.outlook.com (10.167.244.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8699.1 via Frontend Transport; Thu, 24 Apr 2025 08:39:39 +0000 Received: from FRAPPELLOUX01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 24 Apr 2025 03:39:29 -0500 From: Pierre-Eric Pelloux-Prayer To: CC: Pierre-Eric Pelloux-Prayer , =?utf-8?q?Christian_K=C3=B6nig?= , =?utf-8?q?Ma?= =?utf-8?q?=C3=ADra_Canal?= , =?utf-8?q?Thomas_Hellstr?= =?utf-8?q?=C3=B6m?= , Abhinav Kumar , Alex Deucher , Boris Brezillon , Danilo Krummrich , David Airlie , "Dmitry Baryshkov" , Felix Kuehling , "Frank Binns" , Jonathan Corbet , Liviu Dudau , Lizhi Hou , Lucas De Marchi , Lucas Stach , Lyude Paul , Maarten Lankhorst , Matt Coster , Matthew Brost , Maxime Ripard , Melissa Wen , Min Ma , Oded Gabbay , Philipp Stanner , Qiang Yu , Rob Clark , Rob Herring , Rodrigo Vivi , Simona Vetter , Steven Price , Sumit Semwal , "Thomas Zimmermann" , , , , , , , , , , , , Subject: [PATCH v9 00/10] Improve gpu_scheduler trace events + UAPI Date: Thu, 24 Apr 2025 10:38:12 +0200 Message-ID: <20250424083834.15518-1-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000018:EE_|DM3PR12MB9288:EE_ X-MS-Office365-Filtering-Correlation-Id: 54712985-a53a-442f-999f-08dd830b8d94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|7416014|376014|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?q?TMPRwnZS/1+qS6jIhgxuWDYBs1I3vpJ?= =?utf-8?q?hObCkdFb0oZtNC2w7vXetSMFOfkrQZVucKLAhs27sjhfWFewmA1WYdrJZ6TFAh/SI?= =?utf-8?q?a2KBBu2mEV+PGa8nUlIjdA72J4+A6ZgMmW00+1fgYJv2oFoISHHiV/LCbU1Z8HGCu?= =?utf-8?q?V8VaeaLziDldU2N/Cq8F3+XcWD2doZMZkmXP5D0XPRtfA89b4LVvg1v/HOkgcQlBp?= =?utf-8?q?zDkeGUIinJbhWognvhUZxg7qJiXuk++UmC2YT/EutX1NgfPc968IdBxH6Prkgy8MJ?= =?utf-8?q?QBRbvLXdiBB/biV8YB8CEjaLJcP6uL7LT0mABD+zYaKo/LSzTPoNXK21XGR7hFz+g?= =?utf-8?q?1M7VlW/pVERb0z5mUEC8gSbx9EmxbbkqvF/xpmoD/S43rVTVy7wbTa+G8wWHId2h1?= =?utf-8?q?zLYTSY+mgFVbeFCwkcdWf4jjHhLetfz0cRXAoCTayebNNEuoDsxO1EfHRtgjnWNqj?= =?utf-8?q?b5XdoOCiaZjoKjalJrG9Z9Bo4UxKf6gwKokD4Qb5GOBRYZ6VDZkf7bCbx8bgBUKRM?= =?utf-8?q?BchUN76xe4pNZDD19xLEpfMtTq7Dm2kNoX6QwCcut0x5335eShMCO29e+VYx6ZxX2?= =?utf-8?q?dVbzj6bj6bNeeZyaHXjGPSXKP8uc/M/tK6i5C+/mUohpU9GUSLWyT0nQenXR0JDoG?= =?utf-8?q?6F6tY5mz8HBcwGg7+Y56+yTxCuLI/A2sGByDGXd4FxuTL+/SXgzV087GS9k7yG78+?= =?utf-8?q?oPAicZn2aOeKcbhxbPDVjbYhUGtPIEgrf/MnlU8PdKt8Eg7Z8dh3zpbIxRXhvLlNI?= =?utf-8?q?Fs6dVgf0lhThDHxifThCDOx0XWDQxtNtQEXpD5Msc/GwJcZOuQ8eUE41LvZEhbWEy?= =?utf-8?q?K2JD1qEyjRYg7CMoVwG2IC6nyQkv2P+tl6F8ExR613mef+Whqlsnx+MWh6zUhBQ0L?= =?utf-8?q?8cEYQvVQgsP6JKPhSM+pW+IeK89de7v5uVUNuRn0BqZSDiRs4CM4wCAd1wroEjVXy?= =?utf-8?q?yVRqENPAbtQ6Q/CGLyfuO2ykBIKe5EE5FaULt2hEARCZ2MkkhIpgkIGEl2zI+wD/Z?= =?utf-8?q?iFCLQ8qEXSLFNGasH+axjxAvL7iOqeghjskJVlN/9EETUU/10VzBqG4dhtOHO/YOu?= =?utf-8?q?dtwHUsM7f4TumfeAC2f9DhWJjJ6ohD3+PrAQfdH2EaFtiN7dtI4qCIR654lMK0TkK?= =?utf-8?q?UJIc0dmi+cgf9IKB+RtsTuA3fR5OASkgoDiEvnCXJxoiJB3kGIaHt3YrG62u9LikD?= =?utf-8?q?DZMJ+6BPQBlsuCP5I/9a8ZJwLX32CHMJvJqPmxUcpIW/jMMeo7hJ/6uXb2ptAxjS5?= =?utf-8?q?2VRTkR4YO4h0ewgMhiBRcqGjEf+xtxOytRoaUxuJuwSXMdaGfw6VdvVHWst0T8/dA?= =?utf-8?q?YXwO1JPsfjIQ6VqA+NMWqSZZVrT/g+qhZwkkU6CyivBfcl0g0TcT9SWXkQLrCMWVG?= =?utf-8?q?nDwtSV8eLpbdSh1kTOEnGra99RU03XYkw=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(7416014)(376014)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2025 08:39:39.9052 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54712985-a53a-442f-999f-08dd830b8d94 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000018.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR12MB9288 Hi, The initial goal of this series was to improve the drm and amdgpu trace events to be able to expose more of the inner workings of the scheduler and drivers to developers via tools. Then, the series evolved to become focused only on gpu_scheduler. The changes around vblank events will be part of a different series, as well as the amdgpu ones. Moreover Sima suggested to make some trace events stable uAPI, so tools can rely on them long term. The first patches extend and cleanup the gpu scheduler events, then add a documentation entry in drm-uapi.rst. The last 2 patches are new in v8. One is based on a suggestion from Tvrtko and gets rid of drm_sched_job::id. The other is a cleanup of amdgpu trace events to use the fence=%llu:%llu format. The drm_sched_job patches don't affect gpuvis which has code to parse the gpu_scheduler events but these events are not enabled. Changes since v8: * swapped patches 8 & 9 * rebased on drm-next Changes since v7: * uint64_t -> u64 * reworked dependencies tracing (Tvrtko) * use common name prefix for all events (Tvrtko) * dropped drm_sched_job::id (Tvrtko) Useful links: - userspace tool using the updated events: https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37 - v8: https://lists.freedesktop.org/archives/dri-devel/2025-March/496781.html Pierre-Eric Pelloux-Prayer (10): drm/debugfs: output client_id in in drm_clients_info drm/sched: store the drm client_id in drm_sched_fence drm/sched: add device name to the drm_sched_process_job event drm/sched: cleanup gpu_scheduler trace events drm/sched: trace dependencies for gpu jobs drm/sched: add the drm_client_id to the drm_sched_run/exec_job events drm/sched: cleanup event names drm: get rid of drm_sched_job::id drm/doc: document some tracepoints as uAPI drm/amdgpu: update trace format to match gpu_scheduler_trace Documentation/gpu/drm-uapi.rst | 19 ++++ drivers/accel/amdxdna/aie2_ctx.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_job.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 32 +++--- drivers/gpu/drm/drm_debugfs.c | 10 +- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- drivers/gpu/drm/imagination/pvr_job.c | 2 +- drivers/gpu/drm/imagination/pvr_queue.c | 5 +- drivers/gpu/drm/imagination/pvr_queue.h | 2 +- drivers/gpu/drm/lima/lima_gem.c | 2 +- drivers/gpu/drm/lima/lima_sched.c | 6 +- drivers/gpu/drm/lima/lima_sched.h | 3 +- drivers/gpu/drm/msm/msm_gem_submit.c | 8 +- drivers/gpu/drm/nouveau/nouveau_sched.c | 3 +- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- drivers/gpu/drm/panthor/panthor_drv.c | 3 +- drivers/gpu/drm/panthor/panthor_mmu.c | 2 +- drivers/gpu/drm/panthor/panthor_sched.c | 5 +- drivers/gpu/drm/panthor/panthor_sched.h | 3 +- .../gpu/drm/scheduler/gpu_scheduler_trace.h | 100 +++++++++++++----- drivers/gpu/drm/scheduler/sched_entity.c | 16 ++- drivers/gpu/drm/scheduler/sched_fence.c | 4 +- drivers/gpu/drm/scheduler/sched_internal.h | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 11 +- .../gpu/drm/scheduler/tests/mock_scheduler.c | 2 +- drivers/gpu/drm/v3d/v3d_submit.c | 2 +- drivers/gpu/drm/xe/xe_sched_job.c | 3 +- include/drm/gpu_scheduler.h | 13 ++- 31 files changed, 184 insertions(+), 97 deletions(-)