mbox series

[0/4] Add dt-bindings and dtsi changes for CAMSS on IQ-9075-evk

Message ID 20250514-rb8_camera-v1-0-bf4a39e304e9@quicinc.com
Headers show
Series Add dt-bindings and dtsi changes for CAMSS on IQ-9075-evk | expand

Message

Wenmeng Liu May 14, 2025, 2:40 a.m. UTC
This series adds dt-bindings and dtsi for CAMSS on IQ-9075-evk.

QCS9075 is compatible IoT-industrial grade variant of SA8775p SoC.

The IQ-9075-evk board has 4 CSI interfaces.
This change only enables the third camera interface with the imx577 sensor.

---
This patch series depends on patch series:
https://lore.kernel.org/all/20250429054906.113317-1-quic_wasimn@quicinc.com

https://lore.kernel.org/all/20250210155605.575367-1-quic_vikramsa@quicinc.com
https://lore.kernel.org/all/20250210162843.609337-1-quic_vikramsa@quicinc.com
---

Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>

---
Wenmeng Liu (4):
      dt-bindings: media: camss: Add supplies for qcom,sa8775p-camss binding
      dt-bindings: media: Add sa8775p cci dt binding
      arm64: dts: qcom: sa8775p: Add CCI definitions
      arm64: dts: qcom: qcs9075-rb8: Enable IMX577 camera sensor

 .../devicetree/bindings/i2c/qcom,i2c-cci.yaml      |   2 +
 .../bindings/media/qcom,sa8775p-camss.yaml         |  13 +
 arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dts   | 110 ++++++
 arch/arm64/boot/dts/qcom/sa8775p.dtsi              | 400 +++++++++++++++++++++
 4 files changed, 525 insertions(+)
---
base-commit: c77f0b49aeee66efb17322db16934f21c7eacb81
change-id: 20250514-rb8_camera-7694fd69b448

Best regards,

Comments

Bryan O'Donoghue May 14, 2025, 5:28 a.m. UTC | #1
On 14/05/2025 03:40, Wenmeng Liu wrote:
> Add supplies bindings for qcom,sa8775p-camss.
> 
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
>   .../devicetree/bindings/media/qcom,sa8775p-camss.yaml       | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> index 083e1193c474265edb445dd30717360de57ff986..aba46c0bc11faa062199f563602494bd2f62367c 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> @@ -125,6 +125,14 @@ properties:
>       items:
>         - const: top
>   
> +  vdda-phy-supply:
> +    description:
> +      Phandle to a regulator supply to PHY core block.
> +
> +  vdda-pll-supply:
> +    description:
> +      Phandle to 1.8V regulator supply to PHY refclk pll block.
> +
>     ports:
>       $ref: /schemas/graph.yaml#/properties/ports
>   
> @@ -164,6 +172,8 @@ required:
>     - iommus
>     - power-domains
>     - power-domain-names
> +  - vdda-phy-supply
> +  - vdda-pll-supply
>   
>   additionalProperties: false
>   
> @@ -343,6 +353,9 @@ examples:
>               power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>;
>               power-domain-names = "top";
>   
> +            vdda-phy-supply = <&vreg_l4a_0p88>;
> +            vdda-pll-supply = <&vreg_l1c_1p2>;
> +
>               ports {
>                   #address-cells = <1>;
>                   #size-cells = <0>;
> 

You can drop this from your next submission.

We are fixing the PHY schema to give a 1:1 relationship between PHYs and 
their associated rails.

---
bod
Bryan O'Donoghue May 14, 2025, 5:37 a.m. UTC | #2
On 14/05/2025 03:40, Wenmeng Liu wrote:
> Qualcomm SA8775P SoC contains 4 Camera Control Interface controllers.
> 
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 268 ++++++++++++++++++++++++++++++++++
>   1 file changed, 268 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9a8f60db87b1afdf16cf55eb2e95f83eb45803a5..a867694b15b307344b72041e972bae6e7543a98f 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -3941,6 +3941,162 @@ videocc: clock-controller@abf0000 {
>   			#power-domain-cells = <1>;
>   		};
>   
> +		cci0: cci@ac13000 {
> +			compatible = "qcom,sa8775p-cci", "qcom,msm8996-cci";
> +			#address-cells = <1>;
> +			#size-cells = <0>;

The ordering here is not consistent with upstream. Please stick to that 
for your examples:

arch/arm64/boot/dts/qcom/sc8280xp.dtsi
Documentation/devicetree/bindings/dts-coding-style.rst

---
bod