| Message ID | 20250524115144.3832748-1-olivia.wen@mediatek.com |
|---|---|
| Headers | show |
| Series | Add MediaTek ISP7 Image Syatem driver | expand |
On Sat, 24 May 2025 19:49:53 +0800, Olivia Wen wrote: > Introduce more Image System (ImgSys) components present in MT8188. > > Signed-off-by: Olivia Wen <olivia.wen@mediatek.com> > --- > .../bindings/media/mediatek,imgsys.yaml | 180 ++++++++++++++++++ > 1 file changed, 180 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,imgsys.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,imgsys.example.dtb: imgsys-fw@15000000 (mediatek,mt8188-isp-imgsys): reg: [[0, 352321536], [0, 16384], [0, 352452608], [0, 65536], [0, 352583680], [0, 65536], [0, 358875136], [0, 65536], [0, 353370112], [0, 65536], [0, 353697792], [0, 65536], [0, 354484224], [0, 65536], [0, 357629952], [0, 65536], [0, 354418688], [0, 65536], [0, 357564416], [0, 65536], [0, 358612992], [0, 65536], [0, 354549760], [0, 256], [0, 355598336], [0, 65536], [0, 357695488], [0, 256], [0, 358744064], [0, 256], [0, 353435648], [0, 256], [0, 353566720], [0, 256]] is too long from schema $id: http://devicetree.org/schemas/media/mediatek,imgsys.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250524115144.3832748-2-olivia.wen@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Dear Maintainers, I am pleased to submit this patch series that introduces the MediaTek ISP7 Image System driver. This series consists of ten patches that collectively add support for various components and functionalities of the ISP7 architecture. The patches include device tree bindings, user API definitions, V4L2 flow support, LARB device integration, CMDQ support, SCP support, and image processing flows. MediaTek's Image System (ImgSys), also known as ISP Pass2, is a memory-to-memory hardware device designed for advanced image processing tasks. ImgSys includes multiple hardware components such as TRAW, DIP, PQDIP, ME, and WPE. - **TRAW (Tile RAW)**: Provides multiple downscaled resizers for multi-scale noise reduction and supports RAW/RGB format conversion. - **DIP (Digital Image Processing) and PQDIP (Picture Quality DIP)**: Supports temporal and spatial noise reduction (TNR/SNR), edge enhancement (EE), sharpness (SHP), image scaling, and rotation. - **ME (Motion Estimation)**: Supports motion estimation between consecutive frames. - **WPE (Warping Engine)**: Handles image warping and de-warping processes. ImgSys utilizes Multi-Frame Combined Noise Reduction (MCNR) technology to enhance image quality. Below is a simplified architecture of the ImgSys driver: User -> V4L2 Framework -> ImgSys Driver -> SCP (It packages the hardware settings into commands) -> ImgSys Driver -> CMDQ (The packaged commands are sent to the hardware via GCE) -> Hardware Thease patches are base on linux-next/master, tag: next-20250523 Thank you for reviewing these patches. Olivia Wen (10): dt-bindings: media: Add MediaTek mt8188 ImgSys components dt-bindings: media: Add MT8188 ImgSys's LARB uapi: linux: Add MediaTek Imgsys user API media: mediatek: isp: Add V4L2 flow support for ImgSys driver media: mediatek: isp: Add the Imgsys LARBs device media: mediatek: isp: Add module operations structure for ImgSys media: mediatek: isp: Add CMDQ support for ImgSys driver media: mediatek: isp: Add SCP support for ImgSys driver media: mediatek: isp: Add image processing flow media: mediatek: isp: Add normal data dump flow .../bindings/media/mediatek,imgsys-larbs.yaml | 75 + .../bindings/media/mediatek,imgsys.yaml | 180 ++ drivers/media/platform/mediatek/Kconfig | 1 + drivers/media/platform/mediatek/Makefile | 1 + drivers/media/platform/mediatek/isp/Kconfig | 23 + .../platform/mediatek/isp/isp_7x/Makefile | 6 + .../mediatek/isp/isp_7x/imgsys/Makefile | 25 + .../imgsys/modules/mtk_dip_v4l2_vnode.h | 594 +++++ .../isp_7x/imgsys/modules/mtk_imgsys-dip.c | 162 ++ .../isp_7x/imgsys/modules/mtk_imgsys-dip.h | 21 + .../isp/isp_7x/imgsys/modules/mtk_imgsys-me.c | 65 + .../isp/isp_7x/imgsys/modules/mtk_imgsys-me.h | 30 + .../isp_7x/imgsys/modules/mtk_imgsys-pqdip.c | 165 ++ .../isp_7x/imgsys/modules/mtk_imgsys-pqdip.h | 20 + .../isp_7x/imgsys/modules/mtk_imgsys-traw.c | 120 ++ .../isp_7x/imgsys/modules/mtk_imgsys-traw.h | 20 + .../isp_7x/imgsys/modules/mtk_imgsys-wpe.c | 176 ++ .../isp_7x/imgsys/modules/mtk_imgsys-wpe.h | 20 + .../isp_7x/imgsys/modules/mtk_me_v4l2_vnode.h | 386 ++++ .../imgsys/modules/mtk_pqdip_v4l2_vnode.h | 149 ++ .../imgsys/modules/mtk_traw_v4l2_vnode.h | 371 ++++ .../imgsys/modules/mtk_wpe_v4l2_vnode.h | 317 +++ .../mediatek/isp/isp_7x/imgsys/mtk-img-ipi.h | 151 ++ .../isp/isp_7x/imgsys/mtk_header_desc.h | 129 ++ .../isp/isp_7x/imgsys/mtk_imgsys-cmdq-plat.h | 502 +++++ .../isp/isp_7x/imgsys/mtk_imgsys-cmdq.c | 690 ++++++ .../isp/isp_7x/imgsys/mtk_imgsys-cmdq.h | 29 + .../isp/isp_7x/imgsys/mtk_imgsys-dev.c | 299 +++ .../isp/isp_7x/imgsys/mtk_imgsys-dev.h | 570 +++++ .../isp/isp_7x/imgsys/mtk_imgsys-formats.c | 139 ++ .../isp/isp_7x/imgsys/mtk_imgsys-formats.h | 72 + .../isp/isp_7x/imgsys/mtk_imgsys-gce_work.c | 86 + .../isp/isp_7x/imgsys/mtk_imgsys-gce_work.h | 37 + .../isp_7x/imgsys/mtk_imgsys-module_common.h | 102 + .../isp_7x/imgsys/mtk_imgsys-module_main.c | 187 ++ .../isp_7x/imgsys/mtk_imgsys-module_main.h | 17 + .../isp/isp_7x/imgsys/mtk_imgsys-module_ops.h | 64 + .../isp_7x/imgsys/mtk_imgsys-ndd_debugfs.c | 342 +++ .../isp_7x/imgsys/mtk_imgsys-ndd_debugfs.h | 64 + .../isp/isp_7x/imgsys/mtk_imgsys-of.c | 39 + .../isp/isp_7x/imgsys/mtk_imgsys-of.h | 58 + .../isp/isp_7x/imgsys/mtk_imgsys-scp.c | 349 +++ .../isp/isp_7x/imgsys/mtk_imgsys-scp.h | 194 ++ .../isp/isp_7x/imgsys/mtk_imgsys-sys.c | 556 +++++ .../isp/isp_7x/imgsys/mtk_imgsys-sys.h | 50 + .../isp/isp_7x/imgsys/mtk_imgsys-v4l2.c | 1919 +++++++++++++++++ .../isp/isp_7x/imgsys/mtk_imgsys-vnode_id.h | 100 + .../isp/isp_7x/imgsys/mtk_imgsys-work_buf.c | 113 + .../isp/isp_7x/imgsys/mtk_imgsys-work_buf.h | 55 + .../isp/isp_7x/imgsys/mtk_imgsys_v4l2_vnode.h | 135 ++ include/uapi/linux/mtkisp_imgsys.h | 215 ++ 51 files changed, 10190 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/mediatek,imgsys-larbs.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,imgsys.yaml create mode 100644 drivers/media/platform/mediatek/isp/Kconfig create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/Makefile create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/Makefile create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_dip_v4l2_vnode.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-dip.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-dip.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-me.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-me.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-pqdip.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-pqdip.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-traw.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-traw.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-wpe.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_imgsys-wpe.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_me_v4l2_vnode.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_pqdip_v4l2_vnode.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_traw_v4l2_vnode.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/modules/mtk_wpe_v4l2_vnode.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk-img-ipi.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_header_desc.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-cmdq-plat.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-cmdq.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-cmdq.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-dev.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-dev.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-formats.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-formats.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-gce_work.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-gce_work.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-module_common.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-module_main.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-module_main.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-module_ops.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-ndd_debugfs.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-ndd_debugfs.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-of.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-of.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-scp.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-scp.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-sys.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-sys.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-v4l2.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-vnode_id.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-work_buf.c create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys-work_buf.h create mode 100644 drivers/media/platform/mediatek/isp/isp_7x/imgsys/mtk_imgsys_v4l2_vnode.h create mode 100644 include/uapi/linux/mtkisp_imgsys.h