mbox series

[0/6] media: replace some chars on C files

Message ID cover.1622646256.git.mchehab+huawei@kernel.org
Headers show
Series media: replace some chars on C files | expand

Message

Mauro Carvalho Chehab June 2, 2021, 3:05 p.m. UTC 
There are a couple of non-ASCII characters inside the media code
that aren't agregating anything useful besides what's provided
by their ASCII equivalents. So, let's replace those.

Mauro Carvalho Chehab (6):
  media: gspca: ov519: replace RIGHT SINGLE QUOTATION MARK
  media: rtl28xxu: replace a NO-BREAK SPACE character
  media: allegro-dvt: avoid EN DASH char
  media: saa7134: drop a NO-BREAK SPACE
  media: rc: ite-cir: replace some an EN DASH
  media: pci: tw5864: avoid usage of some characters

 drivers/media/pci/saa7134/saa7134-tvaudio.c   |  2 +-
 drivers/media/pci/tw5864/tw5864-reg.h         | 62 +++++++++----------
 drivers/media/platform/allegro-dvt/nal-h264.c |  2 +-
 drivers/media/platform/allegro-dvt/nal-hevc.c |  2 +-
 drivers/media/rc/ite-cir.h                    |  2 +-
 drivers/media/usb/dvb-usb-v2/rtl28xxu.c       |  2 +-
 drivers/media/usb/gspca/ov519.c               |  2 +-
 7 files changed, 37 insertions(+), 37 deletions(-)

Comments

Michael Tretter June 3, 2021, 6:33 a.m. UTC | #1 
On Wed, 02 Jun 2021 17:05:20 +0200, Mauro Carvalho Chehab wrote:
> While there's nothing wrong with EN DASH on C code, this probably

> came from some cut-and paste from an ITU-T table.

> It sounds better to just an HYPHEN here.

> 

> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> ---

>  drivers/media/platform/allegro-dvt/nal-h264.c | 2 +-

>  drivers/media/platform/allegro-dvt/nal-hevc.c | 2 +-

>  2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/media/platform/allegro-dvt/nal-h264.c b/drivers/media/platform/allegro-dvt/nal-h264.c

> index 94dd9266d850..a02095eb3fcf 100644

> --- a/drivers/media/platform/allegro-dvt/nal-h264.c

> +++ b/drivers/media/platform/allegro-dvt/nal-h264.c

> @@ -25,7 +25,7 @@

>  #include "nal-rbsp.h"

>  

>  /*

> - * See Rec. ITU-T H.264 (04/2017) Table 7-1 – NAL unit type codes, syntax

> + * See Rec. ITU-T H.264 (04/2017) Table 7-1 -- NAL unit type codes, syntax


This should be a single instead of a double hyphen.

With that fixed

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>


Michael

>   * element categories, and NAL unit type classes

>   */

>  enum nal_unit_type {

> diff --git a/drivers/media/platform/allegro-dvt/nal-hevc.c b/drivers/media/platform/allegro-dvt/nal-hevc.c

> index 5db540c69bfe..15a352e45831 100644

> --- a/drivers/media/platform/allegro-dvt/nal-hevc.c

> +++ b/drivers/media/platform/allegro-dvt/nal-hevc.c

> @@ -25,7 +25,7 @@

>  #include "nal-rbsp.h"

>  

>  /*

> - * See Rec. ITU-T H.265 (02/2018) Table 7-1 – NAL unit type codes and NAL unit

> + * See Rec. ITU-T H.265 (02/2018) Table 7-1 - NAL unit type codes and NAL unit

>   * type classes

>   */

>  enum nal_unit_type {

> -- 

> 2.31.1

> 

>