From patchwork Tue Sep 25 11:19:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 11716 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 1797523EFB for ; Tue, 25 Sep 2012 11:22:45 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id BF4EDA184DD for ; Tue, 25 Sep 2012 11:22:44 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so12506083iej.11 for ; Tue, 25 Sep 2012 04:22:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=iwXK/ENJbNSuF1XrIuDvWHGNpuX30TEM0t+iuFaxOso=; b=i8IuPa2s1bqvlK6zkDNnymVpqW8AeFM7sXQv8nZ7Pmc2OhJcph2dbNRN0ngzxwgA9l SkYXnCr7SDUqIa4zrSLJ1QM6tILxq0REH//lcXwYAi9RT2ZLZ6cXzTRRPNPtdNuqF0Sn ACpQlwfG5eZAuZiv7m0e4/qVaoDfX06jPXq92nKH50JCDPeDshJ31fyMZ85g3uZX7yZl q4ON33F1Jhmiu6nsFmeVuHUzSV/gti4E70igAgou78b40FrNMO1fyDlM/VB3Yfkg3I3C WgOXpOYUN5w7W8tqWs+uGsCiXWBrbto0DA2M3GJNdFFZah/vp9RZ4DGcIP4f6aPzp1df kY7g== Received: by 10.50.217.229 with SMTP id pb5mr7901822igc.28.1348572164449; Tue, 25 Sep 2012 04:22:44 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp288549igc; Tue, 25 Sep 2012 04:22:44 -0700 (PDT) Received: by 10.68.222.167 with SMTP id qn7mr44570296pbc.98.1348572163840; Tue, 25 Sep 2012 04:22:43 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id e1si11888paz.64.2012.09.25.04.22.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 25 Sep 2012 04:22:43 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by pbcwz7 with SMTP id wz7so330520pbc.37 for ; Tue, 25 Sep 2012 04:22:43 -0700 (PDT) Received: by 10.68.136.229 with SMTP id qd5mr12733776pbb.154.1348572163551; Tue, 25 Sep 2012 04:22:43 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id uh7sm197087pbc.35.2012.09.25.04.22.40 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 25 Sep 2012 04:22:42 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH] [media] s5p-fimc: Fix incorrect condition in fimc_lite_reqbufs() Date: Tue, 25 Sep 2012 16:49:04 +0530 Message-Id: <1348571944-7139-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQl9MQo434Zezwt27qzbQLoY6AG+IZ/Z09b40QxdPz7LUvN25jgycDYCahqMhmP17iMaI2ps When precedence rules are applied, the condition always evaluates to be false which was not the intention. Adding the missing braces for correct evaluation of the expression and subsequent functionality. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-fimc/fimc-lite.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/fimc-lite.c b/drivers/media/platform/s5p-fimc/fimc-lite.c index 9289008..20e5e24 100644 --- a/drivers/media/platform/s5p-fimc/fimc-lite.c +++ b/drivers/media/platform/s5p-fimc/fimc-lite.c @@ -825,7 +825,7 @@ static int fimc_lite_reqbufs(struct file *file, void *priv, reqbufs->count = max_t(u32, FLITE_REQ_BUFS_MIN, reqbufs->count); ret = vb2_reqbufs(&fimc->vb_queue, reqbufs); - if (!ret < 0) + if (!(ret < 0)) fimc->reqbufs_count = reqbufs->count; return ret;