From patchwork Thu Jun 3 07:15:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen \(ThunderTown\)" X-Patchwork-Id: 453223 Delivered-To: patch@linaro.org Received: by 2002:a02:c735:0:0:0:0:0 with SMTP id h21csp36337jao; Thu, 3 Jun 2021 00:15:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFAiMxXSxr7K4yLw5BvEAUuWbZhY/Gt0cNC8x6jlJrFkTGEc1zz10C3Hhome8RXmZ+rakE X-Received: by 2002:a17:906:a12:: with SMTP id w18mr31347933ejf.92.1622704541708; Thu, 03 Jun 2021 00:15:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622704541; cv=none; d=google.com; s=arc-20160816; b=gh+UCRoZtS0YIIfWrjhIzeNolrLFFGz8G3qbf97SJS89VzDxOIM6dOIq+HH9sbwS4/ Xgp5WHCkrCvdhdh2ObPmDgJn38mzQ2yo2F/dsYqB8ndso3kF7GnZP8yOdMmDxNS/5FEJ onlQnuP5r3Qit6GTrAeDBgdNTHA1XjQdcxz6DaQY40wvkU5+E4FPMEfWVp931AI+eVTP tp88xA6ilNwF+E/Q5DSsKup3ro9bz+4J9GasgjFRw8MmmvgsrSCA/yZaUNFG3/SbGdOh BRPKjfChNca5jbboA9yMGJE5i7Wu4r4DfkWKx7lXJPnhRbzxZkk15Znclz/fXcSNpoVv Q+ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=cb74e9WTNViVaf6dX/VAvYBRbEsPrLLRSRLnZ24K7h8=; b=pw4E612D5CsDLqvtySKIDpPCo/sSRg9AFIvkaAZrcs2GeDNEif2MbXftQZo0cNEY9T 0V0vdi+wxnE8K2POTz0jk10wK1D/WjJhVzEBM84k7WSoj0SKVgWt4FpAo+CUbARYobFh 21yl4ra/X297uSq4v3/KK9nU0DMdTS1DMUatVYpTxXFg45c36m+H8XAhUT7tAU3fG59j FH44QvXdIHP7EtC4mI7U71wIQLIzsHpv3RbJjw1HhcV5bfB56xMPbmL5bsa8qCpyjVtD OIZZUsGhsbUtnYKB0Yhkx2OzzhcDg0av4GusKb9EmugHbPETMSEaSjtbgf1yHGhQHT8s i8Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r18si1749701edd.372.2021.06.03.00.15.41; Thu, 03 Jun 2021 00:15:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbhFCHRW (ORCPT + 4 others); Thu, 3 Jun 2021 03:17:22 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:3399 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhFCHRV (ORCPT ); Thu, 3 Jun 2021 03:17:21 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4FwcX647KXz68DW; Thu, 3 Jun 2021 15:11:50 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 15:15:35 +0800 Received: from thunder-town.china.huawei.com (10.174.177.72) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 15:15:34 +0800 From: Zhen Lei To: Pavel Machek , Sakari Ailus , Mauro Carvalho Chehab , linux-media CC: Zhen Lei Subject: [PATCH 1/1] media: i2c: et8ek8: use DEVICE_ATTR_RO() helper macro Date: Thu, 3 Jun 2021 15:15:29 +0800 Message-ID: <20210603071529.11544-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Use DEVICE_ATTR_RO() helper macro instead of DEVICE_ATTR(), which is simpler and more readable. Due to the name of the read function of the sysfs attribute is normalized, there is a natural association. Signed-off-by: Zhen Lei --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.26.0.106.g9fadedd Acked-by: Pavel Machek diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c index bb3eac5e005e4c2..fc3a3869a79d1d6 100644 --- a/drivers/media/i2c/et8ek8/et8ek8_driver.c +++ b/drivers/media/i2c/et8ek8/et8ek8_driver.c @@ -1234,8 +1234,7 @@ static int et8ek8_dev_init(struct v4l2_subdev *subdev) * sysfs attributes */ static ssize_t -et8ek8_priv_mem_read(struct device *dev, struct device_attribute *attr, - char *buf) +priv_mem_show(struct device *dev, struct device_attribute *attr, char *buf) { struct v4l2_subdev *subdev = dev_get_drvdata(dev); struct et8ek8_sensor *sensor = to_et8ek8_sensor(subdev); @@ -1248,7 +1247,7 @@ et8ek8_priv_mem_read(struct device *dev, struct device_attribute *attr, return ET8EK8_PRIV_MEM_SIZE; } -static DEVICE_ATTR(priv_mem, 0444, et8ek8_priv_mem_read, NULL); +static DEVICE_ATTR_RO(priv_mem); /* -------------------------------------------------------------------------- * V4L2 subdev core operations