From patchwork Tue Aug 30 10:34:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 601400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226EDECAAD4 for ; Tue, 30 Aug 2022 10:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiH3Keg (ORCPT ); Tue, 30 Aug 2022 06:34:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbiH3Kef (ORCPT ); Tue, 30 Aug 2022 06:34:35 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29602AA4C9 for ; Tue, 30 Aug 2022 03:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661855675; x=1693391675; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gHCEbQfpuFj8LuadWo1XstsLiInGv3iwv3fi+JQq5FY=; b=RDjddFSauczDqyXGkF9lD5PiZpUioOS83iCRpJjbYTHXt6u6QPr2HyV/ ronEiR8/lFzbmMlc8aDZOZTiN/uBHZwv/UVT6aczOoGUWFGdLt0ovwVF5 6wCRueaewkmY7NLOiXOQJHs3ojY5dvt6lBtUbRx2iKP9luptZf99u7zZg aLe1f0/dfq1rh5VJV382A+D0Cpjl5n6iETeLq5uwCjKuTvBvHeHAyhwWk 6hn9Vf1gb4tbOtNUrCSkdHUo49M3bsnztHj8JiTTtebwNnw2kEUT5qFmx RjRbv9031xKasn96BFpBv3+xgtzRakAuFE/RpmVIeEGM3MzNOjITayXqU Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="274889259" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="274889259" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:34:34 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="611657612" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:34:33 -0700 Received: from punajuuri.localdomain (punajuuri.localdomain [192.168.240.130]) by paasikivi.fi.intel.com (Postfix) with ESMTP id CD9CC200DA; Tue, 30 Aug 2022 13:34:31 +0300 (EEST) Received: from sailus by punajuuri.localdomain with local (Exim 4.94.2) (envelope-from ) id 1oSya8-00DdGj-B7; Tue, 30 Aug 2022 13:34:56 +0300 From: Sakari Ailus To: linux-media@vger.kernel.org Cc: =?utf-8?q?Krzysztof_Ha=C5=82asa?= Subject: [PATCH 1/1] ar0521: Fix return value check in writing initial registers Date: Tue, 30 Aug 2022 13:34:56 +0300 Message-Id: <20220830103456.3249168-1-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The return value from register writes is ignored apart from the last value. Fix this. Reported-by: kernel test robot Signed-off-by: Sakari Ailus Acked-by: Krzysztof Hałasa --- drivers/media/i2c/ar0521.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index 9e90b02b15e36..a586e0fc0ea3f 100644 --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -755,11 +755,12 @@ static int ar0521_power_on(struct device *dev) gpiod_set_value(sensor->reset_gpio, 0); usleep_range(4500, 5000); /* min 45000 clocks */ - for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) + for (cnt = 0; cnt < ARRAY_SIZE(initial_regs); cnt++) { ret = ar0521_write_regs(sensor, initial_regs[cnt].data, initial_regs[cnt].count); if (ret) goto off; + } ret = ar0521_write_reg(sensor, AR0521_REG_SERIAL_FORMAT, AR0521_REG_SERIAL_FORMAT_MIPI |