From patchwork Sun Mar 26 14:32:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 667274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09B2DC77B61 for ; Sun, 26 Mar 2023 14:34:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbjCZOe3 (ORCPT ); Sun, 26 Mar 2023 10:34:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232518AbjCZOdD (ORCPT ); Sun, 26 Mar 2023 10:33:03 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3C2726BC for ; Sun, 26 Mar 2023 07:32:56 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQT-0000ZW-DI; Sun, 26 Mar 2023 16:32:53 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQR-006rhv-Ev; Sun, 26 Mar 2023 16:32:51 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQQ-0088bF-I0; Sun, 26 Mar 2023 16:32:50 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Almeida , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 115/117] media: visl-core: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:32:22 +0200 Message-Id: <20230326143224.572654-118-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1597; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=xBgPjDoBOcooElSDzrMumYjMfNIa+WX+wsDCUOqM0/Y=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFdUM8liaPKb9n7HqWKF/DqCDGjYhm59eFAVh PxUETmIs9GJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBXVAAKCRCPgPtYfRL+ ThByCACYmhC0qLmdE9neBqCuYkczrRhIGj5Uf7Y0pWC6Zy4r56HnCbdP2Q3eL5781vTVZsAr1Ze NOugTULIz8DLq2YAhSf7dLgOnUp6BBFkech98sGpHN9AzUZOyPXuv8jNNZjs8aCc4PTXRD0wn34 wQJdV4q+/BWZCFNnFpUu6CdNiJkd374InOQpSZyGAv9XBWNj5i1iWtEae4XJVWE4Gs00ztX4LHC vk01FUZoNLMAJdBX31kpUbwJOVzipK+O7RyDz3EDubWWnVw+EQStXlU+/mrsDqwIxjLYjtbqKzi CBPLuJGwnnVEj/qzT72OkzAbqDuHfzxVJwr7u/25N2pTNG0I X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/media/test-drivers/visl/visl-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c index 9cb60ab653bf..9970dc739ca5 100644 --- a/drivers/media/test-drivers/visl/visl-core.c +++ b/drivers/media/test-drivers/visl/visl-core.c @@ -480,7 +480,7 @@ static int visl_probe(struct platform_device *pdev) return ret; } -static int visl_remove(struct platform_device *pdev) +static void visl_remove(struct platform_device *pdev) { struct visl_dev *dev = platform_get_drvdata(pdev); @@ -493,13 +493,11 @@ static int visl_remove(struct platform_device *pdev) } #endif video_unregister_device(&dev->vfd); - - return 0; } static struct platform_driver visl_pdrv = { .probe = visl_probe, - .remove = visl_remove, + .remove_new = visl_remove, .driver = { .name = VISL_NAME, },