From patchwork Thu Nov 28 20:53:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 846412 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7EAB1C3F0D for ; Thu, 28 Nov 2024 20:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732827263; cv=none; b=YG3zpQWxdlEPMrhtfpVsOxtSH9W/VHKPpcXWJybdAcaMg7X1qXHhNJp0WVdj/HIItKry//6JzjEO/iAUhBXEAMTugGOma3UodxUsGO9Tmq753hHa4sww9jVZkFJmcL9rqQWnJVfxTHG8nmse4IIpnXG0OZ4HRofoAXlC0bJl2mM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732827263; c=relaxed/simple; bh=Y5C5MWAZhdZte1MeZGyGG8T5yKjM2AgYRlaA3take34=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rQUkJjJ3Nzfnd3Pyke/RM7izrCNq1PzgLHopuTu+gnpie/K9x//F1FTCFdV/hLUp43hA7/kq64cLsgqN0kCsSaipbjD8Z6wW52JFNvgARHPGzAhWBI7S+K8V1lOfVCtcWQES7i7AsdQWT88ZLsaIjNyIt7Yvec6pmWECr0+di+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Lsq7+dVf; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Lsq7+dVf" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-46694ca7de5so11917481cf.2 for ; Thu, 28 Nov 2024 12:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732827260; x=1733432060; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JxVXaAiENeJFjrFqbCn460gp3zbaHpUySHHf/yPGG+c=; b=Lsq7+dVfFMBhFcAXcKAs1wOhjBWpqYJD94BbGLRVY4N2F53tQJb0Y9ikhg9ixaHWcB 09H+bhZk38zP9Y96nrW/0lVZjiVqjLuN7HRcqlWqjnxQOrWVQm75OOCv/fqQOEA4ez0L 55vghVnlGrV7tt+lR7wRNbJbR5fRgTKOflzyc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732827260; x=1733432060; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JxVXaAiENeJFjrFqbCn460gp3zbaHpUySHHf/yPGG+c=; b=HIfyPB2SXvyEKXegzgkHiHpDVjb2K41hh7KJKzGdTs4/YTezWryegLj03pBmGylUkA jvIMdho779OMvcs+28jy1bajxpu6pNgtQw/Udem32BDvlV0rQauBn+aLS0J7Wn2a31gf K4k51GRr8Yhmw+4LyP8994d07Zz0zz3Q+e7o97dcJwj+vNpB8um7V7UFIXc9+lUMWeW5 egcey9tFf6LEtfe9ecgYkJz99NqT4/TtXR6tb3kiaXlEYxE+2ixf/ztH2rtlQM4E7F+w 6iPNGWtSrtHAD65UQylj/FkH4XeY1CRTyPeJdk5D4BDcXHVLt4w+V03nYxBNOzkHtveY C8Lg== X-Gm-Message-State: AOJu0YwpsVawMOIi8yOWiixE/opwsZrQfgIokhupENtRKeTp8NDlKPj9 6H0kPcbWWsrpBoQEpaTeBl6oTWKgWKYLhzRulzTbz9T1o23OzVWR52/7etqQUtWsPn7portyC/o = X-Gm-Gg: ASbGnctACjqJvHPOD/RItAdztDnJ/sOutRDvDs0XuT+nIDjhauzT77muUk4c+xnCgP5 /RlPr7tBKFBxNjMnZiZAVOPa3qb9suAytOtKogICBgSMI7ZpuxRxmZkZf7FlA90tPdPmPSX8pHL 8YGOeUXy7GF7OK0JJkQ2Yy9x6yNeB5jvA2hO2nuonSCpVxuI+8SUyz4GvRT5VuVzxclhkOGdGyE 0LmOcUrNlb7vK0FPTHrPwBP1Tu/xJLHFOdAod5NhmCXOF+xwN2tEdHL0tZju8+EZC0oWfhpyxv6 jc9jCTJHHMEZRA87ct+UHHgD X-Google-Smtp-Source: AGHT+IFhNqdJQHvPtm+cSgql+Cy+Vo9Zp6MGOSWpy0pWACKPy+MTjCMMkW6LxG7oUEPZLhW0sH4fEg== X-Received: by 2002:a05:622a:1392:b0:466:957c:ab22 with SMTP id d75a77b69052e-466b3647463mr118797371cf.43.1732827260407; Thu, 28 Nov 2024 12:54:20 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-466c407e6acsm9923421cf.52.2024.11.28.12.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 12:54:19 -0800 (PST) From: Ricardo Ribalda Date: Thu, 28 Nov 2024 20:53:42 +0000 Subject: [PATCH v5 2/2] media: uvcvideo: Add more logging to uvc_query_ctrl() Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241128-uvc-readless-v5-2-cf16ed282af8@chromium.org> References: <20241128-uvc-readless-v5-0-cf16ed282af8@chromium.org> In-Reply-To: <20241128-uvc-readless-v5-0-cf16ed282af8@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Sakari Ailus X-Mailer: b4 0.13.0 If we fail to query the ctrl error code there is no information on dmesg or in uvc_dbg. This makes difficult to debug the issue. Print a proper error message when we cannot retrieve the error code from the device. Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_video.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index 67f714bca417..a650d886e922 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -117,8 +117,12 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit, error = *(u8 *)data; *(u8 *)data = tmp; - if (ret != 1) + if (ret != 1) { + dev_err_ratelimited(&dev->udev->dev, + "Failed to query (%s) UVC error code control %u on unit %u: %d (exp. 1).\n", + uvc_query_name(query), cs, unit, ret); return ret < 0 ? ret : -EPIPE; + } uvc_dbg(dev, CONTROL, "Control error %u\n", error);