From patchwork Fri Feb 21 15:55:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 867301 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010037.outbound.protection.outlook.com [52.101.229.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD73215795; Fri, 21 Feb 2025 15:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740153404; cv=fail; b=ut+HonnVzlAzxo5UzxT9sFQ9yoaKrE33vgDnXUEJPtL9FP9dJAhubGbpBbX+1H5iQE9DUxxr+Xbtyp/PvgQT96IFJvqrvkd4K5eAirxtcdxxhuiNt3VLf8HrrV61V49jwF5udLtBAe4s1tU+P2B52tVqdNkn6URGvxFuFUj0bAY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740153404; c=relaxed/simple; bh=wCKCI6WSjGlgD5gbyVFS/L2vwHzB8xqFA6ZA4/OfsOs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=BdW9Ld/H+8DsJZgg4vCBFfPEEMmONZHGfpTHiI/UuroQUJVLDLHSUJ0X9Me9/MKrbh1EOKZhHNc+t4+duyk3tGNMivuhtIiXHwwIk+ZqwH1fQtW1QpZZtutj5svGSmoy3fu9b84sqy4a3gZMMH+UPa4YMpRQcSyqzBON6PN6M34= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=A6gwZ45C; arc=fail smtp.client-ip=52.101.229.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="A6gwZ45C" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mcN1/Y+k9e/+Zbh1Uqi2a7D72aqYi+Km7lV6xmVa/3VsdMyIF8xX9iSynm/yZD4PyAXoqZeuraDaq8m41Cpoz8RubE/si5GMpOIAj7Hf/eRQlu8UGChbUgIEBtvOptcx6+9i+0BG9Hy3GHn/VDOqtD1OUswnI5J5nCDMfK+Jxu3TijEoju1cIMnKfJVS30her4fAe2Wbta9/xYsqj+qkWSS306VHVdnQWzrelkIjhfYHochRi/DHIoniZJB4e3C6SRbAbb9Xdw/CSVE2R4T1QHk4zB80qBWDoqLYwtoFmAXSdtJcJfP3jgJ+9YTZzMckCRAPdl7bVoejpUIjb+vS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fkQce5Zi/NDVlO/Bx5ct4uCZbxUGkg1aS+8xKlpn1G8=; b=pOMP9imMQQFaGBb1hqUxHsH6RxqCxLpH5JNJ7wqxk9BFwy5PgF5HSZwOKgJw1dPwqcODy2R9s+8qtoJ9fx7HYepKGcYYx2oR2dwHaBfRieWSMDrpz4TzumbmkVOYOTICo22OwWiRexjbWWzmomraoTVJPhtKg+Ck0cfWdEA0iJNr0GQbeah82CdlxYcQRc4cktBmQ0sj9I4zGzwMBvSxUVCFTMzLw/iQ539G9zsPU+OGADg48mvM+WslN5sac3GpdKWmje1qCeNxHVe/v06mtYeqxaG6GfC7j1TaClqTNbxX56rOcLuf3QveeX6nHWddCLnD5PwpOXNVqbLSKH0Lkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkQce5Zi/NDVlO/Bx5ct4uCZbxUGkg1aS+8xKlpn1G8=; b=A6gwZ45CAsnN9doKjIl8j5KCIs25ONhvgWFwEXGmcKykO/1IyJM0LOFsoTCx93qyia+1JLktVh8net5kCtlOHwmqcvORVLRoF+jVDKhBlzvMFTAhPCddABqSOOouiaxs0SiEopQ6DCRvIFfBcdF27WXAzCAoqXEtyxj60V+rcN0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) by TYCPR01MB6238.jpnprd01.prod.outlook.com (2603:1096:400:7d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.17; Fri, 21 Feb 2025 15:56:37 +0000 Received: from OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3]) by OS9PR01MB13950.jpnprd01.prod.outlook.com ([fe80::244d:8815:7064:a9f3%5]) with mapi id 15.20.8466.016; Fri, 21 Feb 2025 15:56:37 +0000 From: Tommaso Merciai To: tomm.merciai@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, Tommaso Merciai , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Hans Verkuil , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/18] media: rzg2l-cru: csi2: Use devm_pm_runtime_enable() Date: Fri, 21 Feb 2025 16:55:19 +0100 Message-Id: <20250221155532.576759-6-tommaso.merciai.xr@bp.renesas.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250221155532.576759-1-tommaso.merciai.xr@bp.renesas.com> References: <20250221155532.576759-1-tommaso.merciai.xr@bp.renesas.com> X-ClientProxiedBy: FR0P281CA0260.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::17) To OS9PR01MB13950.jpnprd01.prod.outlook.com (2603:1096:604:35e::5) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS9PR01MB13950:EE_|TYCPR01MB6238:EE_ X-MS-Office365-Filtering-Correlation-Id: e2213e12-3806-444c-6d19-08dd529052c3 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: GgNcYPI3DX4lRyMfrllzDtvZQlg8e9zIu5CXI8lNv88bJKs6ia8DIzXqArtE5tHkUNN9T4CnfGbEdFxdoPyE8TT+Qk5Y83iomy1XGK9CgkIZGd98pSduahnJDFUqzhksAl8Gc1EnzgXtvvW4QYxitnNuuKW8D+w5L5B2oLEuns6fC8itWwSd9ZPYvhGS1UA09NkpPe2L1+LYHyqOtyG/aCtCJxcdzyQVplVrFyU2wh/lwICwXHaamsmKnIk1LB57qAfDGYUPNVb9oxav9q/WqbDS7mtiIVKOHGsggdVY3PXhOueX887kkOqjwXVm9ObPeKCY/9qZZN+WEX4j5k758VRlVxHJvVm4/dDO2soHPtuy1ipRBGwGA7GMlC3Qw4KrVBC1ryl406kPY9xVQTo9OEWhiQpfTn0v+JdTdGTfPfTFpV3lxwuPL4zhysXja9KVilEwXYH7kff+6La25Sd2Zri4looBZk2BV/Xfr2AKk0IlIhgTCJnpu4r74joqDsqpzZjfwbKj+wa59AylDXeTe1BupZ6MwUuHV8HO5YtxIgrLYwWdVwSWpaERgB82CCskpPqPtoTw0edvinRzz85WiSeUpFByX38071f2zqkeyjY+0G1f+q862BvmfIyV3tpeKSuL8BPshkFiXFZt6/lZ65x++3ekHBR2KNZbB8gkFi/vnDkSsMgF+deKIz9VRN54qOC6deSFvL2eprK83PYUA7L+zoyqApf5HzbOknRHM0UWabv5qjC+OhvLNoXErbpAEpbcxhGrxxEhfwTSyZ+Gjw5a7yhfa5NEFtgBiFFqoAgF3noAj/aHwTJL9qU0znnWYVYLQpMR68zRZXzPtj8ODkGR/kLNkO5TJq/FuRUWJVQ9LG203P1H4zdVUyIcfWA8yTtX1kci4VEO9dOmDrft5qqIupxWFIByx8Z7FHd0E0QDkyMlwiKWjCT25UAF1S8ynQF/s5cgpTw/MDdydRIB686csXQc/KuCeFpog5jiW95oKLHtnfHPu9u6b4CVOxzqJrq7U5sPlGpPwrYOqir3atlG8XBkJR8C9lpnTiDB5mFDHATNCVtfGLYklWz8O2hUHNrQwJ7w5WY8NC6mO5W0AhWni+5GOJveuAu7pnb75L3MQrHuyPqLkFiB/7JzsmDN6G8YdAEm+YRZ3/R78joJPNjDPqqHQXkdKR1lWYE2X7tFU5XPFeUb2Ftf2vHKMPPKgTWxkLCjHoL1DMkq13wZkVx5vAcx6ae66tRAmOQrNbf8zuGAr27azLdlNLKXRUjBhmmNVeQyQA0w9+r3e2NM6qz+KkObIkbjiUEdV03kyWrLht3a7hgUVLBfFU05nVTXbLC7WJsOb2CKFGm9JbLZi89MGnPQVXsmXyGh4wA1UMDBnfTAhbuy8aTFLyjNuf8Ewfg+lx7YUowzY9UNXYSAg+uKWPKUlFkCR/C/n0neC6Sln+5zrqVQ5tP14v/zKCVq X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS9PR01MB13950.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kMvrB2VrEERxD35X5ZE8w0Fjz9ES1VMXocpzx2D0D7BOSagw7DprZSbzWNWfoi+8SSVFjTGd7aNZgQTx79Ljx+U1BDN8/nYNDQooXCpU1wJ4MYgBeyvQtEEnZqVwmXMkLmAK8hahn4uP7z5OkgVtWc9/UFvDyi64XqU4HZ7PV6UzYIW43/FkL/vcdJAgABzKGVpSozFSR7ms+V3IsAvn0MQgrm0lupeQVoAlDWvLXC/iv1YYp3ZugEzZavI/1dsh5UiyLVHl/KweCxIG3CqAGjeVQ4A9xDLUuqH6pfBgixFqyeoc4EMyISXgK3aTx2b/nSXA+ntOoaby8Kl5PEK3dLHy4T627s1Vx2mXwaWgs1On58ua9DDYMOXCnrNMhYU459iRGzfq1CplIbGRlc+712Drh08jBo4oFwigVUpTiGJbhyQsYv3u9Ev7qu5iVJbRYiE/CccRtUMjDFU1zMgGKQbl/TSaCztpvO4apV7FaUdClCRM5Ks398C5sixcjUXoqQ1A3cmUmWCxqOza31lauue+/FOD7JHprYxgVYb771B9Ip2YJKNXZ7yjHRx5TVh9tDC93DaLz4Qpg3im9RNdeYJ/R0d8xNRFeTUDEwflm84yQFk3FUdjzGQuEVsrskLKFXXtv/LTrr2svfBhaYle23nAWOldbM0WiTkM6C2LSwQGbZKCDu6ikXuloaYMdwrLuyKdSv7uNzWG85D26OWgBQ79J1TsNlrsVU3g093FMe1OP9sYt6YWmx9UYoOCXrnu5i/+b28FDhanVg7dxWxt4t6QNSbxniNyKGRyXbgGKUG1pOlQC+4twyj+oJw7vpQKKVMkgkPJvjErwPMfm9pmRbZVIDzZMBb/oFilFq6nWp1wUP6eMBXQAfBR663GiupFfGxpNfzfBrlwer5vVW5uvQJool4JCDitC7wNuneDLZQsWMF2z1Ff9uX2bU3dHUl+62484nGdFMNe1lmVnkElLrHANCg/wGuM1TcPPTK054S21Y/qnld3k4D3d4qXyhPwKxQhqpzw+uyIjHCtp7883RrvBhuYUNkOv2Gy6coDJ3nsZzzz3Ir1R3IK5/fmUcGJzZ79fuw+mWMJAXCT5WF4Tofh+yf8oCmDRRjVGhY+aFe2WaaufksQ9BvijwvsWC9zQhSQAS626HobDiBzAKq8uNEIMcsXRJ/5omnbtNvhjv2LA0f/9bitU4s8/UxfAyVacsOZ4J0jcs49B+Q2NGgsuISUxlwd+py7f6/W+usIrWe+eYg8AcaWFKeLvsHoxWWxMznLdvioegY1ALZ6IiGJF0h+p78Od2pG04r257KgQK9Qwz/9nflU63VWBGfKtW1ih3AZJpuSfuWpv5a4+6uoDC4tyfHve+AF2GKrM0Mm8pbc/KUcQtIJt8s1jJCGaqPryGGL5JLm7Mv3zfArEHc3pZjwnFUL5+mxA8U0emO/PyOghp6iePM2sC/dFMpFElG2UmZyw2VHEiwCMUvQVVY8FH5ttNkY082M5vg9EGPS6GaShyWjI9UV7D7L8DTt+7iHB3D6nb8cRHk2YdzORkFvNfj6/7EWDxQR8MNoRQ3X3pEZAwyfV82HW5cgWMBAGb5+Sz3SlptfqrxkbPsqwhRHnu21J8kgKuvHnC2maR62NXw= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2213e12-3806-444c-6d19-08dd529052c3 X-MS-Exchange-CrossTenant-AuthSource: OS9PR01MB13950.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2025 15:56:37.7084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r5VFBPlo7yXlaQVrd93/UXvxlYCIFZUA8na61gDhMeABI2arcwVj6jcDESy8aYrtIqfpt97SVptmdcfcY/eyFIwFtSnbB5cYUxK/Wn/FVx9pzKh9qM1A3phBz7ZR7Q2E X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB6238 Use newly added devm_pm_runtime_enable() into rzg2l_csi2_probe() and drop error path accordingly. Drop also unnecessary pm_runtime_disable() from rzg2l_csi2_remove(). Reviewed-by: Laurent Pinchart Reviewed-by: Biju Das Signed-off-by: Tommaso Merciai --- Changes since v1: - Collected tags drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c index 948f1917b830..4ccf7c5ea58b 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-csi2.c @@ -805,11 +805,13 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) if (ret) return ret; - pm_runtime_enable(dev); + ret = devm_pm_runtime_enable(dev); + if (ret) + return ret; ret = rzg2l_validate_csi2_lanes(csi2); if (ret) - goto error_pm; + return ret; csi2->subdev.dev = dev; v4l2_subdev_init(&csi2->subdev, &rzg2l_csi2_subdev_ops); @@ -834,7 +836,7 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) ret = media_entity_pads_init(&csi2->subdev.entity, ARRAY_SIZE(csi2->pads), csi2->pads); if (ret) - goto error_pm; + return ret; ret = v4l2_subdev_init_finalize(&csi2->subdev); if (ret < 0) @@ -852,8 +854,6 @@ static int rzg2l_csi2_probe(struct platform_device *pdev) v4l2_async_nf_unregister(&csi2->notifier); v4l2_async_nf_cleanup(&csi2->notifier); media_entity_cleanup(&csi2->subdev.entity); -error_pm: - pm_runtime_disable(dev); return ret; } @@ -867,7 +867,6 @@ static void rzg2l_csi2_remove(struct platform_device *pdev) v4l2_async_unregister_subdev(&csi2->subdev); v4l2_subdev_cleanup(&csi2->subdev); media_entity_cleanup(&csi2->subdev.entity); - pm_runtime_disable(&pdev->dev); } static int rzg2l_csi2_pm_runtime_suspend(struct device *dev)