From patchwork Mon May 12 09:19:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason-JH Lin X-Patchwork-Id: 889587 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE2A25B1FA; Mon, 12 May 2025 09:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747041784; cv=none; b=LlIM98MJT6GElgM7JtP3wXq4ln9oGQbjj9CYCnP6vj8Vvmg2iLYgfbdXKBRoI5nA0odA5jnQuJJCAYZhG99exvUx7gnCYSGHR23B4LhvBVowtpSytTmAzZcoxyhZ67sbkoXuimuK9xK/XwZvPT+8CCgdHwmophvnSBR5XNSANPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747041784; c=relaxed/simple; bh=xnui7/JpheXtUGir60gyPjcyPVkx80hmibxKBqUjzT0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fcB4MSu6xMB+KHZ8u24JRNFLBhliwIZPusZqfUOv9g27N7NKx+g3Qz4sOyKSH1znsvw3b0EnlvZ3i1aoc1isUVhugSuCfcRYSWrE1yyTQ3Vff82G0oZSQjb8/X3+I5t1EiiNc9exPJObgBFG/2UorlKY6TcMl1FFsJLu4fhD6G8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=eGg9GYUg; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="eGg9GYUg" X-UUID: aff5e2802f1211f082f7f7ac98dee637-20250512 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=bqUrW/S1DNYDWOQZxBtcYh928tgJfE+WWFGo+Ex60Uo=; b=eGg9GYUgmj6VSjwFJyPwL4WUwg3357nvIOJRBf6HIniZlF564IQ6MoLs/d8IWjV6Ygu8hcSGXKePXoLW9tld2DzXITvcr6SlfcN7fevVgXBxmoP0A69Ybb1qd3k5ioMSOzIYm4M/CKS8bkJySxnedH5GJLPjKkyRYrqY6IjiZEM=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.2.1, REQID:493b7941-7bd8-4638-a640-16ea9e481641, IP:0, UR L:0,TC:0,Content:78,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:78 X-CID-META: VersionHash:0ef645f, CLOUDID:2f75ebf9-d2be-4f65-b354-0f04e3343627, B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|801,TC:nil,Content:3|50,ED M:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA: 0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: aff5e2802f1211f082f7f7ac98dee637-20250512 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 347431695; Mon, 12 May 2025 17:22:55 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.39; Mon, 12 May 2025 17:22:49 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1258.39 via Frontend Transport; Mon, 12 May 2025 17:22:53 +0800 From: Jason-JH Lin To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Chun-Kuang Hu , AngeloGioacchino Del Regno , Mauro Carvalho Chehab CC: Matthias Brugger , Jason-JH Lin , Nancy Lin , Singo Chang , Paul-PL Chen , "Moudy Ho" , Xavier Chang , Xiandong Wang , Sirius Wang , Fei Shao , Chen-yu Tsai , , , , , , , Subject: [PATCH RESEND v5 10/20] mailbox: mtk-cmdq: Remove unsued cmdq_get_shift_pa() Date: Mon, 12 May 2025 17:19:32 +0800 Message-ID: <20250512092252.905629-11-jason-jh.lin@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250512092252.905629-1-jason-jh.lin@mediatek.com> References: <20250512092252.905629-1-jason-jh.lin@mediatek.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MTK: N Since the mailbox driver data can be obtained using cmdq_get_mbox_priv() and all CMDQ users have transitioned to cmdq_get_mbox_priv(), cmdq_get_shift_pa() can be removed. Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") Signed-off-by: Jason-JH Lin --- drivers/mailbox/mtk-cmdq-mailbox.c | 8 -------- include/linux/mailbox/mtk-cmdq-mailbox.h | 12 ------------ 2 files changed, 20 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index db72dcd9b8b6..b18808855680 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -110,14 +110,6 @@ void cmdq_get_mbox_priv(struct mbox_chan *chan, struct cmdq_mbox_priv *priv) } EXPORT_SYMBOL(cmdq_get_mbox_priv); -u8 cmdq_get_shift_pa(struct mbox_chan *chan) -{ - struct cmdq *cmdq = container_of(chan->mbox, struct cmdq, mbox); - - return cmdq->pdata->shift; -} -EXPORT_SYMBOL(cmdq_get_shift_pa); - static void cmdq_gctl_value_toggle(struct cmdq *cmdq, bool ddr_enable) { u32 val = cmdq->pdata->control_by_sw ? GCE_CTRL_BY_SW : 0; diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h index 73b70be4a8a7..822958f92135 100644 --- a/include/linux/mailbox/mtk-cmdq-mailbox.h +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h @@ -95,16 +95,4 @@ struct cmdq_pkt { */ void cmdq_get_mbox_priv(struct mbox_chan *chan, struct cmdq_mbox_priv *priv); -/** - * cmdq_get_shift_pa() - get the shift bits of physical address - * @chan: mailbox channel - * - * GCE can only fetch the command buffer address from a 32-bit register. - * Some SOCs support more than 32-bit command buffer address for GCE, which - * requires some shift bits to make the address fit into the 32-bit register. - * - * Return: the shift bits of physical address - */ -u8 cmdq_get_shift_pa(struct mbox_chan *chan); - #endif /* __MTK_CMDQ_MAILBOX_H__ */