From patchwork Mon Apr 25 16:00:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaik Sajida Bhanu X-Patchwork-Id: 565944 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E2F2C433EF for ; Mon, 25 Apr 2022 16:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243165AbiDYQEX (ORCPT ); Mon, 25 Apr 2022 12:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243152AbiDYQEW (ORCPT ); Mon, 25 Apr 2022 12:04:22 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92BADBC94; Mon, 25 Apr 2022 09:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650902478; x=1682438478; h=from:to:cc:subject:date:message-id; bh=x8+BsrF0nyGjYvButLrl2VvdspR3FlxWvFjFP8NJGHA=; b=r9LrlhkBqYCfspSUTRNlAB0WywO3yeic4Q+HZjXlmYAA+q8WrqdNZbHL 18JinRbuVr6ZD8lq3rAgmfJD1gHjOiF7pGbz9K0D5sVt18nH4N7GSMYUy vOEyAMpM1XkR3S/bY1fgTf+fw2k42S0S3VT6CT4ZuYjx2utFF3kZUoL+X Y=; Received: from ironmsg08-lv.qualcomm.com ([10.47.202.152]) by alexa-out.qualcomm.com with ESMTP; 25 Apr 2022 09:01:18 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg08-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 25 Apr 2022 09:01:16 -0700 X-QCInternal: smtphost Received: from c-sbhanu-linux.qualcomm.com ([10.242.50.201]) by ironmsg02-blr.qualcomm.com with ESMTP; 25 Apr 2022 21:30:46 +0530 Received: by c-sbhanu-linux.qualcomm.com (Postfix, from userid 2344807) id 98883B77; Mon, 25 Apr 2022 21:30:45 +0530 (IST) From: Shaik Sajida Bhanu To: adrian.hunter@intel.com, ulf.hansson@linaro.org, wsa+renesas@sang-engineering.com, yoshihiro.shimoda.uh@renesas.com, linus.walleij@linaro.org, digetx@gmail.com, briannorris@chromium.org, quic_riteshh@quicinc.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, quic_asutoshd@quicinc.com, quic_rampraka@quicinc.com, quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com, Shaik Sajida Bhanu Subject: [PATCH V5 0/5] mmc: add error statistics for eMMC and SD card Date: Mon, 25 Apr 2022 21:30:38 +0530 Message-Id: <1650902443-26357-1-git-send-email-quic_c_sbhanu@quicinc.com> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Changes since V4: - Defined new macro to increment err_stats members when error occured as suggested by Adrain Hunter. - Called err_stats members increment function after printing the error as suggested by Adrain Hunter. - Considered INDEX and END_BIT errors same as CRC errors as suggested by Adrain Hunter. - Removed Null check for host in debug fs functions and Reordered err_stats declarationas suggested by Adrain Hunter. - Removed err_state variable stuff and updated err_state debug fs entry based on the err_stats members state as suggested by Adrain Hunter. Changes since V3: - Dropped error stats feature flag as suggested by Adrain Hunter. - Separated error state related changes in separate patches as suggested by Adrain Hunter. [PATCH V4 4/7] : error state debug fs [PATCH V4 5/7] : error state enable function [PATCH V4 6/7] : error state enable in error case - Note: we are enabling error state before calling sdhci_dumpregs we couldn't add the err state in error stats array as err state is not error type. - Corrected Signed-off-by order as suggested by Bjron Andersson. - Moved error state enable code from sdhci_dumpregs to error conditions as suggested by Adrain Hunter Changes since V2: - Removed userspace error stats clear debug fs entry as suggested by Adrain Hunter. - Split patch into 4 patches [PATCH V3 1/4] : sdhci driver [PATCH V3 2/4] : debug fs entries [PATCH V3 3/4] : core driver [PATCH V3 4/4] : cqhci driver - Used for loop to print error messages instead of using printf statements for all error messages as suggested by Adrain Hunter. - Introduced one flag to enable error stats feature, if any other client wants to use this feature, they need to enable that flag. - Moved reset command timeout error statement to card init flow as suggested by Adrain Hunter. Changes since V1: - Removed sysfs entry for eMMC and SD card error statistics and added debugfs entry as suggested by Adrian Hunter and Ulf Hansson. Shaik Sajida Bhanu (5): mmc: core: Capture eMMC and SD card errors mmc: sdhci: Capture eMMC and SD card errors mmc: debugfs: Add debug fs entry for mmc driver mmc: debugfs: Add debug fs error state entry for mmc driver mmc: cqhci: Capture eMMC and SD card errors drivers/mmc/core/core.c | 6 ++++ drivers/mmc/core/debugfs.c | 81 +++++++++++++++++++++++++++++++++++++++++++ drivers/mmc/host/cqhci-core.c | 9 ++++- drivers/mmc/host/sdhci.c | 54 ++++++++++++++++++++++------- drivers/mmc/host/sdhci.h | 3 ++ include/linux/mmc/host.h | 26 ++++++++++++++ include/linux/mmc/mmc.h | 6 ++++ 7 files changed, 171 insertions(+), 14 deletions(-)