mbox series

[0/5] mmc: core: Fix and cleanup HPI/CACHE/BKOPS code

Message ID 20181210165240.23101-1-ulf.hansson@linaro.org
Headers show
Series mmc: core: Fix and cleanup HPI/CACHE/BKOPS code | expand

Message

Ulf Hansson Dec. 10, 2018, 4:52 p.m. UTC 
From a couple of different discussions/reports on the mmc mailing lists, I
realized that there we have a few bugs to the HPI/CACHE/BKOPS support. The
problems should be fixed in this series, but I also took the opportunity to
do a few cleanups for the related code on top.

Reviews and tests are highly appreciated!

Kind regards
Uffe

Ulf Hansson (5):
  mmc: core: Reset HPI enabled state during re-init and in case of
    errors
  mmc: core: Allow BKOPS and CACHE ctrl even if no HPI support
  mmc: core: Use a minimum 1600ms timeout when enabling CACHE ctrl
  mmc: core: Drop redundant check in mmc_send_hpi_cmd()
  mmc: core: Cleanup BKOPS support

 drivers/mmc/core/block.c   |  2 +-
 drivers/mmc/core/card.h    |  6 +--
 drivers/mmc/core/mmc.c     | 30 ++++++------
 drivers/mmc/core/mmc_ops.c | 93 ++++++++------------------------------
 drivers/mmc/core/mmc_ops.h |  3 +-
 5 files changed, 36 insertions(+), 98 deletions(-)

-- 
2.17.1

Comments

Ulf Hansson Dec. 17, 2018, 8:07 a.m. UTC | #1 
On Mon, 10 Dec 2018 at 17:52, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>

> From a couple of different discussions/reports on the mmc mailing lists, I

> realized that there we have a few bugs to the HPI/CACHE/BKOPS support. The

> problems should be fixed in this series, but I also took the opportunity to

> do a few cleanups for the related code on top.

>

> Reviews and tests are highly appreciated!


To move forward, I have queued up patch 1->3 as fixes with stable tags
and 4->5 for next. Let's see what kernelci reports.

Thanks!
Uffe


>

> Kind regards

> Uffe

>

> Ulf Hansson (5):

>   mmc: core: Reset HPI enabled state during re-init and in case of

>     errors

>   mmc: core: Allow BKOPS and CACHE ctrl even if no HPI support

>   mmc: core: Use a minimum 1600ms timeout when enabling CACHE ctrl

>   mmc: core: Drop redundant check in mmc_send_hpi_cmd()

>   mmc: core: Cleanup BKOPS support

>

>  drivers/mmc/core/block.c   |  2 +-

>  drivers/mmc/core/card.h    |  6 +--

>  drivers/mmc/core/mmc.c     | 30 ++++++------

>  drivers/mmc/core/mmc_ops.c | 93 ++++++++------------------------------

>  drivers/mmc/core/mmc_ops.h |  3 +-

>  5 files changed, 36 insertions(+), 98 deletions(-)

>

> --

> 2.17.1

>