mbox series

[v5,0/6] mmc: sdhci-of-aspeed: Expose phase delay tuning

Message ID 20201208012615.2717412-1-andrew@aj.id.au
Headers show
Series mmc: sdhci-of-aspeed: Expose phase delay tuning | expand

Message

Andrew Jeffery Dec. 8, 2020, 1:26 a.m. UTC 
Hello,

This series implements support for the MMC core clk-phase-* devicetree bindings
in the Aspeed SD/eMMC driver. The relevant register was exposed on the AST2600
and is present for both the SD/MMC controller and the dedicated eMMC
controller.

v5 fixes some build issues identified by the kernel test robot.

v4 can be found here:

https://lore.kernel.org/linux-mmc/20201207142556.2045481-1-andrew@aj.id.au/

The series has had light testing on an AST2600-based platform which requires
180deg of input and output clock phase correction at HS200, as well as some
synthetic testing under qemu and KUnit.

Please review!

Cheers,

Andrew

Andrew Jeffery (6):
  mmc: core: Add helper for parsing clock phase properties
  mmc: sdhci-of-aspeed: Expose clock phase controls
  mmc: sdhci-of-aspeed: Add AST2600 bus clock support
  mmc: sdhci-of-aspeed: Add KUnit tests for phase calculations
  MAINTAINERS: Add entry for the ASPEED SD/MMC driver
  ARM: dts: rainier: Add eMMC clock phase compensation

 MAINTAINERS                                  |   9 +
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts |   1 +
 drivers/mmc/core/host.c                      |  44 ++++
 drivers/mmc/host/Kconfig                     |  14 ++
 drivers/mmc/host/Makefile                    |   1 +
 drivers/mmc/host/sdhci-of-aspeed-test.c      | 100 ++++++++
 drivers/mmc/host/sdhci-of-aspeed.c           | 251 ++++++++++++++++++-
 include/linux/mmc/host.h                     |  17 ++
 8 files changed, 426 insertions(+), 11 deletions(-)
 create mode 100644 drivers/mmc/host/sdhci-of-aspeed-test.c

Comments

Ulf Hansson Dec. 14, 2020, 3:56 p.m. UTC | #1 
On Tue, 8 Dec 2020 at 02:26, Andrew Jeffery <andrew@aj.id.au> wrote:
>

> Hello,

>

> This series implements support for the MMC core clk-phase-* devicetree bindings

> in the Aspeed SD/eMMC driver. The relevant register was exposed on the AST2600

> and is present for both the SD/MMC controller and the dedicated eMMC

> controller.

>

> v5 fixes some build issues identified by the kernel test robot.

>

> v4 can be found here:

>

> https://lore.kernel.org/linux-mmc/20201207142556.2045481-1-andrew@aj.id.au/

>

> The series has had light testing on an AST2600-based platform which requires

> 180deg of input and output clock phase correction at HS200, as well as some

> synthetic testing under qemu and KUnit.

>

> Please review!


FYI, other than the comment I had on patch1, I think the series looks
good to me.

[...]

Kind regards
Uffe