From patchwork Tue Mar 29 07:31:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 64573 Delivered-To: patches@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1853894lbc; Tue, 29 Mar 2016 00:31:23 -0700 (PDT) X-Received: by 10.25.86.195 with SMTP id k186mr366775lfb.155.1459236683021; Tue, 29 Mar 2016 00:31:23 -0700 (PDT) Return-Path: Received: from mail-lb0-x232.google.com (mail-lb0-x232.google.com. [2a00:1450:4010:c04::232]) by mx.google.com with ESMTPS id 101si16129968lfx.111.2016.03.29.00.31.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Mar 2016 00:31:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:4010:c04::232 as permitted sender) client-ip=2a00:1450:4010:c04::232; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:4010:c04::232 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org Received: by mail-lb0-x232.google.com with SMTP id u8so4726134lbk.0 for ; Tue, 29 Mar 2016 00:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Uy9MzAknfBW/Zx4ZEZfPItV8S3y+eur8q60Ts2xVq4E=; b=ZlrT9CWaCc6GFWubyAmpNtDYfXjC1PDdQYkoaBaLi5ty1XdMl4JL2mw+Zzs3XLMlRH sW4mothony0CNcKFj+EmwjG6dd75WGOUyO5bHOHYiSs75DX6hYkObCuWLIp97dlcgJZg VWoi61YmIuBYkXmfaCswK7pqBsK8LFp2meCBY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Uy9MzAknfBW/Zx4ZEZfPItV8S3y+eur8q60Ts2xVq4E=; b=GWnh4csnFnZF3yLIQxM4WDl5sMVyKerIFb0Kwy8EhfpBCrpKBJQHFOovumZE0zt+vY 2WywnT9FKS1DOnJ7bs4UuvUKPaXf/33qNHpinUhTWkCIi0uJfMd8F3JiCJNLHvhrs2Vl gcMJbKfy0XCIuSJaboV6m1/Ndrdf9NjcHRKHqTF8mqzxwjWbEPosksWcmDcCDHTs/XQJ CdTxKCsJyGII5OHqWOFTkfaTgkLKSR3aQkrN5ZH80vUcw/AvpB9XeHiCP3VOt4weuyip NbibkDn3xf22Ps5Nq+C7MSV4cJtXTGt4nE+r2uQORVgMziKC2Rx/yP7XThDcjRFSAN/y /kxQ== X-Gm-Message-State: AD7BkJIIb38MyzEjvBUklIbmoy+Vc1RavxB5/zebp7hjuSXDuC9A3ZIaJneIFD2Mz770B+3xYhM= X-Received: by 10.112.161.198 with SMTP id xu6mr361790lbb.131.1459236682436; Tue, 29 Mar 2016 00:31:22 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-83-233-167-104.cust.bredband2.com. [83.233.167.104]) by smtp.gmail.com with ESMTPSA id qh4sm5033100lbb.43.2016.03.29.00.31.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2016 00:31:21 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Ludovic Desroches Subject: [PATCH 1/8] mmc: atmel-mci: Remove redundant runtime PM calls Date: Tue, 29 Mar 2016 09:31:06 +0200 Message-Id: <1459236673-5639-1-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 Commit 9250aea76bfc ("mmc: core: Enable runtime PM management of host devices"), made some calls to the runtime PM API from the driver redundant. Especially those which deals with runtime PM reference counting, so let's remove them. Cc: Ludovic Desroches Signed-off-by: Ulf Hansson --- drivers/mmc/host/atmel-mci.c | 9 --------- 1 file changed, 9 deletions(-) -- 1.9.1 diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 9268c41..0ad8ef5 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -1410,8 +1410,6 @@ static void atmci_request(struct mmc_host *mmc, struct mmc_request *mrq) WARN_ON(slot->mrq); dev_dbg(&host->pdev->dev, "MRQ: cmd %u\n", mrq->cmd->opcode); - pm_runtime_get_sync(&host->pdev->dev); - /* * We may "know" the card is gone even though there's still an * electrical connection. If so, we really need to communicate @@ -1442,8 +1440,6 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) struct atmel_mci *host = slot->host; unsigned int i; - pm_runtime_get_sync(&host->pdev->dev); - slot->sdc_reg &= ~ATMCI_SDCBUS_MASK; switch (ios->bus_width) { case MMC_BUS_WIDTH_1: @@ -1576,8 +1572,6 @@ static void atmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) break; } - pm_runtime_mark_last_busy(&host->pdev->dev); - pm_runtime_put_autosuspend(&host->pdev->dev); } static int atmci_get_ro(struct mmc_host *mmc) @@ -1669,9 +1663,6 @@ static void atmci_request_end(struct atmel_mci *host, struct mmc_request *mrq) spin_unlock(&host->lock); mmc_request_done(prev_mmc, mrq); spin_lock(&host->lock); - - pm_runtime_mark_last_busy(&host->pdev->dev); - pm_runtime_put_autosuspend(&host->pdev->dev); } static void atmci_command_complete(struct atmel_mci *host,