From patchwork Wed Apr 20 02:16:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 66158 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp2195097qge; Tue, 19 Apr 2016 19:16:01 -0700 (PDT) X-Received: by 10.66.141.42 with SMTP id rl10mr8836243pab.48.1461118560802; Tue, 19 Apr 2016 19:16:00 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4si897322pan.85.2016.04.19.19.16.00; Tue, 19 Apr 2016 19:16:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbcDTCP6 (ORCPT + 2 others); Tue, 19 Apr 2016 22:15:58 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:38197 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791AbcDTCP4 (ORCPT ); Tue, 19 Apr 2016 22:15:56 -0400 Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id u3K2FZ7f005192; Wed, 20 Apr 2016 11:15:36 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com u3K2FZ7f005192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1461118537; bh=f7GmbIMrSOjZPADdsj8xW42O06omS5P4ZZSCI7cZKLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CtInvyRWuu7Lb8L+2TcAmKE0zIs1clCyuhRQ9O3bWvK7O9CqyLAH7JvGOxwzSJS/Q w1bNv12pmwWw4XMCTV0F5nRNEXFsbTJ+K/8/9keJtHbOxJ189JSpZzFChcByXpfOaB UCOCYdAd+iAJqiFA9fMOSbeEXQBYlfrWKCwBdL7704PM5hc35dERbmE2lkSxaF/pzR 98AFro3idMT00SGjGjDdKoEcbdAeNgsV2uqjfRfQbqFj1usm5nkZItTswlBJDptPVj IB9dLAdNNXkztZB/tMm1Om3uU/sN46eHPVoHexPpZEYftML2CCpDK4xqMXp69sZx+0 tK/JLY6kZ8mDg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mmc@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org, Adrian Hunter , Ulf Hansson Subject: [PATCH v2 1/7] mmc: sdhci-pltfm: drop error message for too small MMIO resource size Date: Wed, 20 Apr 2016 11:16:25 +0900 Message-Id: <1461118591-21595-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461118591-21595-1-git-send-email-yamada.masahiro@socionext.com> References: <1461118591-21595-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The requirement resource_size >= 0x100 may not necessarily be reasonable; for example, sdhci-dove appears to sidestep some registers in sdhci_dove_readw(). Moreover, current code displays an error message for too small resource size, but still moves forward. Every DT should be responsible for describing its properties correctly, so lets's remove this error message from the common framework. Signed-off-by: Masahiro Yamada --- Changes in v2: - Remove resource size checking rather than fix it. drivers/mmc/host/sdhci-pltfm.c | 3 --- 1 file changed, 3 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index 072bb27..03dbdeb 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -127,9 +127,6 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev, goto err; } - if (resource_size(iomem) < 0x100) - dev_err(&pdev->dev, "Invalid iomem size!\n"); - host = sdhci_alloc_host(&pdev->dev, sizeof(struct sdhci_pltfm_host) + priv_size);