From patchwork Tue Nov 22 20:56:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 83500 Delivered-To: patches@linaro.org Received: by 10.140.97.165 with SMTP id m34csp2310884qge; Tue, 22 Nov 2016 12:56:23 -0800 (PST) X-Received: by 10.28.113.218 with SMTP id d87mr107416wmi.111.1479848183790; Tue, 22 Nov 2016 12:56:23 -0800 (PST) Return-Path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com. [2a00:1450:400c:c09::22f]) by mx.google.com with ESMTPS id n9si4515423wmd.31.2016.11.22.12.56.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2016 12:56:23 -0800 (PST) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:400c:c09::22f as permitted sender) client-ip=2a00:1450:400c:c09::22f; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 2a00:1450:400c:c09::22f as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-wm0-x22f.google.com with SMTP id f82so46543737wmf.1 for ; Tue, 22 Nov 2016 12:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6BZAnPdhzCYfwAGtIxPubfuymbMszR65uh3sbT4RXpE=; b=L66B5UMXuKRcNpuUfBD6inDJdU6qGHsAwCR0DidP3KSM/7O+ECfl7hgF5LqfsWb9Ma qnrhCC/thxmTxYYUdR/dQ2VGRDsYDkoFxk+BPijR4YYYkz9e/Xu41eaNp7S9K1Y04M6c zIjgjep44zofvETBEUnCoti5TycZkfBs2C9JI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6BZAnPdhzCYfwAGtIxPubfuymbMszR65uh3sbT4RXpE=; b=BR8UBakwPIGpRIwP5Sx0BlEii1eLmeBzszuvc3U/RKXfQOBAOTeFDA7xSxZViwTlmE doGafYd3IN/3fbMP7+RqiCcSZZSpmYK3uLwHc1888e139X6CbIgmQxCcWoYtxZwCDzlR gGlV65YSOtsHRj8zP3VC2tmenqo60junF5VTPVgi7C0CXW1lVi2g4qZeMbOH2dO4G+nx 885OqanxpANZ728YFTG8rqiYGtkHo9bJXkjFb/12BefM5YwQ4yBZASpd4fofYwrhITnP kfJnjTmQzw9IREleOG5xkVeVDGlnrYd/daQ/0s4bV9bMIadqnWx9r9tFr8OFa9Q0flve 582w== X-Gm-Message-State: AKaTC01thx9dqbAl+NEm13BZUcuWDY/ErSrVzNdBNivKCO8m0rDEVaRi8tYTN1Ync/RitdUND6U= X-Received: by 10.25.160.145 with SMTP id j139mr5091336lfe.67.1479848183380; Tue, 22 Nov 2016 12:56:23 -0800 (PST) Return-Path: Received: from localhost.localdomain (h-155-4-221-67.na.cust.bahnhof.se. [155.4.221.67]) by smtp.gmail.com with ESMTPSA id 196sm6619988lff.3.2016.11.22.12.56.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Nov 2016 12:56:22 -0800 (PST) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Jaehoon Chung , Adrian Hunter , Linus Walleij , Chaotian Jing , Stephen Boyd , Michael Walle , Yong Mao , Shawn Lin Subject: [PATCH v2 2/7] mmc: core: Remove redundant __mmc_send_status() Date: Tue, 22 Nov 2016 21:56:08 +0100 Message-Id: <1479848173-20881-3-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1479848173-20881-1-git-send-email-ulf.hansson@linaro.org> References: <1479848173-20881-1-git-send-email-ulf.hansson@linaro.org> There are only one users left which calls __mmc_send_status(). Moreover, the ignore_crc parameter isn't being used, so let's just remove these redundant parts. Signed-off-by: Ulf Hansson --- drivers/mmc/core/mmc_ops.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) -- 1.9.1 diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c index 4773c56..0515748 100644 --- a/drivers/mmc/core/mmc_ops.c +++ b/drivers/mmc/core/mmc_ops.c @@ -54,8 +54,7 @@ 0xff, 0x77, 0x77, 0xff, 0x77, 0xbb, 0xdd, 0xee, }; -static inline int __mmc_send_status(struct mmc_card *card, u32 *status, - bool ignore_crc) +int mmc_send_status(struct mmc_card *card, u32 *status) { int err; struct mmc_command cmd = {0}; @@ -67,8 +66,6 @@ static inline int __mmc_send_status(struct mmc_card *card, u32 *status, if (!mmc_host_is_spi(card->host)) cmd.arg = card->rca << 16; cmd.flags = MMC_RSP_SPI_R2 | MMC_RSP_R1 | MMC_CMD_AC; - if (ignore_crc) - cmd.flags &= ~MMC_RSP_CRC; err = mmc_wait_for_cmd(card->host, &cmd, MMC_CMD_RETRIES); if (err) @@ -83,11 +80,6 @@ static inline int __mmc_send_status(struct mmc_card *card, u32 *status, return 0; } -int mmc_send_status(struct mmc_card *card, u32 *status) -{ - return __mmc_send_status(card, status, false); -} - static int _mmc_select_card(struct mmc_host *host, struct mmc_card *card) { struct mmc_command cmd = {0};