diff mbox series

[v2,2/3] dt-bindings: mmc: meson-gx: support specifying cd interrupt

Message ID 1c5996a5-491f-39d6-b120-bbef86473729@gmail.com
State New
Headers show
Series mmc: support setting card detect interrupt from drivers and use it in meson-gx | expand

Commit Message

Heiner Kallweit Feb. 14, 2023, 9:42 p.m. UTC
Support passing a second interrupt as card detect interrupt.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Feb. 16, 2023, 9:18 a.m. UTC | #1
On 14/02/2023 22:42, Heiner Kallweit wrote:
> Support passing a second interrupt as card detect interrupt.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> index 46e235bf2..c8c30300d 100644
> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> @@ -28,7 +28,7 @@ properties:
>      maxItems: 1
>  
>    interrupts:
> -    maxItems: 1
> +    maxItems: 2

Wait, you now *require* (not support) cd interrupt, so this looks like
ABI break.

Second, you must describe the items.

Best regards,
Krzysztof
Heiner Kallweit Feb. 16, 2023, 9:29 a.m. UTC | #2
On 16.02.2023 10:18, Krzysztof Kozlowski wrote:
> On 14/02/2023 22:42, Heiner Kallweit wrote:
>> Support passing a second interrupt as card detect interrupt.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> index 46e235bf2..c8c30300d 100644
>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>> @@ -28,7 +28,7 @@ properties:
>>      maxItems: 1
>>  
>>    interrupts:
>> -    maxItems: 1
>> +    maxItems: 2
> 
> Wait, you now *require* (not support) cd interrupt, so this looks like
> ABI break.
> 
The second interrupt is optional. If not provided MMC core falls back to
cd polling.

> Second, you must describe the items.
> 
OK, this will be added.

> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Feb. 16, 2023, 9:34 a.m. UTC | #3
On 16/02/2023 10:29, Heiner Kallweit wrote:
> On 16.02.2023 10:18, Krzysztof Kozlowski wrote:
>> On 14/02/2023 22:42, Heiner Kallweit wrote:
>>> Support passing a second interrupt as card detect interrupt.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>> ---
>>>  Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>> index 46e235bf2..c8c30300d 100644
>>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>> @@ -28,7 +28,7 @@ properties:
>>>      maxItems: 1
>>>  
>>>    interrupts:
>>> -    maxItems: 1
>>> +    maxItems: 2
>>
>> Wait, you now *require* (not support) cd interrupt, so this looks like
>> ABI break.
>>
> The second interrupt is optional. If not provided MMC core falls back to
> cd polling.

It is not. Your binding requires it. Did you test it on DTS without the
second interrupt?

> 
>> Second, you must describe the items.
>>
> OK, this will be added.


Best regards,
Krzysztof
Heiner Kallweit Feb. 16, 2023, 9:41 a.m. UTC | #4
On 16.02.2023 10:34, Krzysztof Kozlowski wrote:
> On 16/02/2023 10:29, Heiner Kallweit wrote:
>> On 16.02.2023 10:18, Krzysztof Kozlowski wrote:
>>> On 14/02/2023 22:42, Heiner Kallweit wrote:
>>>> Support passing a second interrupt as card detect interrupt.
>>>>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>>> index 46e235bf2..c8c30300d 100644
>>>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>>> @@ -28,7 +28,7 @@ properties:
>>>>      maxItems: 1
>>>>  
>>>>    interrupts:
>>>> -    maxItems: 1
>>>> +    maxItems: 2
>>>
>>> Wait, you now *require* (not support) cd interrupt, so this looks like
>>> ABI break.
>>>
>> The second interrupt is optional. If not provided MMC core falls back to
>> cd polling.
> 
> It is not. Your binding requires it. Did you test it on DTS without the
> second interrupt?
> 
You're right, the binding misses a minItems 1. I'll add that and the
interrupt description.

>>
>>> Second, you must describe the items.
>>>
>> OK, this will be added.
> 
> 
> Best regards,
> Krzysztof
>
Heiner Kallweit Feb. 16, 2023, 9:49 a.m. UTC | #5
On 16.02.2023 10:41, Heiner Kallweit wrote:
> On 16.02.2023 10:34, Krzysztof Kozlowski wrote:
>> On 16/02/2023 10:29, Heiner Kallweit wrote:
>>> On 16.02.2023 10:18, Krzysztof Kozlowski wrote:
>>>> On 14/02/2023 22:42, Heiner Kallweit wrote:
>>>>> Support passing a second interrupt as card detect interrupt.
>>>>>
>>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>>>> index 46e235bf2..c8c30300d 100644
>>>>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>>>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
>>>>> @@ -28,7 +28,7 @@ properties:
>>>>>      maxItems: 1
>>>>>  
>>>>>    interrupts:
>>>>> -    maxItems: 1
>>>>> +    maxItems: 2
>>>>
>>>> Wait, you now *require* (not support) cd interrupt, so this looks like
>>>> ABI break.
>>>>
>>> The second interrupt is optional. If not provided MMC core falls back to
>>> cd polling.
>>
>> It is not. Your binding requires it. Did you test it on DTS without the
>> second interrupt?
>>
> You're right, the binding misses a minItems 1. I'll add that and the
> interrupt description.
> 
Ulf,
do you require an add-on patch that fixes the binding issue or a
replacement patch?

>>>
>>>> Second, you must describe the items.
>>>>
>>> OK, this will be added.
>>
>>
>> Best regards,
>> Krzysztof
>>
>
Ulf Hansson Feb. 16, 2023, 11:12 a.m. UTC | #6
On Thu, 16 Feb 2023 at 10:49, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> On 16.02.2023 10:41, Heiner Kallweit wrote:
> > On 16.02.2023 10:34, Krzysztof Kozlowski wrote:
> >> On 16/02/2023 10:29, Heiner Kallweit wrote:
> >>> On 16.02.2023 10:18, Krzysztof Kozlowski wrote:
> >>>> On 14/02/2023 22:42, Heiner Kallweit wrote:
> >>>>> Support passing a second interrupt as card detect interrupt.
> >>>>>
> >>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >>>>> ---
> >>>>>  Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +-
> >>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>>
> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> >>>>> index 46e235bf2..c8c30300d 100644
> >>>>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> >>>>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
> >>>>> @@ -28,7 +28,7 @@ properties:
> >>>>>      maxItems: 1
> >>>>>
> >>>>>    interrupts:
> >>>>> -    maxItems: 1
> >>>>> +    maxItems: 2
> >>>>
> >>>> Wait, you now *require* (not support) cd interrupt, so this looks like
> >>>> ABI break.
> >>>>
> >>> The second interrupt is optional. If not provided MMC core falls back to
> >>> cd polling.
> >>
> >> It is not. Your binding requires it. Did you test it on DTS without the
> >> second interrupt?
> >>
> > You're right, the binding misses a minItems 1. I'll add that and the
> > interrupt description.
> >
> Ulf,
> do you require an add-on patch that fixes the binding issue or a
> replacement patch?

Please send an incremental patch on top, I would like to avoid any
further rebase at this late in the release cycle.

Kind regards
Uffe
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
index 46e235bf2..c8c30300d 100644
--- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
+++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml
@@ -28,7 +28,7 @@  properties:
     maxItems: 1
 
   interrupts:
-    maxItems: 1
+    maxItems: 2
 
   clocks:
     maxItems: 3