From patchwork Mon Dec 10 16:52:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 153300 Delivered-To: patches@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3772610ljp; Mon, 10 Dec 2018 08:52:49 -0800 (PST) X-Received: by 2002:a2e:5c86:: with SMTP id q128-v6mr8354027ljb.119.1544460769080; Mon, 10 Dec 2018 08:52:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544460769; cv=none; d=google.com; s=arc-20160816; b=jUe6jl6S3vbNBHZvpi/el6hdIhaYBTv7L2Cl0eMprrN0GSUI9kb3UR0ajAkWmPDwD4 yM+RxWkNtgGRdF3VRW4jxDrTlR5luBtgHvSaLTUQuK5X6+SGNbOS/yBH2815LZvouJMC MRWo6xzBh2miZ5qtq2ht3YZIQfymLBEWufPZAJrl8Sq6P354pyxhLY8HlG9P5D8cWA5C i7hfazDyH7ZFLGicdRENgbKf5hstYfXZDu7b9w0kGNDIaQsNuzYbFB80bbt4Sdwo7w/I EJNLV0y5cjDr5mt3oQkYx26374lVwmRUNsbylbdXVBO5H9FU0KynjTRy7nCOy7EMnVRz Tt7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V22VZ/qtHeHwmBH5FUkElluUpeyt8M78z5UvAjTJvFE=; b=LFKjuWElE/mZxoKSlSt8vTIozBfB5gIS7GBHmLBVMSM/CF/AQU008VU0MAS7aQE4NC blMRUYDC+cwvC1yYBixEATvrQ/zimRcR0FhihEe509ruKf9OHb0ME/CDQH4K5vA+9EuK u5MrlBX2y/lABeCiTbmR/pxokQKjELan3x+HJ5Hjbk2kS4US268R+zA4p29lGx1KmWC6 gyWGUaVzEPun8s0PUxVL5L0ezjNJpj3VIxf+aZe+sDtLLXyjq1AAcTlXCAIKf4ZA9VqY YyL85021DHuoG34ZUJZCr2kNrGP3VgV6WxtAlcMik8TYduuyI7odoE8XyS4XnRYfoKVi 24qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RBb4KMtF; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id z25sor3009618lfb.52.2018.12.10.08.52.49 for (Google Transport Security); Mon, 10 Dec 2018 08:52:49 -0800 (PST) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RBb4KMtF; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=V22VZ/qtHeHwmBH5FUkElluUpeyt8M78z5UvAjTJvFE=; b=RBb4KMtFb+BjZ087pBJhfBP+eKrGW8MtaVTB2g4K7VolVP27gIRTldv/d8WaHKXGYo riNnZnUomVL0Bvvr8+aFlLzGcmEJdJZZ9vJeAxEY+OZnOEYXMVV2a0bX86TkiGcbdICa LRy7Xe/KOjJsUNAShA0R9gsAtMtIW0YH1epc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V22VZ/qtHeHwmBH5FUkElluUpeyt8M78z5UvAjTJvFE=; b=TSruCj7JE4V4J5ACmTbz2iujF5D6i2gkNx7WJIuEORX6rIu6Uj+PEB95FngDH5ZXfT zKIFdeiLQVi/rd1IbrddVjrgiHd/uGmQ6jdaTvuC3549YxMH3+X8QzyFbkrHqMbNJATq KXcdGKooIRrT4KrkUHRgIKoQxHVyclT1pWPLPzYZCPm81OjnpyUBFCzkUkTOFcytgC4A J03SsvVWXB3aEMBzknAZeIGzqrTzc5tt32wFe9Hoyv7velG4J1AnfVRSmoNeV3c9btbL j3WNWDTwNGg4zvJpaZYDV19rnZHmKCpKn0SLaSLDfdkzDrB9lTarszQeI+qTrsgzF9Ne Dl5w== X-Gm-Message-State: AA+aEWYN5FBrdxRegaAqkgLe1Zql5OVEa69RHH0LB7cpgRTlKLVXg4Wg gEeGHrdDIJE2jF5RIXX020d0Ad3Y X-Google-Smtp-Source: AFSGD/XpkTO6mT8rp73JR9KURAhdj+8cHfnIIlL3fXCebhUHtTTSquL1i3Z6f6VmMUTpGIjw/kctUw== X-Received: by 2002:a19:4d8d:: with SMTP id a135mr7796126lfb.80.1544460768706; Mon, 10 Dec 2018 08:52:48 -0800 (PST) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id w9sm2194574lfc.66.2018.12.10.08.52.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Dec 2018 08:52:48 -0800 (PST) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Wolfram Sang , Adrian Hunter , Sjoerd Simons , Faiz Abbas , Jaehoon Chung , Shawn Lin Subject: [PATCH 4/5] mmc: core: Drop redundant check in mmc_send_hpi_cmd() Date: Mon, 10 Dec 2018 17:52:39 +0100 Message-Id: <20181210165240.23101-5-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181210165240.23101-1-ulf.hansson@linaro.org> References: <20181210165240.23101-1-ulf.hansson@linaro.org> There is no point checking if HPI is supported in mmc_send_hpi_cmd() as mmc_interrupt_hpi(), which is the only caller, already checks if HPI has been enabled. Therefore, let's drop the check and the corresponding error path. Signed-off-by: Ulf Hansson --- drivers/mmc/core/mmc_ops.c | 6 ------ 1 file changed, 6 deletions(-) -- 2.17.1 diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c index 873b2aa0c155..ffc74d44ee67 100644 --- a/drivers/mmc/core/mmc_ops.c +++ b/drivers/mmc/core/mmc_ops.c @@ -802,12 +802,6 @@ static int mmc_send_hpi_cmd(struct mmc_card *card, u32 *status) unsigned int opcode; int err; - if (!card->ext_csd.hpi) { - pr_warn("%s: Card didn't support HPI command\n", - mmc_hostname(card->host)); - return -EINVAL; - } - opcode = card->ext_csd.hpi_cmd; if (opcode == MMC_STOP_TRANSMISSION) cmd.flags = MMC_RSP_R1B | MMC_CMD_AC;