From patchwork Wed Mar 6 14:04:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 159751 Delivered-To: patches@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp6206082jad; Wed, 6 Mar 2019 06:05:07 -0800 (PST) X-Received: by 2002:a2e:818b:: with SMTP id e11mr2606961ljg.104.1551881107233; Wed, 06 Mar 2019 06:05:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551881107; cv=none; d=google.com; s=arc-20160816; b=q0u/TNWaaSC72CB8UhpMONVEq5jWl95Xxkctwwz/iD6164yzvD8Q21GtaczppprO8y BTbTSPMJMn8MYKTnUjkgh/aWs93XbBqpfczrAH+g2/yvyOrQEeQso3WKsp32/JjFnklP oIpNMjW+zARj1PXvPqAZxa7/By59iwq61wxbJILOXfK0104RuGUJicIu34YWhGUE9co7 aG5ne6RrvBpbs5AN0sTK9oR4S7ZykB6zOJt7XaUOYMyZ/mEpTOpAHBQfBopLJuW5rZVo BPb0jZwRLeoFFSoIB61ISbw4BCSvAOE+AGPHy6s/d+CFyg1SgGs+g0SdvK3kJLU6dDDy xgXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TgXa43oohEj4CgD4f1ipe2rPTFKtZ11pZj9jyv+WNJU=; b=BnZuUlK9aEQHSqjyVmFjYMpKVLzqg8K1WNMTKEUdGJ2QsOKkfImKieNgN/APHiaX0s vjwiu+GHwEu+Wm2tP7lC771ruShWrBsb05K+j/l7iqmmo6h/jCGBC6Phwc/w7kzpsot6 2LM5rnPX+kYPU5FHscvvmxh4x2o9mUjf/aaw+F1qPyG+/hTl8Fv2CLIKOmdty6K7Tbv4 PVpG/LEeBI9LPPa0h6RbUy58ngBLGEMd9uLVGKcUBqzblSquvdPA/FC0I1pWo/LJjL12 09hMgl8gTTz32gG6JH96p+PfmgBxulppHsyxAf2kMf4a1oSU5hL4EcJy2JfqTaRj8M9k Mh7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yfeyCABW; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id l187sor541291lfe.2.2019.03.06.06.05.07 for (Google Transport Security); Wed, 06 Mar 2019 06:05:07 -0800 (PST) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yfeyCABW; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TgXa43oohEj4CgD4f1ipe2rPTFKtZ11pZj9jyv+WNJU=; b=yfeyCABWQXAnqLbK1AMf7nqZVzitr2qzhtKU3TMwoF0Oeqv/XuMh45nBoP0hhUtjmo es4W8SDXZ2BwghFz0UsEQ627e5mXgnseeq2u1g+higf242YfmeYhJ+Uxe9SKb6MMD1nO 3E0GM88spkT+Sl7NEdLaxNfjpwTrVObd4QkRr9P+fjvdgl6jXeTC+V83D158bR87WpFs SMT6SnP85L4gI512UbwCk1INot9d28ngKtU8XbfeDOpI8q0e5kL54Xl6L8ElnVYN7uyD 98ddd21dya2OvQUXA2xxqkD6xBchlnAh1qxjZW/b6HvbN3jd5aqmt9wT2cfhmbz+phrx jTcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TgXa43oohEj4CgD4f1ipe2rPTFKtZ11pZj9jyv+WNJU=; b=kWgqCjs15LLr0GKSnruQdNisjl+AY/zaGFihFlkU2PihcPzUxLHJwf02oGfElXO7so hwfFiPvXZiwYlELImDpoM+UWWke/KmDZskiatAdHShIgDH/HxyGNmnzwq3MIiemV00oX +Hcy/Of2JzO1Jgedvn0+isWb5akiGq8wfd8QJaG5MqlXffkAp5QEnMtlXKZ8c4UNpedF CmG9F/051IVx+bnCHvBdJBjEQiPnR6B5EcDZ2jKqyeWtYwXVXcma2ojmOeYog/JCtmu2 SmOMuICjV0yQNCLiVUm6U1YLqLH5+8nqQVn5sNqfsJ4v+52TxowyH9nsUs2PnhM986wu bclg== X-Gm-Message-State: APjAAAXrTMdZHsrVS+/pdnGFkiK7R+oiN6k4CcqyGatzrmavABPIN/LR g6iuxWH++f0QuHWeIw4wz6Glf2SJ X-Google-Smtp-Source: APXvYqwt8MRFJCHGmUU5Yk4G0Smkbt9hT4L068TyDR9NhjLldDXVIB7RA5cSxYRPTrtN5dM+SYqYoA== X-Received: by 2002:ac2:568f:: with SMTP id 15mr4050883lfr.94.1551881106857; Wed, 06 Mar 2019 06:05:06 -0800 (PST) Return-Path: Received: from localhost.localdomain (h-158-174-22-210.NA.cust.bahnhof.se. [158.174.22.210]) by smtp.gmail.com with ESMTPSA id o12sm343734ljc.37.2019.03.06.06.05.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 06:05:05 -0800 (PST) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ludovic Barre Cc: Russell King , Linus Walleij , Ulf Hansson Subject: [PATCH 5/6] mmc: mmci: Share sdmmc_variant_init() via the common header file Date: Wed, 6 Mar 2019 15:04:55 +0100 Message-Id: <20190306140456.28187-6-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190306140456.28187-1-ulf.hansson@linaro.org> References: <20190306140456.28187-1-ulf.hansson@linaro.org> It's good practice to share functions via header files, rather than from the c-files. Therefore, let's move sdmmc_variant_init() to mmci.h. Signed-off-by: Ulf Hansson --- drivers/mmc/host/mmci.c | 6 ------ drivers/mmc/host/mmci.h | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.17.1 Acked-by: Ludovic Barre Tested-by: Ludovic Barre diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c index e11fc5019535..2f3a1a7bd465 100644 --- a/drivers/mmc/host/mmci.c +++ b/drivers/mmc/host/mmci.c @@ -52,12 +52,6 @@ void mmci_variant_init(struct mmci_host *host); static inline void mmci_variant_init(struct mmci_host *host) {} #endif -#ifdef CONFIG_MMC_STM32_SDMMC -void sdmmc_variant_init(struct mmci_host *host); -#else -static inline void sdmmc_variant_init(struct mmci_host *host) {} -#endif - static unsigned int fmax = 515633; static struct variant_data variant_arm = { diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h index a76fe1085757..6bde28c9b302 100644 --- a/drivers/mmc/host/mmci.h +++ b/drivers/mmc/host/mmci.h @@ -447,3 +447,9 @@ void qcom_variant_init(struct mmci_host *host); #else static inline void qcom_variant_init(struct mmci_host *host) {} #endif + +#ifdef CONFIG_MMC_STM32_SDMMC +void sdmmc_variant_init(struct mmci_host *host); +#else +static inline void sdmmc_variant_init(struct mmci_host *host) {} +#endif