From patchwork Sun Sep 8 10:12:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 173344 Delivered-To: patches@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp3003139ilq; Sun, 8 Sep 2019 03:12:54 -0700 (PDT) X-Received: by 2002:a2e:9981:: with SMTP id w1mr11435689lji.155.1567937574220; Sun, 08 Sep 2019 03:12:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567937574; cv=none; d=google.com; s=arc-20160816; b=KYuxVJ5mkGI07ULVCmHgZFQpGLN0YnpLzKVEnY3S47n7gidXTwx9MLtswacxQFpk3U TlUcgDFpYQurtrKVPXynFeaFKAIe/GGOj5xzonOxffpdHN/yYgqQdnmHWZQVXQTPaPTy ddcx/Hx1eDx0O3o4X9ZvSC0e2Kyj/pK99GwnmCkpuittlUUKy6UalTv/0SkLKsN7+FBm S92OIbAWDzXDPP4a/VTA/DSuJdmF34U6MWV9GmutLzLvvuhb4r24e/jp1Iu22iM2o8Ln Tat3/CI5/D0348piuRB+D5ZU/aVuZAKxlt+VXbkmFu6oOj0X3ozi+XptpNiHPoNgz8EP 2x8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UBQNfgH478Agi6Qq65UuCm0AdFgtpDY1/4Ukd7tPN04=; b=hlx3lyGZzJaaPsWUas1K22nIRLeZpuYsSBZ7Sf1a8FFJDpbE4YLTRerIGQhGpFwdTD Fsld7D/5t6y5k4PFCMxf72MxPasJaSCPgPlWT/GR6T/fsvTtiOqxQFtaLJuwW7wIluII mwFp3NcfUrfsRxx6q/zllnUk3NHj8m+ZxJvQrbT+QFY8zNHg12DqNpvVQK0//ofXli+c CBNiCJt7Nflmzsh8ZcWsv11t07YzCJ1R9ZI72cd1yPD6yKron+J8eal+KMV83W5RsLY6 vqD+xtnrmyW+4Mt0bwdjn8aX0uS7s5O6xEEcT+VJ/fXGRDDtCP7l4U38mIEQS9w+Uqsy YqTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mcwgjbdp; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 13sor3120823lft.12.2019.09.08.03.12.54 for (Google Transport Security); Sun, 08 Sep 2019 03:12:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mcwgjbdp; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UBQNfgH478Agi6Qq65UuCm0AdFgtpDY1/4Ukd7tPN04=; b=Mcwgjbdp32PK8AZUMsmSzkK40Pkz9/HfpmUTEvkfaXJir+M1fqFP9wGs7zB3qW+3by X5GgXP39/Npz/F+rDuxpX5aPchObiqqORL9ZlkuVhbpwB+GFTVF7lub61Evi0KKMCezt Dqw6YkxkDH/JmWHtRO/poQ31ezNS6Psl/exogXW7T0ppn4elIzW2We2net4M5m9JGbHu g3aACABD48I4MJnMvQk/ClIIG2b67EDRyRtu1/O5m8QGdNBfBol/CPk5DbIfeeHSs8Ap 2nqZDZM+ZAlZEhT9VcPp+fUkBFIMMBx4t5RzmA0fGreFt8Pje7ZKBQ8S/7rcd5abLAY0 0pSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UBQNfgH478Agi6Qq65UuCm0AdFgtpDY1/4Ukd7tPN04=; b=aV9eE4K5zm2s5qYGxsS13GTNXBcaWcCv9TD7CVofYxPHITdyMvaNnIVhk3Qzbs08qu hJ3WBDX8esJJgBZk+/MFu0kZtBu7BLn+3ezB61h6Z1/HuiMKvNaCafducric/wZtnuJ7 CH3PPgoJ9ehr1hJX3E72LS51dY7rE2wIh7Bww4kwhz5Jrjws5+jEWiMjmQRNcHnBXXuX osK7Bllxj+RizRohb3TLTqLjoGKT6bESZXqUP4K0eoWS+5b7/MC0fC2LHydwZ5UCyKaq dRCCaC9oKWJ6nstkpD1ViiiC6DdEnmoUm3vkTWgUlqkKfu9LQPt01Ffd1ZSLbIw9Fo6b dT+w== X-Gm-Message-State: APjAAAV+JMyYFUE15iyVGwRsR/E6h3puqvO7yWm6tc/XF+TqHYLkbxgV 94+j8PzFQduW8pD5zJkGVMQd7R5c X-Google-Smtp-Source: APXvYqwAZcqc8OF77Bx7ciHC787UfAzR/Jk/8p6iWyWeRbk6Ie4qBOLjOvzlPaRvFZEofbuug/3pUQ== X-Received: by 2002:ac2:4a82:: with SMTP id l2mr12357581lfp.85.1567937573894; Sun, 08 Sep 2019 03:12:53 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([185.122.190.73]) by smtp.gmail.com with ESMTPSA id h25sm2444849lfj.81.2019.09.08.03.12.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2019 03:12:53 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson , Adrian Hunter , Douglas Anderson , Matthias Kaehlcke Cc: Shawn Lin , Jaehoon Chung , Yong Mao , Chaotian Jing , linux-kernel@vger.kernel.org Subject: [PATCH v2 09/11] mmc: sdhci: Drop redundant check in sdhci_ack_sdio_irq() Date: Sun, 8 Sep 2019 12:12:34 +0200 Message-Id: <20190908101236.2802-10-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190908101236.2802-1-ulf.hansson@linaro.org> References: <20190908101236.2802-1-ulf.hansson@linaro.org> The sdhci_ack_sdio_irq() is called only when SDIO IRQs are enabled. Therefore, let's drop the redundant check of the internal SDHCI_SDIO_IRQ_ENABLED flag and just re-enable the IRQs immediately. Reviewed-by: Matthias Kaehlcke Signed-off-by: Ulf Hansson --- drivers/mmc/host/sdhci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 Acked-by: Adrian Hunter diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index d814dc004bad..efa6cda8c991 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2163,8 +2163,7 @@ static void sdhci_ack_sdio_irq(struct mmc_host *mmc) unsigned long flags; spin_lock_irqsave(&host->lock, flags); - if (host->flags & SDHCI_SDIO_IRQ_ENABLED) - sdhci_enable_sdio_irq_nolock(host, true); + sdhci_enable_sdio_irq_nolock(host, true); spin_unlock_irqrestore(&host->lock, flags); }