From patchwork Fri Jun 10 21:12:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 581076 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E766C433EF for ; Fri, 10 Jun 2022 21:13:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350878AbiFJVNf (ORCPT ); Fri, 10 Jun 2022 17:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350876AbiFJVNV (ORCPT ); Fri, 10 Jun 2022 17:13:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7824821AC for ; Fri, 10 Jun 2022 14:13:19 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzlwP-0007EQ-A1; Fri, 10 Jun 2022 23:13:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzlwL-007eRR-K2; Fri, 10 Jun 2022 23:13:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzlwJ-00FTci-D7; Fri, 10 Jun 2022 23:13:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaehoon Chung , Ulf Hansson , Krzysztof Kozlowski Cc: kernel@pengutronix.de, Alim Akhtar , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mmc: dw_mmc: exynos: Obviously always return success in remove callback Date: Fri, 10 Jun 2022 23:12:53 +0200 Message-Id: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1171; h=from:subject; bh=BRwj7xwGwlRzPBbTfi1y6IsL5WQeCl3kon3cuPiA4x8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBio7PFmJ2wmL2gWS1HcC1y6c3VYDRsXBzbViHOxx0m f/APl0eJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYqOzxQAKCRDB/BR4rcrsCcIOB/ 9jMfHMsc6Uy0I1iYhcfcv3qVW6zLOx71pr6WjFWokedg82aakk2yg6YD3SYFm0peyZ3gvIoYceuyH6 q4u5fIa6CzL1iORfXmFd4DHJIaOWQZ604o54ZGUdJFv7kcWdKjd7tiLHreOrmRG+mwxvZsZL5u+pp1 RNsxOckrqNwdHEPjTg6yqunaUBwrZ+ruzOM2eDn7lxiczsaUuDVkrTAh0zP/kaEnTVpXxAy0oyl2Fz FvGHFh6B0BuQgZxP/eaxEtK5MCHaegv9wYnzBOSgvBjTBVuyyL8vjBWd0Eql9rloW3UusMJBSJGF8T Hj96drPuyQMmqsOwW4YUsjVn2aPM0f X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mmc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Acked-by: Adrian Hunter --- drivers/mmc/host/dw_mmc-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index ca5be4445ae0..9f20ac524c8b 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev) pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct dev_pm_ops dw_mci_exynos_pmops = {