| Message ID | 20221229200411.295339-9-doug@schmorgal.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mmc: sdhci-pxav2: Add support for PXA168 | expand |
On 29/12/22 22:04, Doug Brown wrote: > Add a compatible for the pxav1 controller in the PXA168, along with > optional pinctrl properties to use for an errata workaround. > > Signed-off-by: Doug Brown <doug@schmorgal.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Doesn't apply cleanly anymore > --- > .../devicetree/bindings/mmc/sdhci-pxa.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > index 1c87f4218e18..09455f9fa8de 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Marvell PXA SDHCI v2/v3 bindings > +title: Marvell PXA SDHCI v1/v2/v3 > > maintainers: > - Ulf Hansson <ulf.hansson@linaro.org> > @@ -34,6 +34,7 @@ allOf: > properties: > compatible: > enum: > + - mrvl,pxav1-mmc > - mrvl,pxav2-mmc > - mrvl,pxav3-mmc > - marvell,armada-380-sdhci > @@ -61,6 +62,22 @@ properties: > - const: io > - const: core > > + pinctrl-names: > + description: > + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between > + SDIO CMD and GPIO mode. > + items: > + - const: default > + - const: state_cmd_gpio > + > + pinctrl-0: > + description: > + Should contain default pinctrl. > + > + pinctrl-1: > + description: > + Should switch CMD pin to GPIO mode as a high output. > + > mrvl,clk-delay-cycles: > description: Specify a number of cycles to delay for tuning. > $ref: /schemas/types.yaml#/definitions/uint32
On 1/11/2023 4:44 AM, Adrian Hunter wrote: > On 29/12/22 22:04, Doug Brown wrote: >> Add a compatible for the pxav1 controller in the PXA168, along with >> optional pinctrl properties to use for an errata workaround. >> >> Signed-off-by: Doug Brown <doug@schmorgal.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Doesn't apply cleanly anymore Sorry about that. Krzysztof beat me to the "bindings in title" removal he asked me to do. Will send a v4 series rebased on the latest mmc/next. > >> --- >> .../devicetree/bindings/mmc/sdhci-pxa.yaml | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml >> index 1c87f4218e18..09455f9fa8de 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml >> @@ -4,7 +4,7 @@ >> $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Marvell PXA SDHCI v2/v3 bindings >> +title: Marvell PXA SDHCI v1/v2/v3 >> >> maintainers: >> - Ulf Hansson <ulf.hansson@linaro.org> >> @@ -34,6 +34,7 @@ allOf: >> properties: >> compatible: >> enum: >> + - mrvl,pxav1-mmc >> - mrvl,pxav2-mmc >> - mrvl,pxav3-mmc >> - marvell,armada-380-sdhci >> @@ -61,6 +62,22 @@ properties: >> - const: io >> - const: core >> >> + pinctrl-names: >> + description: >> + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between >> + SDIO CMD and GPIO mode. >> + items: >> + - const: default >> + - const: state_cmd_gpio >> + >> + pinctrl-0: >> + description: >> + Should contain default pinctrl. >> + >> + pinctrl-1: >> + description: >> + Should switch CMD pin to GPIO mode as a high output. >> + >> mrvl,clk-delay-cycles: >> description: Specify a number of cycles to delay for tuning. >> $ref: /schemas/types.yaml#/definitions/uint32 >
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml index 1c87f4218e18..09455f9fa8de 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Marvell PXA SDHCI v2/v3 bindings +title: Marvell PXA SDHCI v1/v2/v3 maintainers: - Ulf Hansson <ulf.hansson@linaro.org> @@ -34,6 +34,7 @@ allOf: properties: compatible: enum: + - mrvl,pxav1-mmc - mrvl,pxav2-mmc - mrvl,pxav3-mmc - marvell,armada-380-sdhci @@ -61,6 +62,22 @@ properties: - const: io - const: core + pinctrl-names: + description: + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between + SDIO CMD and GPIO mode. + items: + - const: default + - const: state_cmd_gpio + + pinctrl-0: + description: + Should contain default pinctrl. + + pinctrl-1: + description: + Should switch CMD pin to GPIO mode as a high output. + mrvl,clk-delay-cycles: description: Specify a number of cycles to delay for tuning. $ref: /schemas/types.yaml#/definitions/uint32