From patchwork Wed Jan 13 21:25:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101173 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp3615193lbb; Wed, 13 Jan 2016 13:26:35 -0800 (PST) X-Received: by 10.98.80.12 with SMTP id e12mr621295pfb.62.1452720395631; Wed, 13 Jan 2016 13:26:35 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7si4333223pfq.145.2016.01.13.13.26.35; Wed, 13 Jan 2016 13:26:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-mmc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753520AbcAMV0e (ORCPT + 2 others); Wed, 13 Jan 2016 16:26:34 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:62663 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbcAMV0T (ORCPT ); Wed, 13 Jan 2016 16:26:19 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0MfYYl-1aYY7u3QOx-00P7gG; Wed, 13 Jan 2016 22:25:45 +0100 From: Arnd Bergmann To: Ulf Hansson Cc: Ian Molton , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, Kuninori Morimoto Subject: [PATCH] mmc: tmio_mmc_dma: don't print invalid DMA cookie Date: Wed, 13 Jan 2016 22:25:41 +0100 Message-ID: <5032992.kTQ6Oyibpy@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:WDV8QlG67kQwvz8yRG5BDdA8VhxXBMa0tdrOLYXtqEWuMqQZKq1 Og3dapUweGfssOuzmGRcS9ziKKvzYjfjAJ2uFfnYiH3f+VWdg93CSgZWtgwnAQVsrsve428 jkWMnRj7VvWJescUxmKTwVDI1e0pEmmNQhJssN+O0ocWHu4wj6KxZZWsyxXv1krodMKcXrX 3WfKbyZYasveznX1u4bEw== X-UI-Out-Filterresults: notjunk:1; V01:K0:GUxHzd1QZaQ=:s1QIW1hzI2rZZsXt3vGEiR fQ9UigYXQB6gW6cDCqFKFVomKJ/J0fdZaGPrhvhJtrU8MN4+2yqSw1MOkHp072SwfxJY5p0f0 ejzZg26acyPfXEOt6OtgHRvRcOIdf0JQ35AqTK4eZTot/nkbdbW3y7yntZNaIFD6zsJqTfkUo IDG2i0hbc2dWrINxbZTa1zEQKVgAqkcDp9pRHu/n0RYAbGKkg4Pbv91yl0IIMEcqufFOiZMAj P6m41kthSoBQHljucMRbw6BpiXEYGEmDKNVQwOAVDYP067WxzgX07kieqWYeo7NSsjOAUh2+p 9Hk0y/YjSeo/gAa/r2Y3emqcQx4CiTdPwjl7aVSvoXC8+3jdC2xwOY6EMpZ5ohoHovfDp3ttY 9px9ld5ntsXxGFBG1HzDro0KicCmSwq4y2WOQ0NPWp+D+bF4/X/8npzMj1rrA3dBbIyax/2BJ vRFzkJ6UR/JtgYaKzXXjqXZAC9fp2965wn2js/YJWjOilSUrqida5YfuLaWh1aYcFFiyqRtob i0ednzy8S3+Q3CwcteqnwEVPTF6XFOiOFVNZ466Xi57dRLBT3Ps6Ig51KKGOvQmH2tR2P5cNW Jyoek92mrbOMTxKHzQ1UbrBZ0UjiKYaltS+BOm5X3HHRVLu9+3hW6eQCNny2EN4kNtfRz+J4X I+vfivwa5aovwYtkyPVWK2QT55LWmML9ejmltUxCzJoZExQ+d55y5hCrbzuSIsP/vkOaL7S3m 6qaYNfsY0TsKSNRs Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The tmio_mmc_start_dma_{rx,tx} function functions contain debug code that prints the dma cookie among other things. However, in case we fall back to PIO mode for some reason, the cookie variable is never initialized, and gcc warns about this: In file included from ../include/linux/printk.h:277:0, from ../include/linux/kernel.h:13, from ../include/linux/list.h:8, from ../include/linux/kobject.h:20, from ../include/linux/device.h:17, from ../drivers/mmc/host/tmio_mmc_dma.c:13: ../drivers/mmc/host/tmio_mmc_dma.c: In function 'tmio_mmc_start_dma': ../include/linux/dynamic_debug.h:86:3: warning: 'cookie' may be used uninitialized in this function [-Wmaybe-uninitialized] __dynamic_dev_dbg(&descriptor, dev, fmt, \ ^ ../drivers/mmc/host/tmio_mmc_dma.c:128:15: note: 'cookie' was declared here dma_cookie_t cookie; This modifies the dev_dbg() statements so we only print the cookie when we are already in the DMA path. Signed-off-by: Arnd Bergmann --- This warning has existed for a long time, and it's only in debug code, so probably nobody cared. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/tmio_mmc_dma.c b/drivers/mmc/host/tmio_mmc_dma.c index e4b05dbb9ca8..4a0d6b80eaa3 100644 --- a/drivers/mmc/host/tmio_mmc_dma.c +++ b/drivers/mmc/host/tmio_mmc_dma.c @@ -94,9 +94,9 @@ static void tmio_mmc_start_dma_rx(struct tmio_mmc_host *host) desc = NULL; ret = cookie; } + dev_dbg(&host->pdev->dev, "%s(): mapped %d -> %d, cookie %d, rq %p\n", + __func__, host->sg_len, ret, cookie, host->mrq); } - dev_dbg(&host->pdev->dev, "%s(): mapped %d -> %d, cookie %d, rq %p\n", - __func__, host->sg_len, ret, cookie, host->mrq); pio: if (!desc) { @@ -116,8 +116,8 @@ pio: "DMA failed: %d, falling back to PIO\n", ret); } - dev_dbg(&host->pdev->dev, "%s(): desc %p, cookie %d, sg[%d]\n", __func__, - desc, cookie, host->sg_len); + dev_dbg(&host->pdev->dev, "%s(): desc %p, sg[%d]\n", __func__, + desc, host->sg_len); } static void tmio_mmc_start_dma_tx(struct tmio_mmc_host *host) @@ -174,9 +174,9 @@ static void tmio_mmc_start_dma_tx(struct tmio_mmc_host *host) desc = NULL; ret = cookie; } + dev_dbg(&host->pdev->dev, "%s(): mapped %d -> %d, cookie %d, rq %p\n", + __func__, host->sg_len, ret, cookie, host->mrq); } - dev_dbg(&host->pdev->dev, "%s(): mapped %d -> %d, cookie %d, rq %p\n", - __func__, host->sg_len, ret, cookie, host->mrq); pio: if (!desc) { @@ -196,8 +196,7 @@ pio: "DMA failed: %d, falling back to PIO\n", ret); } - dev_dbg(&host->pdev->dev, "%s(): desc %p, cookie %d\n", __func__, - desc, cookie); + dev_dbg(&host->pdev->dev, "%s(): desc %p\n", __func__, desc); } void tmio_mmc_start_dma(struct tmio_mmc_host *host,