From patchwork Wed May 14 12:35:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 30162 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8CE2920446 for ; Wed, 14 May 2014 12:35:46 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id z6sf6495716yhz.5 for ; Wed, 14 May 2014 05:35:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=qeYLsRYmJrlOWw04ccZe/je0KgIjZ02wM3JJI2J156c=; b=nE0jO/NVRY76aKehHlT6g8OWTXmF9Il/C/YI4Mmbt12VT/uuiqolODUtlQNOb07w3I jI37h2RXxgORLrEFgC6YHcXen+bxoVrVAw0TgisRT7dD2MfkjSnLE8eDxbQm9o3/1Ps4 skcIqw8zaJrD4k9vyrwT0syppqdhXTrLn6aWn0ItiVVWa3/InuK7QhrTCTDn4ILJIImb wAeSqJ3tj1qogfljYqyxpY1DTxzedEgNePDLw7alyaaU8BWiR6vGvq4Gtn/jvaBznux+ fKx6gVi9SBUiYSZr5YAFChBqpYD2wLBO+1XPgCkLqFFY1OWmXV5QzmAWz3rA4xpZHfxI 8pAg== X-Gm-Message-State: ALoCoQkNjdiopBIv8eBpTeWFtCYC++l3bhBuU8XmYoPpivi7OMWm8HS1+2EoQxMMSQKgB98AEZIj X-Received: by 10.236.92.15 with SMTP id i15mr1320455yhf.8.1400070946330; Wed, 14 May 2014 05:35:46 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.37 with SMTP id u34ls2453960qgu.4.gmail; Wed, 14 May 2014 05:35:46 -0700 (PDT) X-Received: by 10.58.195.231 with SMTP id ih7mr2878653vec.32.1400070946209; Wed, 14 May 2014 05:35:46 -0700 (PDT) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by mx.google.com with ESMTPS id z6si308938vcm.9.2014.05.14.05.35.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 May 2014 05:35:46 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.182 as permitted sender) client-ip=209.85.128.182; Received: by mail-ve0-f182.google.com with SMTP id sa20so2271526veb.13 for ; Wed, 14 May 2014 05:35:46 -0700 (PDT) X-Received: by 10.52.22.13 with SMTP id z13mr2537322vde.10.1400070946118; Wed, 14 May 2014 05:35:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp236418vcb; Wed, 14 May 2014 05:35:45 -0700 (PDT) X-Received: by 10.68.189.68 with SMTP id gg4mr4191679pbc.42.1400070945403; Wed, 14 May 2014 05:35:45 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rm9si903801pbc.208.2014.05.14.05.35.44; Wed, 14 May 2014 05:35:44 -0700 (PDT) Received-SPF: none (google.com: linux-omap-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755455AbaENMfo (ORCPT + 6 others); Wed, 14 May 2014 08:35:44 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:59546 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755075AbaENMfl (ORCPT ); Wed, 14 May 2014 08:35:41 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s4ECZF5a013120; Wed, 14 May 2014 07:35:15 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4ECZF0W031391; Wed, 14 May 2014 07:35:15 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Wed, 14 May 2014 07:35:14 -0500 Received: from localhost.localdomain (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s4ECZCo4001923; Wed, 14 May 2014 07:35:12 -0500 From: Roger Quadros To: CC: , , , , , , Roger Quadros Subject: [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards Date: Wed, 14 May 2014 15:35:08 +0300 Message-ID: <1400070908-2929-1-git-send-email-rogerq@ti.com> X-Mailer: git-send-email 1.8.3.2 MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: rogerq@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Commit c66d039197e4 broke NAND for non-DT boot on all OMAP2 and OMAP3 boards using board_nand_init(). Following error is seen at boot [ 0.154998] (null): Unsupported NAND ECC scheme selected For OMAP2 and OMAP3 platforms, the ecc_opt parameter in platform data must be set to OMAP_ECC_HAM1_CODE_HW to work properly. Tested on omap3-beagle c4. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-flash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/board-flash.c b/arch/arm/mach-omap2/board-flash.c index ac82512..b6885e4 100644 --- a/arch/arm/mach-omap2/board-flash.c +++ b/arch/arm/mach-omap2/board-flash.c @@ -142,7 +142,7 @@ __init board_nand_init(struct mtd_partition *nand_parts, u8 nr_parts, u8 cs, board_nand_data.nr_parts = nr_parts; board_nand_data.devsize = nand_type; - board_nand_data.ecc_opt = OMAP_ECC_BCH8_CODE_HW; + board_nand_data.ecc_opt = OMAP_ECC_HAM1_CODE_HW; gpmc_nand_init(&board_nand_data, gpmc_t); } #endif /* CONFIG_MTD_NAND_OMAP2 || CONFIG_MTD_NAND_OMAP2_MODULE */