From patchwork Wed Mar 22 20:07:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 95849 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp415652qgd; Wed, 22 Mar 2017 13:18:26 -0700 (PDT) X-Received: by 10.98.33.155 with SMTP id o27mr27154453pfj.5.1490213905942; Wed, 22 Mar 2017 13:18:25 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [65.50.211.133]) by mx.google.com with ESMTPS id x5si3013396pls.60.2017.03.22.13.18.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Mar 2017 13:18:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) client-ip=65.50.211.133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 65.50.211.133 as permitted sender) smtp.mailfrom=linux-mtd-bounces+patch=linaro.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=cFiKhxZcc3DkqABmDBl72SEMaNolQgZ3BZauZ6mJuTU=; b=byecvXqv5czPLfn4Xyljpwwm7p B+HCMDymkzRRBv7xZ6lMOSD51hpMkiNGD63ECTc+iWCboTWmWRjBSfrnG0AtmhJYBLsS4pPuvKhFF YnLmzwRUpInra3nejJe6aK9jIXeNunLw+6cD0V5AV9dBRHivC2rpcMQDXcrqIA+o5X+53xNdE7pmt mtbYx/9ANmRNinvmizfNpFKnYca05+kWS/Ap4IzjjQ2UFhDi/vRWtBPQF5VTzw8c9DIHwgSGvSmjm +cmyADxMl2FsPIqnoh2KidYlCUUyxp0wmfjVTiEGtpl//TSglRMrm8zTZrt3xE2detXtv595+FI+G 8eYzlATg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cqmi4-00073J-7e; Wed, 22 Mar 2017 20:18:20 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cqmZV-0001SR-3c for linux-mtd@lists.infradead.org; Wed, 22 Mar 2017 20:09:30 +0000 Received: from grover.sesame (FL1-111-169-71-157.osk.mesh.ad.jp [111.169.71.157]) (authenticated) by conuserg-07.nifty.com with ESMTP id v2MK895x029452; Thu, 23 Mar 2017 05:08:29 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com v2MK895x029452 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1490213310; bh=6+m75OZlPBI+hfQ0sp61KS0/EN+hKn2K4d9pI5zhNHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YvbQG0/q6rjhxybtExC9GFc2raXs00Uz7q3DJd+AEhuLr210KKa8dzHQyMQbXUyl4 w6gUGTeETZ0lGWFFFvnpOGH6aHRBAVFTwa2HdbuOuz6PC6XKUAz7UfZBaIZT8TgU1I Hkh5x8s7tAENmZsf4zavRLzQXNx3/HbfuBnp8ejG4FisKjiM6yGkZ2Ymi/AJAyvpTV 3pUZ3x9EED8M8/U+RVxYl7KtpFITmDzFYYLd85xp/xZvZPmgsd2sC10F6eznNBkbF4 l4mfibajRzddhrDiDpa+h2ukN9i7HvH2BnfqHPJ5/0g0w6hAXGfLTKdOAifElhqh5D JtjhmbgFTRkEQ== X-Nifty-SrcIP: [111.169.71.157] From: Masahiro Yamada To: linux-mtd@lists.infradead.org Subject: [RESEND PATCH v2 09/53] mtd: nand: denali: use int where no reason to use fixed width variable Date: Thu, 23 Mar 2017 05:07:08 +0900 Message-Id: <1490213273-8571-10-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490213273-8571-1-git-send-email-yamada.masahiro@socionext.com> References: <1490213273-8571-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170322_130929_449169_27EE2985 X-CRM114-Status: UNSURE ( 8.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.2 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: laurent.monat@idquantique.com, Boris Brezillon , thorsten.christiansson@idquantique.com, Richard Weinberger , Marek Vasut , Masahiro Yamada , Artem Bityutskiy , Cyrille Pitchen , linux-kernel@vger.kernel.org, Dinh Nguyen , Masami Hiramatsu , Chuanxiao Dong , Jassi Brar , Brian Norris , Enrico Jorns , David Woodhouse , Graham Moore MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org The page number is generally stored in an integer type variable. The uint16_t does not have enough width. I see no reason to use uint32_t for other members, either. Just use int. Signed-off-by: Masahiro Yamada --- Changes in v2: None drivers/mtd/nand/denali.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h index eed001d..7b2d785 100644 --- a/drivers/mtd/nand/denali.h +++ b/drivers/mtd/nand/denali.h @@ -325,7 +325,7 @@ struct denali_nand_info { struct nand_buf buf; struct device *dev; int total_used_banks; - uint16_t page; + int page; void __iomem *flash_reg; /* Register Interface */ void __iomem *flash_mem; /* Host Data/Command Interface */ @@ -335,9 +335,9 @@ struct denali_nand_info { uint32_t irq_status; int irq; - uint32_t devnum; /* represent how many nands connected */ - uint32_t bbtskipbytes; - uint32_t max_banks; + int devnum; /* represent how many nands connected */ + int bbtskipbytes; + int max_banks; unsigned int caps; };