From patchwork Tue Mar 12 08:44:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 160061 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp12851201jad; Tue, 12 Mar 2019 01:46:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqz50YaMvawXBz+B2OyRGWO6oTLULwg465YJlkYIqdN0Obeu57ARAWmq7viSigIqmCWjNTaV X-Received: by 2002:a65:4244:: with SMTP id d4mr34439833pgq.419.1552380363272; Tue, 12 Mar 2019 01:46:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552380363; cv=none; d=google.com; s=arc-20160816; b=szsA7toMC7XjFs9vlAIx5H3zSLhA1zWA4INpjiqVaPhpYj8Q4r/4RMhi8U249cTqpI 6XxYLH+bzQSvdn336D3O1cd6DBICo6Z8uP/ZPYbXSCsGb+wo3znPXHE5VyITsmTohdNu g8nGSpEJFKAY4b0kFzskZhbS4OHb9y2jiilyvG7W8kfnRC8SfsXkY3Ci0PAWtdsXkclL MhNFDHi9kNdrEfWW2krzaEm1uEaBZz+1WxooatuGAi7u0uBP2VpN95bx1nfSyCqCkqec BMxdn/iR3+FNnXd2Tts9OnAzer22IuK8YK5a+Xi4OpPKt5Id6mshEUJ+SBHbnpCPxsr6 y+FA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=VvZexAzc5bc29uNfvht+5rnO3SWZj17nuYw/wqj3LpY=; b=rwiXGQiwUfP24Iv00LixJKGeTa7cE2HcIbMhwptJt+ZWp9UgZtkDkK9+L3zBQ2F20e 1HWBBz1lALB9lj4EulHViK6KksxYeXXTGPLNVVPaTkQqNISq7RcZVmFSjwrXc3d7AaGX OvQtfPSBqtLDDY1IgFU1rIOn6T+8CVFlc4SzAO+awbbwiFfKEBf0TdEoHW4DAawkzAEw F2qWjx5A/wb8SVWfkx9K6C0ztwel7v2LtL5RYnbs23ceZzrnseXPNgEUH55+oUgmBda1 Bw9lhXBF5rLH8xa3O1pivydRBECe0pu4rRRbn1mbI/tpgwBzYpSoVuOAJNeshPLQKTAZ QHDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=qFZ30U31; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=f60oHmXc; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id c2si1042306pll.317.2019.03.12.01.46.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 01:46:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=qFZ30U31; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=f60oHmXc; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=VvZexAzc5bc29uNfvht+5rnO3SWZj17nuYw/wqj3LpY=; b=qFZ30U31L78HTFGZgZtnDSivQs vuMSKADANO+dvmUJjZWggOelobPmdoqGbxq5FF6f2jv8u81KjlGovaJf6vtYOx4AKucn7gsNtDt/a 1QmN6R+rjLV4T7I1VsjSKKrWzcTKvZSuZOCBqnbuXlTHV0ax+OTyHMJ3Nsq6NGSAJO81uWila9rn5 IKQF66XZ4L3RIfputCRn6PYFDGt9YeuetZoI7266PGY3R/lnk3EbPEk/V2jSGJBluBJgzSiBwpwTa 5rt79GYVb+5F8MKvWptPqF4KS4FlqMSzu8NJRjRwpxvJwGaxoDOUA5vn4k56b3K2hlIVnDxGbJZTK wHhpeSJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3d2i-0000A8-Kr; Tue, 12 Mar 2019 08:45:48 +0000 Received: from conuserg-09.nifty.com ([210.131.2.76]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3d2e-000075-IV for linux-mtd@lists.infradead.org; Tue, 12 Mar 2019 08:45:46 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id x2C8j6Zg004092; Tue, 12 Mar 2019 17:45:20 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com x2C8j6Zg004092 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1552380321; bh=/HYOG6Znx3tjMAy9o8VQey5HBdroa+Gr+dhg2Ya6JXI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f60oHmXc6d/J1BcGZuZ+ww2rj+8Hnvq1sLh94PruRHLVGt8yaHlZjshFOg8TOyH0e na2Ca3Du4Up5H+TCAlUqN/33pYIXGZxuO7iNNfxGDCFco+W8idhtgvIa9r7EmHBlAI VU+Z4+8XqsLiyz7F8TyS+etj1lOplPtCUVSLh2cke0Defh1Rc/La9aoqxvQ7tFuUq+ Eg8i8Pee9+fbk7hSBDCsklumJ2XTkf9YjP49RxYYIum1nmxwFHNhfOAxjxGooghe39 yKZhWgowpvZLtX6DekWaQbXROoO1OelRVIZAhzrG5OqDSX7YceI7zOwN62Ssvz0SU+ dbqWARCGnau5w== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH v3 6/9] mtd: rawnand: denali_pci: rename goto labels Date: Tue, 12 Mar 2019 17:44:47 +0900 Message-Id: <1552380290-19951-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> References: <1552380290-19951-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_014544_932059_CD122823 X-CRM114-Status: GOOD ( 11.39 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.76 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 48e9ac5..02eb599 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -84,20 +84,20 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap_nocache failed!"); ret = -ENOMEM; - goto failed_remap_reg; + goto out_unmap_reg; } ret = denali_init(denali); if (ret) - goto failed_remap_mem; + goto out_unmap_host; pci_set_drvdata(dev, denali); return 0; -failed_remap_mem: +out_unmap_host: iounmap(denali->host); -failed_remap_reg: +out_unmap_reg: iounmap(denali->reg); return ret; }