From patchwork Fri Mar 29 07:28:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 161398 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp1696556jan; Fri, 29 Mar 2019 00:29:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuAqq23Y9iMEGv74dom1SXnxf2e3qOtA5gbMfZgtAIIy8WfwZUJ3fXxlYtUpr//WnZObsH X-Received: by 2002:aa7:8a87:: with SMTP id a7mr46998478pfc.252.1553844561447; Fri, 29 Mar 2019 00:29:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553844561; cv=none; d=google.com; s=arc-20160816; b=cQdx0py9tL+lFFhimBG0nGCwqNaCJBYi2pSxsbBMm3eWdu8XpcTbizo6KwMJ1qQO2X rh0HlZfNZpd4AOqD4ZEp+JHXIS5kfCoBImNFeKltetNlcf6g7cYl3qSEDACHp3kCEGc6 VVUrKiVslJTfx97TpOznklKnAPC3DdPFciEisuECVzKynW5K0ou+iATgsTul3N80SoBh FRnIJby7KSVPZO+A5gTrw/OvfaIdnc9LyBZInKYkqX3xpUVAUbJBTv2GR4goe1KGxAl8 0DnsfZtYOVLhngP+TkOk7NCQmi8XnRMt2Wg42CVcj4IWs7d3HH0yqOzq/fVFtu+tsoEj /L5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter:dkim-signature; bh=BNakdtxPN5x2PHU7C3oYi0hw42xsLoQpurppNH1Z0oc=; b=n+DqGaTjs/1wJa8iZtqbNYn9ILH65VrM4ZIKfSnFTA6GSir+RPfUJMI4be+4rHDfSH xykhb6N8Z270v3RA98uH9zZZYz0+7z1w8DxY6PYYcGYnWvYjHZ/pGxGgvcVr16c1ZcPq cgAFgCc6eXUwEK8XH2E+5UmGL538eauAraNOF0tDEHbt/imfUGhokcPXfpWJmT8+TNMR vnZ92Sp/3scb7vSc4ce6xciqz4+F/zqn/fpP8Pajmz4KEuBH98Q7QLE+j5A1+byKYYZt VzYSpXU13f4GsvpEHkdRt8YAxNSxVnZVdEAIxpm3hhN/1FQhT7FVmbWNIXIwSHUnXtez x0iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=tFldy1l0; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=x0unXnVM; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id h66si1299583pgc.537.2019.03.29.00.29.21 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 00:29:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b=tFldy1l0; dkim=neutral (body hash did not verify) header.i=@nifty.com header.s=dec2015msa header.b=x0unXnVM; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=BNakdtxPN5x2PHU7C3oYi0hw42xsLoQpurppNH1Z0oc=; b=tFldy1l0begDLVmyygMxrsvlmv m1438Nj8mBKjVZIcd5ONExYQodUzDUfi7hDFkQKpjDk9JN1NNddiVC0GRJoCkRb7j33db8g5SmrZL hJxR1MaKQy7bKY1I7ErqWBerWYB3BZ5oVY7WVaj3XoVvYuADfRzItUZruMhw+xaUw5KeGyepfpKvK dryDXQ1OQi1e/xRsAKz3ughhmEAKl/nG4rWqxtjSk8pIu67063KilJh66U6sL3RBDI7Jicx4PAKl+ dQ99OPq3s8m9a/R/ltVF3JK42XOurDgnecyvsYT4DcUMLB4yEqk2F6BazlamBTZtzc3S+g+JrFxzt D2uJyqXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lwt-0004uA-6Y; Fri, 29 Mar 2019 07:29:11 +0000 Received: from conuserg-10.nifty.com ([210.131.2.77]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lwY-0004Q0-3O for linux-mtd@lists.infradead.org; Fri, 29 Mar 2019 07:28:53 +0000 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-10.nifty.com with ESMTP id x2T7SQaD002537; Fri, 29 Mar 2019 16:28:32 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x2T7SQaD002537 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1553844513; bh=BRBvSJ4W65C/fPjveY5umdo5eBXm18HEgOWm+EkOD7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x0unXnVMr9Cy58s7P8cByEoY3byAv10ixm490Y5dvO8ih/ozmRirL2QF/oTQKM5Ms yiCyTKLBwt/RgaUPrYJbyogiPfd8lmHNEkRwN7CvJydf6hyNFRBgT7jcY7K6Nc7kQk 47wf+GJvPnqrJrqM8wlxKtC+Q18rZOkRgsUevqS3TOr2o6ydUcPzNlEv8qvKwsbrYK 7KlR9PKmn4i5NDFz9YzMD6blb6XuXAgqRIOe+CVrsuSYGQOu0c0IQ9+e0Qr9/i/uYj QNEFIucpBCTBPaQqkVV3IGI3z5kBGebdzMowmlensaxkH6+bt12ewPUz2onM+Pa/gy mO+RBY/fgEPoA== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH v4 6/9] mtd: rawnand: denali_pci: rename goto labels Date: Fri, 29 Mar 2019 16:28:18 +0900 Message-Id: <1553844501-7119-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553844501-7119-1-git-send-email-yamada.masahiro@socionext.com> References: <1553844501-7119-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_002850_460931_06115016 X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [210.131.2.77 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Masahiro Yamada , Brian Norris , David Woodhouse MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 48e9ac5..02eb599 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -84,20 +84,20 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap_nocache failed!"); ret = -ENOMEM; - goto failed_remap_reg; + goto out_unmap_reg; } ret = denali_init(denali); if (ret) - goto failed_remap_mem; + goto out_unmap_host; pci_set_drvdata(dev, denali); return 0; -failed_remap_mem: +out_unmap_host: iounmap(denali->host); -failed_remap_reg: +out_unmap_reg: iounmap(denali->reg); return ret; }