From patchwork Thu Sep 5 16:17:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 173162 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp935282ilq; Thu, 5 Sep 2019 09:18:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkZEwB4Cbrg4gVsAhqvad7IOYTzgQvZbAqxc6B2GKRlNyrjY6+Ke8Knzp8CCKlbkOkE5m6 X-Received: by 2002:a17:902:20cc:: with SMTP id v12mr4066972plg.188.1567700308036; Thu, 05 Sep 2019 09:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567700308; cv=none; d=google.com; s=arc-20160816; b=nGlAc7najJSucI3D0Hp0uSKVgdwoHgm7ssCKL8xg7kTsbpeT7yVJZI5jPTiE6IryTV Pvw13T1x4u8zyLdD6UWL+X7njuQtT/cbGt8XubgwpVka/MgKcQ/uUHcpFeTehfmH54nJ hdTK7pkPXwk1KY/1yrv2EA+C92KcwzPrPYjDkM5K6ZCmVKlPUa6iHQUXeqMbAk8gIZwB DmdvRgWGfil+A0qT1tR+Hdl2gdh3LLCgiOT0O9NUSEvOC0FVPEMVHKQnzry9dPml7pV4 f2Ck8w3/WebpGAAZbHy8kifF34TBQFlOqwRO4RW6gnGzL6FGK4abaf4OQ4c1+3C2XKBS DAPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-signature; bh=/XaHFOIo/TbzCv12WcAzspOCirY4HjKwtxjVWgdE4qI=; b=PLXdyZNSekvufw+7l1U7tt+4wR9Nfikai7jhzzYtcpAvBZ9EvfQFVEJGQm5icPL3cZ m7xBYyqxUgyjyb1hEg72zKw4hEXsQlycGRi/L0yos+zxXKpxjbewyv+ka0QPAXHBHagp egVLiepi85i6dqfFU87gcOd3dQ1VILJN762JcmdWvZl+lEMHNuPP9w9kjqTFDwSsCj7F fvGEBJzZp+JDGPWLz37KPtCuVtlEdLKMwER3m9CXzjw/siu4RXq2ZDdYxwHDo4VoYLgB CBj2Y1Pm0pbsX0kHjyhcf9qZwEAsBprK7craN6hgJ0wgggf2FdfaxXUDJEK+D3eVuKuy p9mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b="bBtN3/5J"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="O3tNCt/W"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id c9si2399231pjo.109.2019.09.05.09.18.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 09:18:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20170209 header.b="bBtN3/5J"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="O3tNCt/W"; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/XaHFOIo/TbzCv12WcAzspOCirY4HjKwtxjVWgdE4qI=; b=bBtN3/5JI16G1YCxPW1484P9mw 1Iyfj8pFbSfXGp8CMNgb+7a8I7S4JuVFdDOXb8Zw1kbEgA/co739Io8V1rvbpK68QbJMLXSddM0n8 iWfdtjJY4NqMmpnW9TCpNQvYOz9OFe42BGO5hcf5ThW+cwFQGaU1XT77kjdvYmm2wRrCAov9PXDV4 YvWt/8/E2pzGXJ/JSnExzbDrHlU8CDzkopCx9762snuHA4NRrQ29Z3luMVSWeFhQQFzbIrIh9Ako8 n8VBiHOcVRgrBvNFY7FZLh3SPcuMwoXHL5XvHUQ4rhn51jFGl5C2KywDwYeffDkr5LuFMTl/WYNN7 9K3Y3ryA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5uSo-0001MV-VL; Thu, 05 Sep 2019 16:18:27 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5uSS-0000pe-70 for linux-mtd@lists.infradead.org; Thu, 05 Sep 2019 16:18:05 +0000 Received: by mail-pg1-x541.google.com with SMTP id 4so1661989pgm.12 for ; Thu, 05 Sep 2019 09:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MSiwBcSQD+D+YdS5Q0qHybng0VxB5Rm8vXeXQFjLMZc=; b=O3tNCt/W9wLVtkbdnd5ZHoteegcojqCr7hKVqHkZxaUlxVn/YzfA6HZZ40nBdnkoAO ZhrB0iw1Uc7D91gKUNEFUts4aaIwRfLc9HFFMibqH7dcc8fRUXz52KMfGwZDlccDJJiE RKX9AyFqS2JsIHjGGXMBX/BZ1YMB9oSdcvYb1l/YwNtkOv1/bY7a0taZGatIUTZLB8B5 qoHjnHc9HvsJyTbTAEzBV36syWkgm7Xqp77PJV2mZ8WayBu5mJr3U5qaAjISS8G7GYPD EdmiI92amAdqbvyv4IrbpfYnerC9XFLioXTmFRbJMwAJ7YCYhVi9YGHLHFzUt0cn8dd8 c2lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MSiwBcSQD+D+YdS5Q0qHybng0VxB5Rm8vXeXQFjLMZc=; b=aoEW3FKdu5xE7HpL+66CQmqqqFWn/CVDRrur0OnScgPRetvrf0Dw8SdJ80BECB04LK Y9dk0Xe1+slRqQkm+/E3lQI9ymC8KM9A5XC64oRfvSwPoBRJj2cMaUYZ0IM4dhZ8JIIH fUZ5ngWU8j3iwEclG1rtzmNU7ODbv0IJtT1UH3N0qP5YO/rHWH/A+SRYGTO344iEmvAp ANFQ7rMlv7EwgH6jYJggJ29Rep90AZFOPbBfYZMtAXbQAsBw9ikmPHTqYzYQxmzNc1Zs IrNnGgrjgCcL7V85oZJEXha1Iim5EKJioOj3BSANLIZ0Gmg1/8F/63EdRDH1OqCXeDNn F6iA== X-Gm-Message-State: APjAAAWDSbovcSaUhTlxZ2URrZV9xxvQN/EUwhom9slq7FvjftTRslzV Gvi77GC7mGjsOA9YtYIt93Ei4UwBAPw= X-Received: by 2002:a65:684c:: with SMTP id q12mr3654124pgt.405.1567700283561; Thu, 05 Sep 2019 09:18:03 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id m129sm6324005pga.39.2019.09.05.09.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 09:18:03 -0700 (PDT) From: Mathieu Poirier To: stable@vger.kernel.org Subject: [BACKPORT 4.14.y 02/18] PCI: dra7xx: Fix legacy INTD IRQ handling Date: Thu, 5 Sep 2019 10:17:43 -0600 Message-Id: <20190905161759.28036-3-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190905161759.28036-1-mathieu.poirier@linaro.org> References: <20190905161759.28036-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_091804_252907_2D16F3F1 X-CRM114-Status: GOOD ( 12.09 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:541 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org From: Vignesh R commit 524d59f6e30aab5b618da55e604c802ccd83e708 upstream Legacy INTD IRQ handling is broken on dra7xx due to fact that driver uses hwirq in range of 1-4 for INTA, INTD whereas IRQ domain is of size 4 which is numbered 0-3. Therefore when INTD IRQ line is used with pci-dra7xx driver following warning is seen: WARNING: CPU: 0 PID: 1 at kernel/irq/irqdomain.c:342 irq_domain_associate+0x12c/0x1c4 error: hwirq 0x4 is too large for dummy Fix this by using pci_irqd_intx_xlate() helper to translate the INTx 1-4 range into the 0-3 as done in other PCIe drivers. Suggested-by: Bjorn Helgaas Reported-by: Chris Welch Signed-off-by: Vignesh R Signed-off-by: Lorenzo Pieralisi Acked-by: Kishon Vijay Abraham I Signed-off-by: Mathieu Poirier --- drivers/pci/dwc/pci-dra7xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.17.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c index 63052c5e5f82..7f5dfa169d0f 100644 --- a/drivers/pci/dwc/pci-dra7xx.c +++ b/drivers/pci/dwc/pci-dra7xx.c @@ -227,6 +227,7 @@ static int dra7xx_pcie_intx_map(struct irq_domain *domain, unsigned int irq, static const struct irq_domain_ops intx_domain_ops = { .map = dra7xx_pcie_intx_map, + .xlate = pci_irqd_intx_xlate, }; static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp) @@ -270,7 +271,7 @@ static irqreturn_t dra7xx_pcie_msi_irq_handler(int irq, void *arg) case INTC: case INTD: generic_handle_irq(irq_find_mapping(dra7xx->irq_domain, - ffs(reg))); + ffs(reg) - 1)); break; }