From patchwork Fri Nov 6 21:36:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320826 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp1650550ilc; Fri, 6 Nov 2020 13:38:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyWtL65xGnc8B9MbyoxWBv/l9KUR1+MXbMvzkCgdRk7CJRDLdU3knGJ9qmSZpiOgmIc5RM X-Received: by 2002:a1c:b0ca:: with SMTP id z193mr1593146wme.82.1604698712674; Fri, 06 Nov 2020 13:38:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604698712; cv=none; d=google.com; s=arc-20160816; b=xGWbmP3B0sbiHedaA4StcLGlla09pg3HvnTwXHXbPZ4mJmkzvvvPb8ZaTykQiMPFvL I0HOGOp4skvnMQ57t7dtqAT7bkyrYZoejtCwtKwF2uzFexMsUL3eFwoZDjZsKo33kNVw LwP1WVu05hwjofgnY0N9cpHY9NDQ0nyqc3GczFu0GLjt2++/7kZ0cNaDaqaMs4GNQt7z 0yiOYSvXEX3giVemIDmrZKvtmLcfHUCfCbXhGn8npI+e878IvE1Qbu7/s89Wz1x3nzub lDNTWm1czhYjHntei8wbP8w8KENM6UpxGurdIXSFBbH1FaeA1LZttUTTRRCDo748MCzb ODrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:dkim-signature; bh=RlXXchyRQEZZcaZqSiooFaDc8K98hvNj5TPVnE7Pr3g=; b=xLzWfpGNCUbNdh0sIvRzMDNm9Xq8wQb7LC26U3Psq24VFXzFyHNXX0pvnvJ8lFUHQ+ E+/SrRSDTBySd/XPNbHhvIDAVpxEkmAJoMmTl017yGJOTfzxBPno6uvoz9vVpELS+2zQ y4ieMBuc7ejbbrY7ftraHT5RONDLwAxl7wqw6kReli1DwMZJVOhlKE/FjdEDF4LmQ2gP wgdcsVbqj8TRrrBMUFKVu0aIe3/xlWS9efuxQ35s+yNiy5L8DnEFeZWxXzFWwpjRvHjs PBVX4t/ujESYB5kcsjaH7DW7XIrnq0rRcEZ8FcMtx2Y63ES9eMVQQOoioc7mvigCv9Hz y46w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=QHMCZfpE; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=zCmBXWoZ; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id w13si2405033wmc.28.2020.11.06.13.38.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:38:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=QHMCZfpE; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=zCmBXWoZ; spf=pass (google.com: best guess record for domain of linux-mtd-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RlXXchyRQEZZcaZqSiooFaDc8K98hvNj5TPVnE7Pr3g=; b=QHMCZfpEW+LrrfeQnBxcnaSxa m7C+IuMX4tXiI85mmGNgL7LHKHmkTWhKSp4KCX5o2xjcIpwLjbymfJbPIPHLbQgWvfnzarfFXO38f YUXe+nM3jJoOu94t4YjC8iCpYXY6cZ+7R2bFX8i6Q321+42xMiYrfJ/RCRoE5AOFXLSoL02aK1HcO EZlCR14f8rlXd/H2VigGtqqhbdzN4LyoQPPdAE38dppIRdeWKSRTh+Z8OQV7JvVBREis5trd1Thyo HA6gCoyb9wScypaiiH7iuLkFdJosEy+dokht00iOIhru/KHJNhSB6VONdmQ+FrQIH4SJs8FJCzQWA oi4ajJBIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb9R4-00034X-4v; Fri, 06 Nov 2020 21:38:18 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb9Q3-0002bv-Mk for linux-mtd@lists.infradead.org; Fri, 06 Nov 2020 21:37:21 +0000 Received: by mail-wr1-x442.google.com with SMTP id w1so2768825wrm.4 for ; Fri, 06 Nov 2020 13:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nWKR6uPZUpsHw9fLiQN+tCUhIOQtuUG869jNO4i86ZY=; b=zCmBXWoZlo8vnNneonA3NxVse4nc66IFq3VJno4tNAO9re9sUKd3L+Z0guEB98fPy8 FXZetQdRlCWWl9rFiJQ3R+KeyJRs6Q/Z2dderjA8IfoAJGeW8LLrqnCaqhU596rbt3y7 +c/KIIa7L7NTs39+FFknisOw843ETmBr/7dgtFzQUcRFxtSbbCdGVu4zKXJcO0ZycnNq M8ZcObc29z8SeR5e2m9PZajksMspnAxoA1waBuVq8MxsOiykte5wSO4cAJyOvldrxnIT sFFWlVHie1kacdJh4CN/bktqpiBcbAO5QTQEeoQULugFILLEPeoG8UJ32hbXOWqSnI/j fsnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nWKR6uPZUpsHw9fLiQN+tCUhIOQtuUG869jNO4i86ZY=; b=ukgvsgOb9ii7+shDBeR6WW4ymMuh0yNWR6SVayOgbTlnYT8K8CQKvmn7U1RnCwjIBW GyU5DZUgq7cZqhMNdL4JhRQGYzdgQDHY7mJU+gzZtrP/7yBJxWzyKi9RDV/J9H+OcN6J lHv52D7FIcygo+3FfcqgJsTCbWplCVEwT3xnoEzVfHLFdeXaMiAuiqB1TaOER+z8b3OE YNv8R7/l6UETuvLa7ptDx0ga5SnyEUQwmjPLMsJg0fMUDJ7+QQw9USyTOPmolXW9Qdvs JD5YLzeVZbcrLMzUI3oTLje7wNcrJFrMGA1626452dNVrJWWm1tmD6MASpy6MX1lNHvT dEzg== X-Gm-Message-State: AOAM533RQE/kbLiFNFau55dM1zg2R+JnRJlnlZIvZbHGxm4V0n7tNqLc +JNy1EBAhMMOVL2cu1gCrnymXA== X-Received: by 2002:adf:ec47:: with SMTP id w7mr4705484wrn.253.1604698634708; Fri, 06 Nov 2020 13:37:14 -0800 (PST) Received: from dell.default ([91.110.221.236]) by smtp.gmail.com with ESMTPSA id d16sm3984942wrw.17.2020.11.06.13.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 13:37:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH v2 11/23] mtd: ubi: eba: Fix a couple of misdocumentation issues Date: Fri, 6 Nov 2020 21:36:43 +0000 Message-Id: <20201106213655.1838861-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201106213655.1838861-1-lee.jones@linaro.org> References: <20201106213655.1838861-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_163715_818229_DD76FD3A X-CRM114-Status: GOOD ( 15.70 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Miquel Raynal Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org Fixes the following W=1 kernel build warning(s): drivers/mtd/ubi/eba.c:1304: warning: Function parameter or member 'vidb' not described in 'ubi_eba_copy_leb' drivers/mtd/ubi/eba.c:1304: warning: Excess function parameter 'vid_hdr' description in 'ubi_eba_copy_leb' drivers/mtd/ubi/eba.c:1483: warning: Function parameter or member 'ai' not described in 'print_rsvd_warning' Cc: Richard Weinberger Cc: Miquel Raynal Cc: Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/ubi/eba.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 0edecfdbd01f3..892494c8cb7c7 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -1290,7 +1290,7 @@ static int is_error_sane(int err) * @ubi: UBI device description object * @from: physical eraseblock number from where to copy * @to: physical eraseblock number where to copy - * @vid_hdr: VID header of the @from physical eraseblock + * @vidb: data structure from where the VID header is derived * * This function copies logical eraseblock from physical eraseblock @from to * physical eraseblock @to. The @vid_hdr buffer may be changed by this @@ -1463,6 +1463,7 @@ int ubi_eba_copy_leb(struct ubi_device *ubi, int from, int to, /** * print_rsvd_warning - warn about not having enough reserved PEBs. * @ubi: UBI device description object + * @ai: UBI attach info object * * This is a helper function for 'ubi_eba_init()' which is called when UBI * cannot reserve enough PEBs for bad block handling. This function makes a