mbox series

[PATCHv3,0/3] Lost key-up interrupt handling for omap4-keypad

Message ID 20200318225727.29327-1-tony@atomide.com
Headers show
Series Lost key-up interrupt handling for omap4-keypad | expand

Message

Tony Lindgren March 18, 2020, 10:57 p.m. UTC
Hi all,

This series updates omap4-keypad to disable unused long interrupts, and
implements the missing parts for the lost key-up interrupt quirk as
described in the silicon errata pdf.

Regards,

Tony


Changes since v2:

- Drop bogus level change, that already comes from device tree

- Scan keyboard in two phases and simplify using a bitmask

- Use mod_delayed_work and cancel_delayed_work_sync for the quirk


Tony Lindgren (3):
  Input: omap4-keypad - disable unused long interrupts
  Input: omap4-keypad - Scan keys in two phases and simplify with
    bitmask
  Input: omap4-keypad - check state again for lost key-up interrupts

 drivers/input/keyboard/omap4-keypad.c | 124 ++++++++++++++++++++------
 1 file changed, 95 insertions(+), 29 deletions(-)

Comments

Pavel Machek Sept. 8, 2020, 8:52 a.m. UTC | #1
Hi!

> This series updates omap4-keypad to disable unused long interrupts, and

> implements the missing parts for the lost key-up interrupt quirk as

> described in the silicon errata pdf.


I do not see this in 5.9-rc4; problem is real, could we get this
merged?

Best regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Tony Lindgren Sept. 9, 2020, 6 a.m. UTC | #2
* Pavel Machek <pavel@ucw.cz> [200908 08:52]:
> Hi!

> 

> > This series updates omap4-keypad to disable unused long interrupts, and

> > implements the missing parts for the lost key-up interrupt quirk as

> > described in the silicon errata pdf.

> 

> I do not see this in 5.9-rc4; problem is real, could we get this

> merged?


Sorry for the slow going here. FYI, I'm still seeing stuck keys few times
a day though. It seems to be with the last entered key now though.

Regards,

Tony