mbox series

[v4,0/2] Convert TI dmtimer binding to yaml

Message ID 20220413081042.27088-1-tony@atomide.com
Headers show
Series Convert TI dmtimer binding to yaml | expand

Message

Tony Lindgren April 13, 2022, 8:10 a.m. UTC
Hi,

Here's v4 changes for TI dmtimer changes. I kept Krzysztof's ack for
the second patch as the rebase on updated first patch was trivial.

Regards,

Tony


Changes since v1:

- Improve yaml for various checks based on comments from Krzysztof
  and Nishanth

- Add checks for am4 timer as pointed out by Krzysztof and Rob

- Split am6 additions into a separate patch as suggested by Krzysztof

Changes since v2:

- Improve yaml for more checks based on comments from Grygorii and
  Krzysztof

Changes since v3:

- Simplify constraints for reg, clocks and clock-names as suggested by
  Krzysztof

- Use version number for patches too as suggested by Rob


Tony Lindgren (2):
  dt-bindings: timer: Update TI timer to yaml
  dt-bindings: timer: Add compatible for am6 for TI timer-dm

 .../bindings/pwm/pwm-omap-dmtimer.txt         |   2 +-
 .../bindings/timer/ti,timer-dm.yaml           | 158 ++++++++++++++++++
 .../devicetree/bindings/timer/ti,timer.txt    |  44 -----
 3 files changed, 159 insertions(+), 45 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/timer/ti,timer-dm.yaml
 delete mode 100644 Documentation/devicetree/bindings/timer/ti,timer.txt

Comments

Tony Lindgren April 13, 2022, 8:42 a.m. UTC | #1
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [220413 08:34]:
> On 13/04/2022 10:10, Tony Lindgren wrote:
> > +allOf:
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              enum:
> > +                - ti,omap3430-timer
> > +                - ti,omap4430-timer
> > +                - ti,omap5430-timer
> > +    then:
> > +      properties:
> > +        reg:
> > +          items:
> > +            - description: IO address
> 
> You can skip the items because they are the same as in properties
> before. Just keep maxItems:1.

OK great.

> > +          maxItems: 1
> > +        clocks:
> > +          items:
> > +            - description: Functional clock
> 
> The same.
> 
> > +          maxItems: 1
> > +        clock-names:
> > +          items:
> > +            - const: fck
> 
> The same.
> 
> > +          maxItems: 1
> 
> Rest is good.

OK

Thanks,

Tony