| Message ID | 20240213105730.5287-1-tony@atomide.com |
|---|---|
| Headers | show |
| Series | Use reg instead of ti,bit-shift for clksel | expand |
On Tue, 13 Feb 2024 12:56:40 +0200 Tony Lindgren <tony@atomide.com> wrote: > Hi all, > > This series updates the clksel clocks to use the standard reg property > instead of ti,bit-shift. > > I'd like to apply these before we make further use of the clksel clocks > to reduce the dtb check warnings. > hmm, we still have ti,bit-shift if these clocks are not used below a ti,clksel. Just wondering, can we completely deorbit ti,bit-shift if we used #address-cells = <2>; in those cases? I wait a bit with further txt->yaml conversions until this is settled. Regards, Andreas
* Andreas Kemnade <andreas@kemnade.info> [240213 23:11]: > On Tue, 13 Feb 2024 12:56:40 +0200 > Tony Lindgren <tony@atomide.com> wrote: > > > Hi all, > > > > This series updates the clksel clocks to use the standard reg property > > instead of ti,bit-shift. > > > > I'd like to apply these before we make further use of the clksel clocks > > to reduce the dtb check warnings. > > > > hmm, we still have ti,bit-shift if these clocks are not used below a ti,clksel. > Just wondering, can we completely deorbit ti,bit-shift if we used #address-cells = <2>; > in those cases? I wait a bit with further txt->yaml conversions until > this is settled. No need to wait on the yaml conversion I think :) How about just tag the ti,bit-shift property as deprecated? And add a comment saying it is only needed for the remaining unconnected clocks. Eventually we can move all the component clocks under clksel clocks, or the related clock such as the dpll clock for the clkdcoldo clocks. Regards, Tony
Quoting Tony Lindgren (2024-02-13 02:56:41) > In order to use #address-cells = <1> and start making use of the > standard reg property, let's prepare things to ignore the possible > address in the clock node name. > > Unless the clock-output-names property is used, the legacy clocks still > fall back to matching the clock data based on the node name. > > We use cleanup.h to simplify the return path for freeing tmp. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- Acked-by: Stephen Boyd <sboyd@kernel.org>
* Tony Lindgren <tony@atomide.com> [240214 05:41]: > * Andreas Kemnade <andreas@kemnade.info> [240213 23:11]: > > On Tue, 13 Feb 2024 12:56:40 +0200 > > Tony Lindgren <tony@atomide.com> wrote: > > > > > Hi all, > > > > > > This series updates the clksel clocks to use the standard reg property > > > instead of ti,bit-shift. > > > > > > I'd like to apply these before we make further use of the clksel clocks > > > to reduce the dtb check warnings. > > > > > > > hmm, we still have ti,bit-shift if these clocks are not used below a ti,clksel. > > Just wondering, can we completely deorbit ti,bit-shift if we used #address-cells = <2>; > > in those cases? I wait a bit with further txt->yaml conversions until > > this is settled. > > No need to wait on the yaml conversion I think :) How about just tag the > ti,bit-shift property as deprecated? And add a comment saying it is only > needed for the remaining unconnected clocks. > > Eventually we can move all the component clocks under clksel clocks, or the > related clock such as the dpll clock for the clkdcoldo clocks. Oh and yes, using #clock-cells = <2> would be nice eventually :) I think the clkcel binding already supports that. But that still leaves the issue of unconnected composite clocks.. I'm pretty sure they all have some real parent like clksel for dpll though. If you had some good idea in mind for the #address-cells = <2> for the remaining unconnected composite clocks maybe clarify it a bit. Regards, Tony
Hi Tony, On Thu, 29 Feb 2024 09:06:26 +0200 Tony Lindgren <tony@atomide.com> wrote: > * Tony Lindgren <tony@atomide.com> [240214 05:41]: > > * Andreas Kemnade <andreas@kemnade.info> [240213 23:11]: > > > On Tue, 13 Feb 2024 12:56:40 +0200 > > > Tony Lindgren <tony@atomide.com> wrote: > > > > > > > Hi all, > > > > > > > > This series updates the clksel clocks to use the standard reg property > > > > instead of ti,bit-shift. > > > > > > > > I'd like to apply these before we make further use of the clksel clocks > > > > to reduce the dtb check warnings. > > > > > > > > > > hmm, we still have ti,bit-shift if these clocks are not used below a ti,clksel. > > > Just wondering, can we completely deorbit ti,bit-shift if we used #address-cells = <2>; > > > in those cases? I wait a bit with further txt->yaml conversions until > > > this is settled. > > > > No need to wait on the yaml conversion I think :) How about just tag the > > ti,bit-shift property as deprecated? And add a comment saying it is only > > needed for the remaining unconnected clocks. > > > > Eventually we can move all the component clocks under clksel clocks, or the > > related clock such as the dpll clock for the clkdcoldo clocks. > > Oh and yes, using #clock-cells = <2> would be nice eventually :) I think > the clkcel binding already supports that. But that still leaves the issue > of unconnected composite clocks.. I'm pretty sure they all have some real > parent like clksel for dpll though. > > If you had some good idea in mind for the #address-cells = <2> for the > remaining unconnected composite clocks maybe clarify it a bit. > I was just wondering whether we could do reg = <register bit> then. Regards, Andreas
* Andreas Kemnade <andreas@kemnade.info> [240302 19:18]: > Tony Lindgren <tony@atomide.com> wrote: > > If you had some good idea in mind for the #address-cells = <2> for the > > remaining unconnected composite clocks maybe clarify it a bit. > > > I was just wondering whether we could do reg = <register bit> then. Yeah sure nothing stopping us from doing that too if it helps :) Regards, Tony
Hi all, This series updates the clksel clocks to use the standard reg property instead of ti,bit-shift. I'd like to apply these before we make further use of the clksel clocks to reduce the dtb check warnings. Regards, Tony Tony Lindgren (4): clk: ti: Handle possible address in the node name clk: ti: Improve clksel clock bit parsing for reg property ARM: dts: am3: Update clksel clocks to use reg instead of ti,bit-shift ARM: dts: omap3: Update clksel clocks to use reg instead of ti,bit-shift arch/arm/boot/dts/ti/omap/am33xx-clocks.dtsi | 39 +- arch/arm/boot/dts/ti/omap/am35xx-clocks.dtsi | 18 +- .../boot/dts/ti/omap/omap3430es1-clocks.dtsi | 52 +- .../dts/ti/omap/omap34xx-omap36xx-clocks.dtsi | 86 +-- ...map36xx-am35xx-omap3430es2plus-clocks.dtsi | 28 +- .../arm/boot/dts/ti/omap/omap36xx-clocks.dtsi | 7 +- .../omap/omap36xx-omap3430es2plus-clocks.dtsi | 46 +- .../arm/boot/dts/ti/omap/omap3xxx-clocks.dtsi | 510 +++++++++--------- drivers/clk/ti/apll.c | 11 +- drivers/clk/ti/clk.c | 71 ++- drivers/clk/ti/clock.h | 1 + drivers/clk/ti/divider.c | 5 +- drivers/clk/ti/gate.c | 9 +- drivers/clk/ti/interface.c | 4 +- drivers/clk/ti/mux.c | 6 +- include/linux/clk/ti.h | 3 + 16 files changed, 491 insertions(+), 405 deletions(-)